types: support working with binary for Python 3 by DifferentialOrange · Pull Request #211 · tarantool/tarantool-python

DifferentialOrange · 2022-03-15T14:09:16Z

Merge after #213

This is a breaking change.

Before this patch, both bytes and str were encoded as mp_str. It was
possible to work with utf and non-utf strings, but not with
varbinary (mp_bin) [1]. This patch adds varbinary support for Python 3
by default. With Python 2 the behavior of the connector remains the same.

Before this patch:

encoding="utf-8" (default)
Python 3 -> Tarantool -> Python 3
str -> mp_str (string) -> str
bytes -> mp_str (string) -> str
mp_bin (varbinary) -> bytes
encoding=None
Python 3 -> Tarantool -> Python 3
bytes -> mp_str (string) -> bytes
str -> mp_str (string) -> bytes
mp_bin (varbinary) -> bytes

Using bytes as key was not supported by several methods (delete,
update, select).

After this patch:

encoding="utf-8" (default)
Python 3 -> Tarantool -> Python 3
str -> mp_str (string) -> str
bytes -> mp_bin (varbinary) -> bytes
encoding=None
Python 3 -> Tarantool -> Python 3
bytes -> mp_str (string) -> bytes
str -> mp_str (string) -> bytes
mp_bin (varbinary) -> bytes

Using bytes as key are now supported by all methods.

Thus, encoding="utf-8" connection may be used to work with
utf-8 strings and varbinary and encodine=None connection
may be used to work with non-utf-8 strings.

This patch does not add new restrictions (like "do not permit to use
str in encoding=None mode because result may be confusing") to preserve
current behavior (for example, using space name as str in schema
get_space).

Introduce VARBINARY field type tarantool#4201

Closes#105

DifferentialOrange · 2022-03-23T06:42:00Z

Note: test this PR rebased on #213 to ensure different msgpack package version compatiility

Totktonada

I have no objections, just several suggestions.

LGTM.

This patch add CHANGELOG.md file. Current CHANGELOG contents covers version 0.7.0, 0.7.1 changes and currently unreleased changes. For changes in versions before 0.7.0, see releases GitHub page [1]. 1. https://github.com/tarantool/tarantool-python/releases

Totktonada · 2022-04-01T22:22:14Z

I glanced over the changes and I'm completely okay here. Please, finish the review with Sergey and proceed.

ligurio

Thanks for the patch!

LGTM

This is a breaking change. Before this patch, both bytes and str were encoded as mp_str. It was possible to work with utf and non-utf strings, but not with varbinary (mp_bin) [1]. This patch adds varbinary support for Python 3 by default. With Python 2 the behavior of the connector remains the same. Before this patch: * encoding="utf-8" (default) Python 3 -> Tarantool -> Python 3 str -> mp_str (string) -> str bytes -> mp_str (string) -> str mp_bin (varbinary) -> bytes * encoding=None Python 3 -> Tarantool -> Python 3 bytes -> mp_str (string) -> bytes str -> mp_str (string) -> bytes mp_bin (varbinary) -> bytes Using bytes as key was not supported by several methods (delete, update, select). After this patch: * encoding="utf-8" (default) Python 3 -> Tarantool -> Python 3 str -> mp_str (string) -> str bytes -> mp_bin (varbinary) -> bytes * encoding=None Python 3 -> Tarantool -> Python 3 bytes -> mp_str (string) -> bytes str -> mp_str (string) -> bytes mp_bin (varbinary) -> bytes Using bytes as key are now supported by all methods. Thus, encoding="utf-8" connection may be used to work with utf-8 strings and varbinary and encodine=None connection may be used to work with non-utf-8 strings. This patch does not add new restrictions (like "do not permit to use str in encoding=None mode because result may be confusing") to preserve current behavior (for example, using space name as str in schema get_space). 1. tarantool/tarantool#4201Closes#105

Since the release of tarantool/python 0.8.0 [1] several things has changed. * Issue #105 has been fixed [2]. * CI has been migrated to GitHub Actions [3]. * New connection pool (ConnectionPool) with master discovery was introduced [4]. * old connection pool (MeshConnection) with round-robin failover was deprecated [4]. These changes together with GitHub stars update are introduced with this patch. 1. https://github.com/tarantool/tarantool-python/releases/tag/0.8.0 2. tarantool/tarantool-python#211 3. tarantool/tarantool-python#213 4. tarantool/tarantool-python#207

Since the release of tarantool-python 0.8.0 [1] several things has changed. * Issue tarantool/tarantool-python#105 has been fixed [2]. * CI has been migrated to GitHub Actions [3]. * New connection pool (ConnectionPool) with master discovery was introduced [4]. * old connection pool (MeshConnection) with round-robin failover was deprecated [4]. These changes together with GitHub stars update are introduced with this patch. 1. https://github.com/tarantool/tarantool-python/releases/tag/0.8.0 2. tarantool/tarantool-python#211 3. tarantool/tarantool-python#213 4. tarantool/tarantool-python#207

* Update python connector comparison table Since the release of tarantool-python 0.8.0 [1] several things has changed. * Issue tarantool/tarantool-python#105 has been fixed [2]. * CI has been migrated to GitHub Actions [3]. * New connection pool (ConnectionPool) with master discovery was introduced [4]. * old connection pool (MeshConnection) with round-robin failover was deprecated [4]. These changes together with GitHub stars update are introduced with this patch. 1. https://github.com/tarantool/tarantool-python/releases/tag/0.8.0 2. tarantool/tarantool-python#211 3. tarantool/tarantool-python#213 4. tarantool/tarantool-python#207 * Update translation Co-authored-by: Patience Daur <patiencedaur@gmail.com>

See PR [1]. 1. #211Closes#212

DifferentialOrange force-pushed the DifferentialOrange/gh-105-unpack-binary branch 2 times, most recently from 6efb9de to 7da60f3Compare March 16, 2022 09:38

DifferentialOrange changed the title ~~Differential orange/gh 105 unpack binary~~types: support working with binary for Python 3Mar 16, 2022

DifferentialOrange force-pushed the DifferentialOrange/gh-105-unpack-binary branch from 7da60f3 to 797d33dCompare March 16, 2022 10:00

DifferentialOrange marked this pull request as ready for review March 16, 2022 11:24

DifferentialOrange requested review from Totktonada and ligurio March 16, 2022 11:33

DifferentialOrange force-pushed the DifferentialOrange/gh-105-unpack-binary branch from 797d33d to 6aa89a6Compare March 16, 2022 13:13

DifferentialOrange mentioned this pull request Mar 17, 2022
Introduce ConnectionPool with master discovery #207
Merged

ligurio suggested changes Mar 22, 2022
View reviewed changes

Comment threadtarantool/utils.py Outdated
Comment threadtest/suites/test_dml.py Outdated
Comment threadtest/suites/test_dml.py Outdated
Comment threadtarantool/request.py
Comment threadtest/suites/test_dml.py Outdated

DifferentialOrange force-pushed the DifferentialOrange/gh-105-unpack-binary branch 4 times, most recently from 8772bc7 to 155b1d7Compare March 23, 2022 08:12

DifferentialOrange changed the base branch from master to DifferentialOrange/gh-182-github-actionsMarch 23, 2022 08:12

Totktonada approved these changes Mar 29, 2022
View reviewed changes

Comment threadtest/suites/test_dml.py Outdated
Comment threadtest/suites/test_dml.py Outdated
Comment threadtest/suites/test_dml.py Outdated
Comment threadtarantool/request.py

DifferentialOrange force-pushed the DifferentialOrange/gh-182-github-actions branch 5 times, most recently from c46c513 to 44fc747Compare March 31, 2022 08:29

Base automatically changed from DifferentialOrange/gh-182-github-actions to masterMarch 31, 2022 08:37

DifferentialOrange force-pushed the DifferentialOrange/gh-105-unpack-binary branch 3 times, most recently from 4ec6748 to 88fa990Compare March 31, 2022 16:00

DifferentialOrange force-pushed the DifferentialOrange/gh-105-unpack-binary branch from 2a4194e to 4b8ae94Compare April 1, 2022 09:24

DifferentialOrange requested a review from Totktonada April 1, 2022 10:00

Totktonada reviewed Apr 1, 2022
View reviewed changes

Comment threadCHANGELOG.md Outdated

DifferentialOrange force-pushed the DifferentialOrange/gh-105-unpack-binary branch from 4b8ae94 to 3d71614Compare April 2, 2022 07:29

DifferentialOrange requested a review from ligurio April 2, 2022 07:38

ligurio approved these changes Apr 4, 2022
View reviewed changes

Comment threadCHANGELOG.md Outdated

DifferentialOrange force-pushed the DifferentialOrange/gh-105-unpack-binary branch from 3d71614 to dd6ef5bCompare April 4, 2022 12:08

DifferentialOrange merged commit 9343e83 into masterApr 4, 2022

DifferentialOrange deleted the DifferentialOrange/gh-105-unpack-binary branch April 4, 2022 16:21

DifferentialOrange mentioned this pull request May 11, 2022
Update python connector comparison table tarantool/doc#2863
Merged

DifferentialOrange added a commit that referenced this pull request Sep 21, 2022
code-health: remove string encoding compatibility
1bca525
See PR [1]. 1. #211Closes#212

DifferentialOrange mentioned this pull request Sep 21, 2022
Cleanup Python 2 compatibility wrappers #231
Merged

DifferentialOrange added a commit that referenced this pull request Sep 21, 2022
code-health: remove string encoding compatibility
34df802
See PR [1]. 1. #211Closes#212

DifferentialOrange added a commit that referenced this pull request Sep 22, 2022
code-health: remove string encoding compatibility
4f9b771
See PR [1]. 1. #211Closes#212

DifferentialOrange added a commit that referenced this pull request Sep 26, 2022
code-health: remove string encoding compatibility
cd475e1
See PR [1]. 1. #211Closes#212

DifferentialOrange added a commit that referenced this pull request Sep 26, 2022
code-health: remove string encoding compatibility
0936426
See PR [1]. 1. #211Closes#212

DifferentialOrange added a commit that referenced this pull request Oct 5, 2022
code-health: remove string encoding compatibility
e9a4af6
See PR [1]. 1. #211Closes#212

DifferentialOrange added a commit that referenced this pull request Oct 5, 2022
code-health: remove string encoding compatibility
2199421
See PR [1]. 1. #211Closes#212

DifferentialOrange added a commit that referenced this pull request Oct 6, 2022
code-health: remove string encoding compatibility
ec97d90
See PR [1]. 1. #211Closes#212

DifferentialOrange added a commit that referenced this pull request Oct 10, 2022
code-health: remove string encoding compatibility
12de422
See PR [1]. 1. #211Closes#212

Navigation Menu

Uh oh!

types: support working with binary for Python 3 - #211

types: support working with binary for Python 3#211
DifferentialOrange merged 2 commits into
masterfrom
DifferentialOrange/gh-105-unpack-binary

DifferentialOrange commented Mar 15, 2022•
edited
Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DifferentialOrange commented Mar 23, 2022

Uh oh!

Totktonada left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Totktonada commented Apr 1, 2022

Uh oh!

ligurio left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Python 3	->	Tarantool	->	Python 3
str	->	mp_str (string)	->	str
bytes	->	mp_str (string)	->	str
		mp_bin (varbinary)	->	bytes

Uh oh!

Conversation

DifferentialOrange commented Mar 15, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DifferentialOrange commented Mar 23, 2022

Uh oh!

Totktonada left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Totktonada commented Apr 1, 2022

Uh oh!

ligurio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

DifferentialOrange commented Mar 15, 2022•
edited
Loading