Uh oh!
There was an error while loading. Please reload this page.
api: extend connect with fetch_schema param - #271
Conversation
88aaa84 to
0aeaef7CompareDifferentialOrange
commented
Dec 13, 2022
So there won't be any way to use a connection for any space operations? Only calls and evals? To be honest, I don't quite get this one without tests. |
GRISHNOV
commented
Dec 19, 2022
I suppose, it is. |
0aeaef7 to
c462575CompareGRISHNOV
commented
Dec 19, 2022
Now the connection with |
DifferentialOrange
left a comment
There was a problem hiding this comment.
Thank you for your PR and sorry I'm a bit late (I wasn't sure that it was ready for review).
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
DifferentialOrange
commented
Dec 26, 2022
You'll also need to rebase, sorry for the inconveniences |
244e67c to
b4472cdCompareGRISHNOV
commented
Dec 26, 2022
While working on the task, I noticed that there is an issue in the CRUD tests. |
DifferentialOrange
left a comment
There was a problem hiding this comment.
Thank you for the updates! There are still some things we need to resolve
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
639a9d5 to
3fc3701Comparec57fdfb to
eed5833Compareeed5833 to
b333b6fCompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
b333b6f to
fdc10f3CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
fdc10f3 to
84b7617CompareGRISHNOV
commented
Jan 11, 2023
Thanks for the feedback! I've made all the corrections. At the moment there is a problem with tests that fall with variable probability. At the moment, it is difficult to determine the cause, but the problem, as far as I can see, is related to the # Turning the same connection into schemafull.ifmodeisnotNone:
foraddrincon.pool.keys():
con.pool[addr].conn.update_schema(con.pool[addr].conn.schema_version) # <------else:
con.update_schema(con.schema_version)It looks like there is a desynchronization with the transmitted |
Uh oh!
There was an error while loading. Please reload this page.
84b7617 to
161a9c8Compare
DifferentialOrange
left a comment
There was a problem hiding this comment.
Everything seems good, I'll wait till you resolve this flaky test issue.
f7edf6a to
15a5655CompareIn crud tests, if the necessary rocks dependencies are missing, an error message is now displayed. Prior to this fix, an error in importing missing models caused the tests to freez forever. Part of #205
Added support of the fetch_schema parameter, which allows to ignore schema changes on the server. Closes#219
15a5655 to
d89651eCompareDifferentialOrange
commented
Jan 12, 2023
Ping me when everything is ready |
Added support of the
fetch_schemaparameter, which allows to ignore schema changes on the server.By default, it is used
fetch_schema = True:If the
fetch_schemais specified asFalse, fieldsschema_versionandschemawill no longer be present in theconnectionobject:In this case, requests to the server via the
connection.update_schemawill no longer be made when there isSchemaReloadException.Closes#219