Uh oh!
There was an error while loading. Please reload this page.
api: support authentication methods - #273
Merged
DifferentialOrange merged 1 commit intoDec 26, 2022
Merged
Conversation
DifferentialOrangeforce-pushed
the
DifferentialOrange/gh-269-pap-sha-auth
branch
from
December 24, 2022 10:02
3a96aec to
38b8575CompareDifferentialOrange
changed the base branch from
master
to
DifferentialOrange/gh-224-ssl-passwordDecember 24, 2022 13:22
DifferentialOrangeforce-pushed
the
DifferentialOrange/gh-269-pap-sha-auth
branch
from
December 24, 2022 13:28
562abd7 to
9b644d4CompareDifferentialOrange
marked this pull request as ready for review
December 24, 2022 13:47
oleg-jukovec
approved these changes
Dec 25, 2022
oleg-jukovec
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the patch!
MemberAuthor
Thank you for the review! Can you also check this one #274 ? |
Base automatically changed from
DifferentialOrange/gh-224-ssl-password to
masterDecember 26, 2022 08:19
Since Tarantool master 2574ff1a configuring authentication type is supported [1-2]. Together with this, Tarantool EE had introduced pap-sha256 authentication method support [3-4]. It can be used only together with SSL transport. To configure, use `auth_type` option in Connection, MeshConnection or ConnectionPool. Newest master (there is no dev build in customer zone yet) supports providing authentication method via IPROTO_ID response. So in this patch we also move ID request to be executed before authentication. 1. tarantool/tarantool#7988 2. tarantool/tarantool#7989 3. tarantool/tarantool-ee#295 4. tarantool/tarantool-ee#322Closes#269
DifferentialOrangeforce-pushed
the
DifferentialOrange/gh-269-pap-sha-auth
branch
from
December 26, 2022 08:19
9b644d4 to
b0eaf0cCompareDifferentialOrange
deleted the
DifferentialOrange/gh-269-pap-sha-auth
branch
December 26, 2022 09:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge after #274
Since Tarantool master 2574ff1a configuring authentication type is
supported [1-2]. Together with this, Tarantool EE had introduced
pap-sha256 authentication method support [3-4]. It can be used only
together with SSL transport. To configure, use
auth_typeoption inConnection, MeshConnection or ConnectionPool.
Newest master (there is no dev build in customer zone yet) supports
providing authentication method via IPROTO_ID response. So in this patch
we also move ID request to be executed before authentication.
Closes#269