Uh oh!
There was an error while loading. Please reload this page.
iproto: disable feature discovery for specific versions - #284
Conversation
22a617c to
582016fCompare
DifferentialOrange
left a comment
There was a problem hiding this comment.
Thank you for your PR! Seems good. Can you add a changelog entry?
BTW, would you want a tagged release after I merge this one?
582016f to
7541aa0Compareolegrok
commented
Feb 27, 2023
Yes. Fixed.
If you don't have any plans to add new features then yes. Otherwise I could wait some time. |
DifferentialOrange
commented
Feb 27, 2023
It seems that there is a bug issue which could also be fixed relatively quickly, so I'll release after we'll work through #282 too. But |
Uh oh!
There was an error while loading. Please reload this page.
"IProto features" are available since Tarantool 2.10 and there is no need to even try to fetch them for lower versions. Such check there is in netbox code [1]. Before this patch cartridge remote control closed the connection after RequestProtocolVersion however but for netbox it worked fine. So let's uniform behaviour between connectors adding a small check to skip request if there is a gurarntee that "IProto features" are not supported. Closestarantool#283 [1] tarantool/tarantool@2cbec82#diff-a47383908beda20a06c9f64bf5c3d4c51879034e38bcdccdf45210e89ce6dfb7R1947
7541aa0 to
cd72939Compare
"IProto features" are available since Tarantool 2.10 and there is no need to even try to fetch them for lower versions. Such check there is in netbox code [1].
Before this patch cartridge remote control closed the connection after RequestProtocolVersion however but for netbox it worked fine.
So let's uniform behaviour between connectors adding a small check to skip request if there is a gurarntee that "IProto features" are not supported.
Closes#283
[1] tarantool/tarantool@2cbec82#diff-a47383908beda20a06c9f64bf5c3d4c51879034e38bcdccdf45210e89ce6dfb7R1947