Uh oh!
There was an error while loading. Please reload this page.
Get rid of pandas dependency - #291
Merged
DifferentialOrange merged 1 commit intoApr 17, 2023
Merged
Conversation
DifferentialOrangeforce-pushed
the
DifferentialOrange/gh-290-custom-datetime
branch
5 times, most recently
from
April 14, 2023 15:25
606bd08 to
96c72d6CompareDifferentialOrange
marked this pull request as ready for review
April 14, 2023 16:58
oleg-jukovec
approved these changes
Apr 17, 2023
oleg-jukovec
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the patch!
Uh oh!
There was an error while loading. Please reload this page.
Rework our implementation of tarantool.Datetime class. Previously it had relied on pandas.Timestamp and pandas.Timedelta. There were user complaints about pandas as a requirement since it's rather heavy. Now our implementation of datetime uses built-in datetime.datetime, datetime.timedelta and other built-in tools. It is expected that the implementation change wouldn't affect users, but some minor behavior traits were broken in this patch: - Now we rely on datetime argument validation which if differs from pandas one. For example, it doesn't allow overflows for fields. Exceptions that user may receive from internal datetime are, of course, had changed as well. - We drop the support of `__eq__` for pandas.Timestamp. We simply compared underlying pandas.Timestamp with argument one, and now it's impossible. If the feature would be required later, we may implement its comparison in some compatible way. - `__repr__` has been changed since internal representation has been changed as well. Closes#290
DifferentialOrangeforce-pushed
the
DifferentialOrange/gh-290-custom-datetime
branch
from
April 17, 2023 08:43
96c72d6 to
5215d42CompareDifferentialOrange
deleted the
DifferentialOrange/gh-290-custom-datetime
branch
April 17, 2023 08:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework our implementation of tarantool.Datetime class. Previously it had relied on pandas.Timestamp and pandas.Timedelta. There were user complaints about pandas as a requirement since it's rather heavy. Now our implementation of datetime uses built-in datetime.datetime, datetime.timedelta and some other built-in tools.
It is expected that the implementation change wouldn't affect users, but some minor behavior traits were broken in this patch:
__eq__for pandas.Timestamp. We simply compared underlying pandas.Timestamp with argument one, and now it's impossible. If the feature would be useful later, we may implement the comparison in some compatible way.__repr__has been changed since internal representation has been changed as well.Closes#290