conn: create from socket fd by askalt · Pull Request #316 · tarantool/tarantool-python

askalt · 2023-10-31T20:24:06Z

This patch adds the ability to create Tarantool connection using an existing socket fd.

I didn't forget about:

Tests
Changelog

Closes#304

askalt · 2023-11-02T17:08:32Z

There will be one more test (with Tarantool made sockets and child process), but in general it is already ready for the review.

oleg-jukovec

select must have respect the timeout setting for non-blocking sockets.
We need to think what we could to do if fd the socket is blocking and the timeout is set. The only way I see is to turn the socket into non-blocking mode.

oleg-jukovec

Thank you for the patch!

DifferentialOrange

Sorry for the long delay, I was a bit busy. Let's fix the last description and I'll merge it.

DifferentialOrange · 2023-11-10T12:37:41Z

+ raise ConfigurationError("need to specify both host and port, "
+ "port only in the case on Unix sockets, "
+ "or socket_fd in the case of socket fd")


Suggested change
raiseConfigurationError("need to specify both host and port, "
"port only in the case on Unix sockets, "
"or socket_fd in the case of socket fd")
raiseConfigurationError("need to specify host/port, "
"port (in case of Unix sockets)"
"or socket_fd")

This patch adds the ability to create Tarantool connection using an existing socket fd. To achieve this, several changes have been made to work with non-blocking sockets, as `socket.socketpair` creates such [1]. The authentication [2] might have already occured when we establish such a connection. If that's the case, there is no need to pass 'user' argument. On success, connect takes ownership of the `socket_fd`. 1. tarantool/tarantool#8944 2. https://www.tarantool.io/en/doc/latest/dev_guide/internals/iproto/authentication/Closes#304

askalt force-pushed the askalt/gh-304-socket-fd-connection branch 6 times, most recently from f033280 to df0eec0Compare November 1, 2023 09:38

askalt marked this pull request as ready for review November 1, 2023 09:50

askalt requested review from DifferentialOrange and oleg-jukovec November 1, 2023 09:51

askalt marked this pull request as draft November 1, 2023 11:02

askalt removed request for DifferentialOrange and oleg-jukovec November 1, 2023 11:12

askalt force-pushed the askalt/gh-304-socket-fd-connection branch from df0eec0 to 5b9f1ccCompare November 1, 2023 16:50

oleg-jukovec reviewed Nov 1, 2023
View reviewed changes

Comment threadtarantool/connection.py

askalt force-pushed the askalt/gh-304-socket-fd-connection branch 12 times, most recently from c77681b to 8aaece6Compare November 2, 2023 13:49

askalt marked this pull request as ready for review November 2, 2023 17:06

askalt requested a review from DifferentialOrange November 2, 2023 17:06

oleg-jukovec reviewed Nov 2, 2023
View reviewed changes

Comment threadtest/suites/test_socket_fd.py

askalt force-pushed the askalt/gh-304-socket-fd-connection branch 2 times, most recently from 7d6454e to 39815c1Compare November 3, 2023 13:03

askalt requested review from DifferentialOrange and oleg-jukovec November 3, 2023 13:18

oleg-jukovec reviewed Nov 3, 2023
View reviewed changes

Comment threadtarantool/connection.py Outdated

oleg-jukovec reviewed Nov 3, 2023
View reviewed changes

Comment threadtarantool/connection.py Outdated

oleg-jukovec requested changes Nov 3, 2023
View reviewed changes

askalt force-pushed the askalt/gh-304-socket-fd-connection branch from 39815c1 to 02d7bc2Compare November 3, 2023 18:58

oleg-jukovec reviewed Nov 3, 2023
View reviewed changes

Comment threadtarantool/connection.py Outdated

askalt force-pushed the askalt/gh-304-socket-fd-connection branch from 02d7bc2 to 5712143Compare November 3, 2023 20:18

ci: run tests with tarantool CE master
d57cad6

askalt force-pushed the askalt/gh-304-socket-fd-connection branch from 5712143 to 6b00156Compare November 4, 2023 06:44

oleg-jukovec approved these changes Nov 4, 2023
View reviewed changes

Comment threadtarantool/connection.py Outdated

DifferentialOrange reviewed Nov 7, 2023
View reviewed changes

Comment threadtest/suites/test_socket_fd.py Outdated

askalt force-pushed the askalt/gh-304-socket-fd-connection branch 5 times, most recently from d470f82 to 42e7f85Compare November 8, 2023 07:02

askalt requested a review from DifferentialOrange November 8, 2023 07:20

DifferentialOrange reviewed Nov 8, 2023
View reviewed changes

askalt force-pushed the askalt/gh-304-socket-fd-connection branch 2 times, most recently from 195b3c9 to 543e17dCompare November 8, 2023 10:16

askalt requested a review from DifferentialOrange November 9, 2023 07:14

DifferentialOrange approved these changes Nov 10, 2023
View reviewed changes

askalt force-pushed the askalt/gh-304-socket-fd-connection branch from 543e17d to 8da5df2Compare November 10, 2023 15:50

DifferentialOrange approved these changes Nov 13, 2023
View reviewed changes

DifferentialOrange merged commit 2983de8 into masterNov 13, 2023

DifferentialOrange deleted the askalt/gh-304-socket-fd-connection branch November 13, 2023 07:39

-raiseConfigurationError("need to specify both host and port, "
-"port only in the case on Unix sockets, "
-"or socket_fd in the case of socket fd")
+raiseConfigurationError("need to specify host/port, "
+"port (in case of Unix sockets)"
+"or socket_fd")

Uh oh!

Conversation

askalt commented Oct 31, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

askalt commented Nov 2, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

oleg-jukovec left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

oleg-jukovec left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DifferentialOrange left a comment

Choose a reason for hiding this comment

Uh oh!

DifferentialOrangeNov 10, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

askalt commented Oct 31, 2023•
edited
Loading