Read complete pull-request review evidence from a workflow #576

Description

@taras

Story

As a workflow author, I want authenticated, complete pull-request review evidence to be readable through host-owned components, so a network-denied reviewing Agent and the supervising user receive the existing objections and check results before they decide what happens next.

Motivation

The supervised composition in #301 must give both the reviewing Planner and the user every existing review body, pull-request comment, and check result. <PullRequest> deliberately returns only stable evidence about the upsert it reconciled; later reviews, comments, and checks are separate reads.

<Fetch> is not this boundary. It is credential-free, performs one GET or HEAD per invocation, and has no pagination contract. Raw authored credential headers are retained document data rather than host authentication, cannot reliably reach a private repository, and would bypass the adapter-private destination and credential ceiling.

Authoring contract

The workflow host registers three self-closing components beside <PullRequest>:

<PullRequest.Reviews number={pullRequest.number} as="reviews" />
<PullRequest.Comments number={pullRequest.number} as="comments" />
<PullRequest.Checks number={pullRequest.number} as="checks" />
  • Each component has one required positive-integer prop, number, requires ordinary as, accepts no content, and returns one JSON array.
  • The enclosing retained Repository and selected checkout identify the Git repository. There is no repository, URL, host, provider, endpoint, token, credential, page, cursor, or limit prop.
  • Reviews, comments, and checks are separate reads and separate durable effects. One may replay or fail independently of the others; no partial three-list result exists.
  • The values are closed, provider-neutral normalized records. Their implementation plan freezes the exact item schemas before coding. Original review and comment bodies and check conclusions/messages needed by the reader remain byte-for-byte unchanged; raw provider responses and live handles never cross the component boundary.
  • PullRequest.Comments accounts for both pull-request conversation comments and inline review comments. It tags their normalized records so the two kinds cannot be confused.
  • PullRequest.Checks accounts for every check/status result the GitHub pull-request UI associates with the exact head commit read for the numbered pull request. A moved head produces evidence for the newly observed head and retains that head SHA with the result; it is never silently combined with an earlier snapshot.
  • Arrays retain the adapter's deterministic page/item order. An empty array means the authenticated provider completed the collection and found none.

The components render nothing. The caller iterates their arrays with <Each> into the Planner prompt and the user's checkpoint material; it does not stringify or summarize the original evidence.

Authority and authentication

The first adapter is GitHub for repositories on github.com.

  • It reuses the host credential broker shipped by 🔐 Reach a private repository as whoever is running the host #532: GH_TOKEN, then GITHUB_TOKEN, then the machine's gh auth token, acquired lazily for the exact retained locator and disposed with that invocation.
  • The adapter-private ceiling decides which retained repository the credential may reach. Public middleware, props, bindings, a same-name repository component, generated source, and another loaded package copy may narrow or refuse but cannot recover the credential or widen the destination.
  • The pull-request number is checked against the request and retained Repository. A response naming another repository, pull request, or head is a provider protocol failure rather than data.
  • A completed replay opens no authentication session and performs no network request.

Pagination and completeness

Reuse the GitHub adapter's existing pagination boundary: PAGE_SIZE = 100 and PAGE_LIMIT = 32.

  • Follow GitHub's authenticated pagination until the collection is complete.
  • A next relation is followed only on the adapter's authorized API origin.
  • A malformed, off-origin, cyclic, unreadable, or still-present next relation at the page limit makes the read unavailable.
  • Transport failure, rate limiting, authentication failure, an ambiguous 404, malformed JSON, an unreadable item, or an incomplete page walk is unavailable. None becomes an empty or truncated array.
  • The component publishes its result only after the complete collection and every normalized item have been validated.

Retention, replay, and failure

Each invocation is one non-mutating durable read whose identity includes the retained Repository identity, pull-request number, and collection kind. A checks result additionally retains the pull-request head SHA it observed, so the evidence says which revision it describes.

The normalized request and complete result cross the existing secret gate before persistence. No credential, endpoint, raw response, provider identity, host path, or pagination transport state is retained.

Completed replay restores the exact array without authentication or another request. Interruption before the durable result commits may repeat the authenticated GETs; no incomplete list is retained. An unavailable or protocol-invalid read fails the stage with a fixed diagnostic and binds nothing. It never lets the reviewing workflow continue as though there were no existing objections.

Acceptance and focused evidence

  • A private github.com repository is read through the 🔐 Reach a private repository as whoever is running the host #532 credential broker without exposing or retaining the credential.
  • Each component validates its closed self-closing shape before contacting the provider and binds its closed normalized array only through as.
  • Reviews preserve every review body; comments preserve every conversation and inline-review body with an explicit kind; checks preserve every result associated with the exact observed head.
  • Multi-page fixtures beyond one page return every item exactly once in deterministic order.
  • Empty completed collections bind []; unavailable, malformed, off-origin, cyclic, over-limit, rate-limited, unauthorized, and ambiguous-404 walks fail and bind nothing.
  • A payload for another repository, pull request, or head is refused as a protocol failure rather than published.
  • Reviews, comments, and checks are three distinct durable effects. Completing one does not manufacture either of the others.
  • Completed replay performs zero HTTP and credential-broker calls and returns byte-identical normalized evidence.
  • Interruption before commit retains no partial array; continuation performs the unfinished read and commits one complete result.
  • The complete bodies and check evidence reach both the Compose the supervised adversarial implementation workflow #301 Planner prompt and checkpoint material unchanged; replay performs no second read.
  • Ordinary xmd run remains unchanged. The components are installed only by a live or partial workflow host; a completed workflow replay installs no provider.
  • Architecture, executable-MDX, workflow-Workspace, and component inventory prose describe the authenticated read, completeness rule, retention, replay, and failure boundary in present tense.

Focused provider evidence belongs with the existing GitHub adapter suite in packages/workflow/tests/pull-request-github.test.ts; component and durable replay evidence belongs in a new focused pull-request-read suite. The Planner freezes the exact normalized item schemas and named test cases before the Implementor handoff.

Dependencies

Out of scope

  • Pull-request creation, update, merge, close, review submission, commenting, rerunning checks, or any other mutation.
  • Giving an Agent network access, credentials, native tools, a Workspace path, or a direct provider handle.
  • Adding authentication, pagination, mutating methods, or provider selection to <Fetch>.
  • A generic Git-host query language, raw REST/GraphQL component, caller-selected endpoint, or public credential reference.
  • Non-GitHub adapters in the first delivery.
  • Generated-XMD admission of these components.
  • Workflow scheduling or unattended review polling.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + '
      Skip to content

      Read complete pull-request review evidence from a workflow #576

      Description

      @taras

      Story

      As a workflow author, I want authenticated, complete pull-request review evidence to be readable through host-owned components, so a network-denied reviewing Agent and the supervising user receive the existing objections and check results before they decide what happens next.

      Motivation

      The supervised composition in #301 must give both the reviewing Planner and the user every existing review body, pull-request comment, and check result. <PullRequest> deliberately returns only stable evidence about the upsert it reconciled; later reviews, comments, and checks are separate reads.

      <Fetch> is not this boundary. It is credential-free, performs one GET or HEAD per invocation, and has no pagination contract. Raw authored credential headers are retained document data rather than host authentication, cannot reliably reach a private repository, and would bypass the adapter-private destination and credential ceiling.

      Authoring contract

      The workflow host registers three self-closing components beside <PullRequest>:

      <PullRequest.Reviews number={pullRequest.number} as="reviews" />
      <PullRequest.Comments number={pullRequest.number} as="comments" />
      <PullRequest.Checks number={pullRequest.number} as="checks" />
      • Each component has one required positive-integer prop, number, requires ordinary as, accepts no content, and returns one JSON array.
      • The enclosing retained Repository and selected checkout identify the Git repository. There is no repository, URL, host, provider, endpoint, token, credential, page, cursor, or limit prop.
      • Reviews, comments, and checks are separate reads and separate durable effects. One may replay or fail independently of the others; no partial three-list result exists.
      • The values are closed, provider-neutral normalized records. Their implementation plan freezes the exact item schemas before coding. Original review and comment bodies and check conclusions/messages needed by the reader remain byte-for-byte unchanged; raw provider responses and live handles never cross the component boundary.
      • PullRequest.Comments accounts for both pull-request conversation comments and inline review comments. It tags their normalized records so the two kinds cannot be confused.
      • PullRequest.Checks accounts for every check/status result the GitHub pull-request UI associates with the exact head commit read for the numbered pull request. A moved head produces evidence for the newly observed head and retains that head SHA with the result; it is never silently combined with an earlier snapshot.
      • Arrays retain the adapter's deterministic page/item order. An empty array means the authenticated provider completed the collection and found none.

      The components render nothing. The caller iterates their arrays with <Each> into the Planner prompt and the user's checkpoint material; it does not stringify or summarize the original evidence.

      Authority and authentication

      The first adapter is GitHub for repositories on github.com.

      • It reuses the host credential broker shipped by 🔐 Reach a private repository as whoever is running the host #532: GH_TOKEN, then GITHUB_TOKEN, then the machine's gh auth token, acquired lazily for the exact retained locator and disposed with that invocation.
      • The adapter-private ceiling decides which retained repository the credential may reach. Public middleware, props, bindings, a same-name repository component, generated source, and another loaded package copy may narrow or refuse but cannot recover the credential or widen the destination.
      • The pull-request number is checked against the request and retained Repository. A response naming another repository, pull request, or head is a provider protocol failure rather than data.
      • A completed replay opens no authentication session and performs no network request.

      Pagination and completeness

      Reuse the GitHub adapter's existing pagination boundary: PAGE_SIZE = 100 and PAGE_LIMIT = 32.

      • Follow GitHub's authenticated pagination until the collection is complete.
      • A next relation is followed only on the adapter's authorized API origin.
      • A malformed, off-origin, cyclic, unreadable, or still-present next relation at the page limit makes the read unavailable.
      • Transport failure, rate limiting, authentication failure, an ambiguous 404, malformed JSON, an unreadable item, or an incomplete page walk is unavailable. None becomes an empty or truncated array.
      • The component publishes its result only after the complete collection and every normalized item have been validated.

      Retention, replay, and failure

      Each invocation is one non-mutating durable read whose identity includes the retained Repository identity, pull-request number, and collection kind. A checks result additionally retains the pull-request head SHA it observed, so the evidence says which revision it describes.

      The normalized request and complete result cross the existing secret gate before persistence. No credential, endpoint, raw response, provider identity, host path, or pagination transport state is retained.

      Completed replay restores the exact array without authentication or another request. Interruption before the durable result commits may repeat the authenticated GETs; no incomplete list is retained. An unavailable or protocol-invalid read fails the stage with a fixed diagnostic and binds nothing. It never lets the reviewing workflow continue as though there were no existing objections.

      Acceptance and focused evidence

      • A private github.com repository is read through the 🔐 Reach a private repository as whoever is running the host #532 credential broker without exposing or retaining the credential.
      • Each component validates its closed self-closing shape before contacting the provider and binds its closed normalized array only through as.
      • Reviews preserve every review body; comments preserve every conversation and inline-review body with an explicit kind; checks preserve every result associated with the exact observed head.
      • Multi-page fixtures beyond one page return every item exactly once in deterministic order.
      • Empty completed collections bind []; unavailable, malformed, off-origin, cyclic, over-limit, rate-limited, unauthorized, and ambiguous-404 walks fail and bind nothing.
      • A payload for another repository, pull request, or head is refused as a protocol failure rather than published.
      • Reviews, comments, and checks are three distinct durable effects. Completing one does not manufacture either of the others.
      • Completed replay performs zero HTTP and credential-broker calls and returns byte-identical normalized evidence.
      • Interruption before commit retains no partial array; continuation performs the unfinished read and commits one complete result.
      • The complete bodies and check evidence reach both the Compose the supervised adversarial implementation workflow #301 Planner prompt and checkpoint material unchanged; replay performs no second read.
      • Ordinary xmd run remains unchanged. The components are installed only by a live or partial workflow host; a completed workflow replay installs no provider.
      • Architecture, executable-MDX, workflow-Workspace, and component inventory prose describe the authenticated read, completeness rule, retention, replay, and failure boundary in present tense.

      Focused provider evidence belongs with the existing GitHub adapter suite in packages/workflow/tests/pull-request-github.test.ts; component and durable replay evidence belongs in a new focused pull-request-read suite. The Planner freezes the exact normalized item schemas and named test cases before the Implementor handoff.

      Dependencies

      Out of scope

      • Pull-request creation, update, merge, close, review submission, commenting, rerunning checks, or any other mutation.
      • Giving an Agent network access, credentials, native tools, a Workspace path, or a direct provider handle.
      • Adding authentication, pagination, mutating methods, or provider selection to <Fetch>.
      • A generic Git-host query language, raw REST/GraphQL component, caller-selected endpoint, or public credential reference.
      • Non-GitHub adapters in the first delivery.
      • Generated-XMD admission of these components.
      • Workflow scheduling or unattended review polling.

      Activity

      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

      Metadata

      Metadata

      Assignees

      No one assigned

        Labels

        No labels
        No labels

        Projects

        No projects

          Milestone

          No milestone

          Relationships

          None yet

          Development

          No branches or pull requests

          Issue actions

          , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
          Skip to content

          Read complete pull-request review evidence from a workflow #576

          Description

          @taras

          Story

          As a workflow author, I want authenticated, complete pull-request review evidence to be readable through host-owned components, so a network-denied reviewing Agent and the supervising user receive the existing objections and check results before they decide what happens next.

          Motivation

          The supervised composition in #301 must give both the reviewing Planner and the user every existing review body, pull-request comment, and check result. <PullRequest> deliberately returns only stable evidence about the upsert it reconciled; later reviews, comments, and checks are separate reads.

          <Fetch> is not this boundary. It is credential-free, performs one GET or HEAD per invocation, and has no pagination contract. Raw authored credential headers are retained document data rather than host authentication, cannot reliably reach a private repository, and would bypass the adapter-private destination and credential ceiling.

          Authoring contract

          The workflow host registers three self-closing components beside <PullRequest>:

          <PullRequest.Reviews number={pullRequest.number} as="reviews" />
          <PullRequest.Comments number={pullRequest.number} as="comments" />
          <PullRequest.Checks number={pullRequest.number} as="checks" />
          • Each component has one required positive-integer prop, number, requires ordinary as, accepts no content, and returns one JSON array.
          • The enclosing retained Repository and selected checkout identify the Git repository. There is no repository, URL, host, provider, endpoint, token, credential, page, cursor, or limit prop.
          • Reviews, comments, and checks are separate reads and separate durable effects. One may replay or fail independently of the others; no partial three-list result exists.
          • The values are closed, provider-neutral normalized records. Their implementation plan freezes the exact item schemas before coding. Original review and comment bodies and check conclusions/messages needed by the reader remain byte-for-byte unchanged; raw provider responses and live handles never cross the component boundary.
          • PullRequest.Comments accounts for both pull-request conversation comments and inline review comments. It tags their normalized records so the two kinds cannot be confused.
          • PullRequest.Checks accounts for every check/status result the GitHub pull-request UI associates with the exact head commit read for the numbered pull request. A moved head produces evidence for the newly observed head and retains that head SHA with the result; it is never silently combined with an earlier snapshot.
          • Arrays retain the adapter's deterministic page/item order. An empty array means the authenticated provider completed the collection and found none.

          The components render nothing. The caller iterates their arrays with <Each> into the Planner prompt and the user's checkpoint material; it does not stringify or summarize the original evidence.

          Authority and authentication

          The first adapter is GitHub for repositories on github.com.

          • It reuses the host credential broker shipped by 🔐 Reach a private repository as whoever is running the host #532: GH_TOKEN, then GITHUB_TOKEN, then the machine's gh auth token, acquired lazily for the exact retained locator and disposed with that invocation.
          • The adapter-private ceiling decides which retained repository the credential may reach. Public middleware, props, bindings, a same-name repository component, generated source, and another loaded package copy may narrow or refuse but cannot recover the credential or widen the destination.
          • The pull-request number is checked against the request and retained Repository. A response naming another repository, pull request, or head is a provider protocol failure rather than data.
          • A completed replay opens no authentication session and performs no network request.

          Pagination and completeness

          Reuse the GitHub adapter's existing pagination boundary: PAGE_SIZE = 100 and PAGE_LIMIT = 32.

          • Follow GitHub's authenticated pagination until the collection is complete.
          • A next relation is followed only on the adapter's authorized API origin.
          • A malformed, off-origin, cyclic, unreadable, or still-present next relation at the page limit makes the read unavailable.
          • Transport failure, rate limiting, authentication failure, an ambiguous 404, malformed JSON, an unreadable item, or an incomplete page walk is unavailable. None becomes an empty or truncated array.
          • The component publishes its result only after the complete collection and every normalized item have been validated.

          Retention, replay, and failure

          Each invocation is one non-mutating durable read whose identity includes the retained Repository identity, pull-request number, and collection kind. A checks result additionally retains the pull-request head SHA it observed, so the evidence says which revision it describes.

          The normalized request and complete result cross the existing secret gate before persistence. No credential, endpoint, raw response, provider identity, host path, or pagination transport state is retained.

          Completed replay restores the exact array without authentication or another request. Interruption before the durable result commits may repeat the authenticated GETs; no incomplete list is retained. An unavailable or protocol-invalid read fails the stage with a fixed diagnostic and binds nothing. It never lets the reviewing workflow continue as though there were no existing objections.

          Acceptance and focused evidence

          • A private github.com repository is read through the 🔐 Reach a private repository as whoever is running the host #532 credential broker without exposing or retaining the credential.
          • Each component validates its closed self-closing shape before contacting the provider and binds its closed normalized array only through as.
          • Reviews preserve every review body; comments preserve every conversation and inline-review body with an explicit kind; checks preserve every result associated with the exact observed head.
          • Multi-page fixtures beyond one page return every item exactly once in deterministic order.
          • Empty completed collections bind []; unavailable, malformed, off-origin, cyclic, over-limit, rate-limited, unauthorized, and ambiguous-404 walks fail and bind nothing.
          • A payload for another repository, pull request, or head is refused as a protocol failure rather than published.
          • Reviews, comments, and checks are three distinct durable effects. Completing one does not manufacture either of the others.
          • Completed replay performs zero HTTP and credential-broker calls and returns byte-identical normalized evidence.
          • Interruption before commit retains no partial array; continuation performs the unfinished read and commits one complete result.
          • The complete bodies and check evidence reach both the Compose the supervised adversarial implementation workflow #301 Planner prompt and checkpoint material unchanged; replay performs no second read.
          • Ordinary xmd run remains unchanged. The components are installed only by a live or partial workflow host; a completed workflow replay installs no provider.
          • Architecture, executable-MDX, workflow-Workspace, and component inventory prose describe the authenticated read, completeness rule, retention, replay, and failure boundary in present tense.

          Focused provider evidence belongs with the existing GitHub adapter suite in packages/workflow/tests/pull-request-github.test.ts; component and durable replay evidence belongs in a new focused pull-request-read suite. The Planner freezes the exact normalized item schemas and named test cases before the Implementor handoff.

          Dependencies

          Out of scope

          • Pull-request creation, update, merge, close, review submission, commenting, rerunning checks, or any other mutation.
          • Giving an Agent network access, credentials, native tools, a Workspace path, or a direct provider handle.
          • Adding authentication, pagination, mutating methods, or provider selection to <Fetch>.
          • A generic Git-host query language, raw REST/GraphQL component, caller-selected endpoint, or public credential reference.
          • Non-GitHub adapters in the first delivery.
          • Generated-XMD admission of these components.
          • Workflow scheduling or unattended review polling.

          Activity

          Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

          Metadata

          Metadata

          Assignees

          No one assigned

            Labels

            No labels
            No labels

            Projects

            No projects

              Milestone

              No milestone

              Relationships

              None yet

              Development

              No branches or pull requests

              Issue actions

              , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length \u003e 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
              Skip to content

              Read complete pull-request review evidence from a workflow #576

              Description

              @taras

              Story

              As a workflow author, I want authenticated, complete pull-request review evidence to be readable through host-owned components, so a network-denied reviewing Agent and the supervising user receive the existing objections and check results before they decide what happens next.

              Motivation

              The supervised composition in #301 must give both the reviewing Planner and the user every existing review body, pull-request comment, and check result. <PullRequest> deliberately returns only stable evidence about the upsert it reconciled; later reviews, comments, and checks are separate reads.

              <Fetch> is not this boundary. It is credential-free, performs one GET or HEAD per invocation, and has no pagination contract. Raw authored credential headers are retained document data rather than host authentication, cannot reliably reach a private repository, and would bypass the adapter-private destination and credential ceiling.

              Authoring contract

              The workflow host registers three self-closing components beside <PullRequest>:

              <PullRequest.Reviews number={pullRequest.number} as="reviews" />
              <PullRequest.Comments number={pullRequest.number} as="comments" />
              <PullRequest.Checks number={pullRequest.number} as="checks" />
              • Each component has one required positive-integer prop, number, requires ordinary as, accepts no content, and returns one JSON array.
              • The enclosing retained Repository and selected checkout identify the Git repository. There is no repository, URL, host, provider, endpoint, token, credential, page, cursor, or limit prop.
              • Reviews, comments, and checks are separate reads and separate durable effects. One may replay or fail independently of the others; no partial three-list result exists.
              • The values are closed, provider-neutral normalized records. Their implementation plan freezes the exact item schemas before coding. Original review and comment bodies and check conclusions/messages needed by the reader remain byte-for-byte unchanged; raw provider responses and live handles never cross the component boundary.
              • PullRequest.Comments accounts for both pull-request conversation comments and inline review comments. It tags their normalized records so the two kinds cannot be confused.
              • PullRequest.Checks accounts for every check/status result the GitHub pull-request UI associates with the exact head commit read for the numbered pull request. A moved head produces evidence for the newly observed head and retains that head SHA with the result; it is never silently combined with an earlier snapshot.
              • Arrays retain the adapter's deterministic page/item order. An empty array means the authenticated provider completed the collection and found none.

              The components render nothing. The caller iterates their arrays with <Each> into the Planner prompt and the user's checkpoint material; it does not stringify or summarize the original evidence.

              Authority and authentication

              The first adapter is GitHub for repositories on github.com.

              • It reuses the host credential broker shipped by 🔐 Reach a private repository as whoever is running the host #532: GH_TOKEN, then GITHUB_TOKEN, then the machine's gh auth token, acquired lazily for the exact retained locator and disposed with that invocation.
              • The adapter-private ceiling decides which retained repository the credential may reach. Public middleware, props, bindings, a same-name repository component, generated source, and another loaded package copy may narrow or refuse but cannot recover the credential or widen the destination.
              • The pull-request number is checked against the request and retained Repository. A response naming another repository, pull request, or head is a provider protocol failure rather than data.
              • A completed replay opens no authentication session and performs no network request.

              Pagination and completeness

              Reuse the GitHub adapter's existing pagination boundary: PAGE_SIZE = 100 and PAGE_LIMIT = 32.

              • Follow GitHub's authenticated pagination until the collection is complete.
              • A next relation is followed only on the adapter's authorized API origin.
              • A malformed, off-origin, cyclic, unreadable, or still-present next relation at the page limit makes the read unavailable.
              • Transport failure, rate limiting, authentication failure, an ambiguous 404, malformed JSON, an unreadable item, or an incomplete page walk is unavailable. None becomes an empty or truncated array.
              • The component publishes its result only after the complete collection and every normalized item have been validated.

              Retention, replay, and failure

              Each invocation is one non-mutating durable read whose identity includes the retained Repository identity, pull-request number, and collection kind. A checks result additionally retains the pull-request head SHA it observed, so the evidence says which revision it describes.

              The normalized request and complete result cross the existing secret gate before persistence. No credential, endpoint, raw response, provider identity, host path, or pagination transport state is retained.

              Completed replay restores the exact array without authentication or another request. Interruption before the durable result commits may repeat the authenticated GETs; no incomplete list is retained. An unavailable or protocol-invalid read fails the stage with a fixed diagnostic and binds nothing. It never lets the reviewing workflow continue as though there were no existing objections.

              Acceptance and focused evidence

              • A private github.com repository is read through the 🔐 Reach a private repository as whoever is running the host #532 credential broker without exposing or retaining the credential.
              • Each component validates its closed self-closing shape before contacting the provider and binds its closed normalized array only through as.
              • Reviews preserve every review body; comments preserve every conversation and inline-review body with an explicit kind; checks preserve every result associated with the exact observed head.
              • Multi-page fixtures beyond one page return every item exactly once in deterministic order.
              • Empty completed collections bind []; unavailable, malformed, off-origin, cyclic, over-limit, rate-limited, unauthorized, and ambiguous-404 walks fail and bind nothing.
              • A payload for another repository, pull request, or head is refused as a protocol failure rather than published.
              • Reviews, comments, and checks are three distinct durable effects. Completing one does not manufacture either of the others.
              • Completed replay performs zero HTTP and credential-broker calls and returns byte-identical normalized evidence.
              • Interruption before commit retains no partial array; continuation performs the unfinished read and commits one complete result.
              • The complete bodies and check evidence reach both the Compose the supervised adversarial implementation workflow #301 Planner prompt and checkpoint material unchanged; replay performs no second read.
              • Ordinary xmd run remains unchanged. The components are installed only by a live or partial workflow host; a completed workflow replay installs no provider.
              • Architecture, executable-MDX, workflow-Workspace, and component inventory prose describe the authenticated read, completeness rule, retention, replay, and failure boundary in present tense.

              Focused provider evidence belongs with the existing GitHub adapter suite in packages/workflow/tests/pull-request-github.test.ts; component and durable replay evidence belongs in a new focused pull-request-read suite. The Planner freezes the exact normalized item schemas and named test cases before the Implementor handoff.

              Dependencies

              Out of scope

              • Pull-request creation, update, merge, close, review submission, commenting, rerunning checks, or any other mutation.
              • Giving an Agent network access, credentials, native tools, a Workspace path, or a direct provider handle.
              • Adding authentication, pagination, mutating methods, or provider selection to <Fetch>.
              • A generic Git-host query language, raw REST/GraphQL component, caller-selected endpoint, or public credential reference.
              • Non-GitHub adapters in the first delivery.
              • Generated-XMD admission of these components.
              • Workflow scheduling or unattended review polling.

              Activity

              Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

              Metadata

              Metadata

              Assignees

              No one assigned

                Labels

                No labels
                No labels

                Projects

                No projects

                  Milestone

                  No milestone

                  Relationships

                  None yet

                  Development

                  No branches or pull requests

                  Issue actions

                  , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
                  Skip to content

                  Read complete pull-request review evidence from a workflow #576

                  Description

                  @taras

                  Story

                  As a workflow author, I want authenticated, complete pull-request review evidence to be readable through host-owned components, so a network-denied reviewing Agent and the supervising user receive the existing objections and check results before they decide what happens next.

                  Motivation

                  The supervised composition in #301 must give both the reviewing Planner and the user every existing review body, pull-request comment, and check result. <PullRequest> deliberately returns only stable evidence about the upsert it reconciled; later reviews, comments, and checks are separate reads.

                  <Fetch> is not this boundary. It is credential-free, performs one GET or HEAD per invocation, and has no pagination contract. Raw authored credential headers are retained document data rather than host authentication, cannot reliably reach a private repository, and would bypass the adapter-private destination and credential ceiling.

                  Authoring contract

                  The workflow host registers three self-closing components beside <PullRequest>:

                  <PullRequest.Reviews number={pullRequest.number} as="reviews" />
                  <PullRequest.Comments number={pullRequest.number} as="comments" />
                  <PullRequest.Checks number={pullRequest.number} as="checks" />
                  • Each component has one required positive-integer prop, number, requires ordinary as, accepts no content, and returns one JSON array.
                  • The enclosing retained Repository and selected checkout identify the Git repository. There is no repository, URL, host, provider, endpoint, token, credential, page, cursor, or limit prop.
                  • Reviews, comments, and checks are separate reads and separate durable effects. One may replay or fail independently of the others; no partial three-list result exists.
                  • The values are closed, provider-neutral normalized records. Their implementation plan freezes the exact item schemas before coding. Original review and comment bodies and check conclusions/messages needed by the reader remain byte-for-byte unchanged; raw provider responses and live handles never cross the component boundary.
                  • PullRequest.Comments accounts for both pull-request conversation comments and inline review comments. It tags their normalized records so the two kinds cannot be confused.
                  • PullRequest.Checks accounts for every check/status result the GitHub pull-request UI associates with the exact head commit read for the numbered pull request. A moved head produces evidence for the newly observed head and retains that head SHA with the result; it is never silently combined with an earlier snapshot.
                  • Arrays retain the adapter's deterministic page/item order. An empty array means the authenticated provider completed the collection and found none.

                  The components render nothing. The caller iterates their arrays with <Each> into the Planner prompt and the user's checkpoint material; it does not stringify or summarize the original evidence.

                  Authority and authentication

                  The first adapter is GitHub for repositories on github.com.

                  • It reuses the host credential broker shipped by 🔐 Reach a private repository as whoever is running the host #532: GH_TOKEN, then GITHUB_TOKEN, then the machine's gh auth token, acquired lazily for the exact retained locator and disposed with that invocation.
                  • The adapter-private ceiling decides which retained repository the credential may reach. Public middleware, props, bindings, a same-name repository component, generated source, and another loaded package copy may narrow or refuse but cannot recover the credential or widen the destination.
                  • The pull-request number is checked against the request and retained Repository. A response naming another repository, pull request, or head is a provider protocol failure rather than data.
                  • A completed replay opens no authentication session and performs no network request.

                  Pagination and completeness

                  Reuse the GitHub adapter's existing pagination boundary: PAGE_SIZE = 100 and PAGE_LIMIT = 32.

                  • Follow GitHub's authenticated pagination until the collection is complete.
                  • A next relation is followed only on the adapter's authorized API origin.
                  • A malformed, off-origin, cyclic, unreadable, or still-present next relation at the page limit makes the read unavailable.
                  • Transport failure, rate limiting, authentication failure, an ambiguous 404, malformed JSON, an unreadable item, or an incomplete page walk is unavailable. None becomes an empty or truncated array.
                  • The component publishes its result only after the complete collection and every normalized item have been validated.

                  Retention, replay, and failure

                  Each invocation is one non-mutating durable read whose identity includes the retained Repository identity, pull-request number, and collection kind. A checks result additionally retains the pull-request head SHA it observed, so the evidence says which revision it describes.

                  The normalized request and complete result cross the existing secret gate before persistence. No credential, endpoint, raw response, provider identity, host path, or pagination transport state is retained.

                  Completed replay restores the exact array without authentication or another request. Interruption before the durable result commits may repeat the authenticated GETs; no incomplete list is retained. An unavailable or protocol-invalid read fails the stage with a fixed diagnostic and binds nothing. It never lets the reviewing workflow continue as though there were no existing objections.

                  Acceptance and focused evidence

                  • A private github.com repository is read through the 🔐 Reach a private repository as whoever is running the host #532 credential broker without exposing or retaining the credential.
                  • Each component validates its closed self-closing shape before contacting the provider and binds its closed normalized array only through as.
                  • Reviews preserve every review body; comments preserve every conversation and inline-review body with an explicit kind; checks preserve every result associated with the exact observed head.
                  • Multi-page fixtures beyond one page return every item exactly once in deterministic order.
                  • Empty completed collections bind []; unavailable, malformed, off-origin, cyclic, over-limit, rate-limited, unauthorized, and ambiguous-404 walks fail and bind nothing.
                  • A payload for another repository, pull request, or head is refused as a protocol failure rather than published.
                  • Reviews, comments, and checks are three distinct durable effects. Completing one does not manufacture either of the others.
                  • Completed replay performs zero HTTP and credential-broker calls and returns byte-identical normalized evidence.
                  • Interruption before commit retains no partial array; continuation performs the unfinished read and commits one complete result.
                  • The complete bodies and check evidence reach both the Compose the supervised adversarial implementation workflow #301 Planner prompt and checkpoint material unchanged; replay performs no second read.
                  • Ordinary xmd run remains unchanged. The components are installed only by a live or partial workflow host; a completed workflow replay installs no provider.
                  • Architecture, executable-MDX, workflow-Workspace, and component inventory prose describe the authenticated read, completeness rule, retention, replay, and failure boundary in present tense.

                  Focused provider evidence belongs with the existing GitHub adapter suite in packages/workflow/tests/pull-request-github.test.ts; component and durable replay evidence belongs in a new focused pull-request-read suite. The Planner freezes the exact normalized item schemas and named test cases before the Implementor handoff.

                  Dependencies

                  Out of scope

                  • Pull-request creation, update, merge, close, review submission, commenting, rerunning checks, or any other mutation.
                  • Giving an Agent network access, credentials, native tools, a Workspace path, or a direct provider handle.
                  • Adding authentication, pagination, mutating methods, or provider selection to <Fetch>.
                  • A generic Git-host query language, raw REST/GraphQL component, caller-selected endpoint, or public credential reference.
                  • Non-GitHub adapters in the first delivery.
                  • Generated-XMD admission of these components.
                  • Workflow scheduling or unattended review polling.

                  Activity

                  Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

                  Metadata

                  Metadata

                  Assignees

                  No one assigned

                    Labels

                    No labels
                    No labels

                    Projects

                    No projects

                      Milestone

                      No milestone

                      Relationships

                      None yet

                      Development

                      No branches or pull requests

                      Issue actions

                      , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
                      Skip to content

                      Read complete pull-request review evidence from a workflow #576

                      Description

                      @taras

                      Story

                      As a workflow author, I want authenticated, complete pull-request review evidence to be readable through host-owned components, so a network-denied reviewing Agent and the supervising user receive the existing objections and check results before they decide what happens next.

                      Motivation

                      The supervised composition in #301 must give both the reviewing Planner and the user every existing review body, pull-request comment, and check result. <PullRequest> deliberately returns only stable evidence about the upsert it reconciled; later reviews, comments, and checks are separate reads.

                      <Fetch> is not this boundary. It is credential-free, performs one GET or HEAD per invocation, and has no pagination contract. Raw authored credential headers are retained document data rather than host authentication, cannot reliably reach a private repository, and would bypass the adapter-private destination and credential ceiling.

                      Authoring contract

                      The workflow host registers three self-closing components beside <PullRequest>:

                      <PullRequest.Reviews number={pullRequest.number} as="reviews" />
                      <PullRequest.Comments number={pullRequest.number} as="comments" />
                      <PullRequest.Checks number={pullRequest.number} as="checks" />
                      • Each component has one required positive-integer prop, number, requires ordinary as, accepts no content, and returns one JSON array.
                      • The enclosing retained Repository and selected checkout identify the Git repository. There is no repository, URL, host, provider, endpoint, token, credential, page, cursor, or limit prop.
                      • Reviews, comments, and checks are separate reads and separate durable effects. One may replay or fail independently of the others; no partial three-list result exists.
                      • The values are closed, provider-neutral normalized records. Their implementation plan freezes the exact item schemas before coding. Original review and comment bodies and check conclusions/messages needed by the reader remain byte-for-byte unchanged; raw provider responses and live handles never cross the component boundary.
                      • PullRequest.Comments accounts for both pull-request conversation comments and inline review comments. It tags their normalized records so the two kinds cannot be confused.
                      • PullRequest.Checks accounts for every check/status result the GitHub pull-request UI associates with the exact head commit read for the numbered pull request. A moved head produces evidence for the newly observed head and retains that head SHA with the result; it is never silently combined with an earlier snapshot.
                      • Arrays retain the adapter's deterministic page/item order. An empty array means the authenticated provider completed the collection and found none.

                      The components render nothing. The caller iterates their arrays with <Each> into the Planner prompt and the user's checkpoint material; it does not stringify or summarize the original evidence.

                      Authority and authentication

                      The first adapter is GitHub for repositories on github.com.

                      • It reuses the host credential broker shipped by 🔐 Reach a private repository as whoever is running the host #532: GH_TOKEN, then GITHUB_TOKEN, then the machine's gh auth token, acquired lazily for the exact retained locator and disposed with that invocation.
                      • The adapter-private ceiling decides which retained repository the credential may reach. Public middleware, props, bindings, a same-name repository component, generated source, and another loaded package copy may narrow or refuse but cannot recover the credential or widen the destination.
                      • The pull-request number is checked against the request and retained Repository. A response naming another repository, pull request, or head is a provider protocol failure rather than data.
                      • A completed replay opens no authentication session and performs no network request.

                      Pagination and completeness

                      Reuse the GitHub adapter's existing pagination boundary: PAGE_SIZE = 100 and PAGE_LIMIT = 32.

                      • Follow GitHub's authenticated pagination until the collection is complete.
                      • A next relation is followed only on the adapter's authorized API origin.
                      • A malformed, off-origin, cyclic, unreadable, or still-present next relation at the page limit makes the read unavailable.
                      • Transport failure, rate limiting, authentication failure, an ambiguous 404, malformed JSON, an unreadable item, or an incomplete page walk is unavailable. None becomes an empty or truncated array.
                      • The component publishes its result only after the complete collection and every normalized item have been validated.

                      Retention, replay, and failure

                      Each invocation is one non-mutating durable read whose identity includes the retained Repository identity, pull-request number, and collection kind. A checks result additionally retains the pull-request head SHA it observed, so the evidence says which revision it describes.

                      The normalized request and complete result cross the existing secret gate before persistence. No credential, endpoint, raw response, provider identity, host path, or pagination transport state is retained.

                      Completed replay restores the exact array without authentication or another request. Interruption before the durable result commits may repeat the authenticated GETs; no incomplete list is retained. An unavailable or protocol-invalid read fails the stage with a fixed diagnostic and binds nothing. It never lets the reviewing workflow continue as though there were no existing objections.

                      Acceptance and focused evidence

                      • A private github.com repository is read through the 🔐 Reach a private repository as whoever is running the host #532 credential broker without exposing or retaining the credential.
                      • Each component validates its closed self-closing shape before contacting the provider and binds its closed normalized array only through as.
                      • Reviews preserve every review body; comments preserve every conversation and inline-review body with an explicit kind; checks preserve every result associated with the exact observed head.
                      • Multi-page fixtures beyond one page return every item exactly once in deterministic order.
                      • Empty completed collections bind []; unavailable, malformed, off-origin, cyclic, over-limit, rate-limited, unauthorized, and ambiguous-404 walks fail and bind nothing.
                      • A payload for another repository, pull request, or head is refused as a protocol failure rather than published.
                      • Reviews, comments, and checks are three distinct durable effects. Completing one does not manufacture either of the others.
                      • Completed replay performs zero HTTP and credential-broker calls and returns byte-identical normalized evidence.
                      • Interruption before commit retains no partial array; continuation performs the unfinished read and commits one complete result.
                      • The complete bodies and check evidence reach both the Compose the supervised adversarial implementation workflow #301 Planner prompt and checkpoint material unchanged; replay performs no second read.
                      • Ordinary xmd run remains unchanged. The components are installed only by a live or partial workflow host; a completed workflow replay installs no provider.
                      • Architecture, executable-MDX, workflow-Workspace, and component inventory prose describe the authenticated read, completeness rule, retention, replay, and failure boundary in present tense.

                      Focused provider evidence belongs with the existing GitHub adapter suite in packages/workflow/tests/pull-request-github.test.ts; component and durable replay evidence belongs in a new focused pull-request-read suite. The Planner freezes the exact normalized item schemas and named test cases before the Implementor handoff.

                      Dependencies

                      Out of scope

                      • Pull-request creation, update, merge, close, review submission, commenting, rerunning checks, or any other mutation.
                      • Giving an Agent network access, credentials, native tools, a Workspace path, or a direct provider handle.
                      • Adding authentication, pagination, mutating methods, or provider selection to <Fetch>.
                      • A generic Git-host query language, raw REST/GraphQL component, caller-selected endpoint, or public credential reference.
                      • Non-GitHub adapters in the first delivery.
                      • Generated-XMD admission of these components.
                      • Workflow scheduling or unattended review polling.

                      Activity

                      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

                      Metadata

                      Metadata

                      Assignees

                      No one assigned

                        Labels

                        No labels
                        No labels

                        Projects

                        No projects

                          Milestone

                          No milestone

                          Relationships

                          None yet

                          Development

                          No branches or pull requests

                          Issue actions

                          , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
                          Skip to content

                          Read complete pull-request review evidence from a workflow #576

                          Description

                          @taras

                          Story

                          As a workflow author, I want authenticated, complete pull-request review evidence to be readable through host-owned components, so a network-denied reviewing Agent and the supervising user receive the existing objections and check results before they decide what happens next.

                          Motivation

                          The supervised composition in #301 must give both the reviewing Planner and the user every existing review body, pull-request comment, and check result. <PullRequest> deliberately returns only stable evidence about the upsert it reconciled; later reviews, comments, and checks are separate reads.

                          <Fetch> is not this boundary. It is credential-free, performs one GET or HEAD per invocation, and has no pagination contract. Raw authored credential headers are retained document data rather than host authentication, cannot reliably reach a private repository, and would bypass the adapter-private destination and credential ceiling.

                          Authoring contract

                          The workflow host registers three self-closing components beside <PullRequest>:

                          <PullRequest.Reviews number={pullRequest.number} as="reviews" />
                          <PullRequest.Comments number={pullRequest.number} as="comments" />
                          <PullRequest.Checks number={pullRequest.number} as="checks" />
                          • Each component has one required positive-integer prop, number, requires ordinary as, accepts no content, and returns one JSON array.
                          • The enclosing retained Repository and selected checkout identify the Git repository. There is no repository, URL, host, provider, endpoint, token, credential, page, cursor, or limit prop.
                          • Reviews, comments, and checks are separate reads and separate durable effects. One may replay or fail independently of the others; no partial three-list result exists.
                          • The values are closed, provider-neutral normalized records. Their implementation plan freezes the exact item schemas before coding. Original review and comment bodies and check conclusions/messages needed by the reader remain byte-for-byte unchanged; raw provider responses and live handles never cross the component boundary.
                          • PullRequest.Comments accounts for both pull-request conversation comments and inline review comments. It tags their normalized records so the two kinds cannot be confused.
                          • PullRequest.Checks accounts for every check/status result the GitHub pull-request UI associates with the exact head commit read for the numbered pull request. A moved head produces evidence for the newly observed head and retains that head SHA with the result; it is never silently combined with an earlier snapshot.
                          • Arrays retain the adapter's deterministic page/item order. An empty array means the authenticated provider completed the collection and found none.

                          The components render nothing. The caller iterates their arrays with <Each> into the Planner prompt and the user's checkpoint material; it does not stringify or summarize the original evidence.

                          Authority and authentication

                          The first adapter is GitHub for repositories on github.com.

                          • It reuses the host credential broker shipped by 🔐 Reach a private repository as whoever is running the host #532: GH_TOKEN, then GITHUB_TOKEN, then the machine's gh auth token, acquired lazily for the exact retained locator and disposed with that invocation.
                          • The adapter-private ceiling decides which retained repository the credential may reach. Public middleware, props, bindings, a same-name repository component, generated source, and another loaded package copy may narrow or refuse but cannot recover the credential or widen the destination.
                          • The pull-request number is checked against the request and retained Repository. A response naming another repository, pull request, or head is a provider protocol failure rather than data.
                          • A completed replay opens no authentication session and performs no network request.

                          Pagination and completeness

                          Reuse the GitHub adapter's existing pagination boundary: PAGE_SIZE = 100 and PAGE_LIMIT = 32.

                          • Follow GitHub's authenticated pagination until the collection is complete.
                          • A next relation is followed only on the adapter's authorized API origin.
                          • A malformed, off-origin, cyclic, unreadable, or still-present next relation at the page limit makes the read unavailable.
                          • Transport failure, rate limiting, authentication failure, an ambiguous 404, malformed JSON, an unreadable item, or an incomplete page walk is unavailable. None becomes an empty or truncated array.
                          • The component publishes its result only after the complete collection and every normalized item have been validated.

                          Retention, replay, and failure

                          Each invocation is one non-mutating durable read whose identity includes the retained Repository identity, pull-request number, and collection kind. A checks result additionally retains the pull-request head SHA it observed, so the evidence says which revision it describes.

                          The normalized request and complete result cross the existing secret gate before persistence. No credential, endpoint, raw response, provider identity, host path, or pagination transport state is retained.

                          Completed replay restores the exact array without authentication or another request. Interruption before the durable result commits may repeat the authenticated GETs; no incomplete list is retained. An unavailable or protocol-invalid read fails the stage with a fixed diagnostic and binds nothing. It never lets the reviewing workflow continue as though there were no existing objections.

                          Acceptance and focused evidence

                          • A private github.com repository is read through the 🔐 Reach a private repository as whoever is running the host #532 credential broker without exposing or retaining the credential.
                          • Each component validates its closed self-closing shape before contacting the provider and binds its closed normalized array only through as.
                          • Reviews preserve every review body; comments preserve every conversation and inline-review body with an explicit kind; checks preserve every result associated with the exact observed head.
                          • Multi-page fixtures beyond one page return every item exactly once in deterministic order.
                          • Empty completed collections bind []; unavailable, malformed, off-origin, cyclic, over-limit, rate-limited, unauthorized, and ambiguous-404 walks fail and bind nothing.
                          • A payload for another repository, pull request, or head is refused as a protocol failure rather than published.
                          • Reviews, comments, and checks are three distinct durable effects. Completing one does not manufacture either of the others.
                          • Completed replay performs zero HTTP and credential-broker calls and returns byte-identical normalized evidence.
                          • Interruption before commit retains no partial array; continuation performs the unfinished read and commits one complete result.
                          • The complete bodies and check evidence reach both the Compose the supervised adversarial implementation workflow #301 Planner prompt and checkpoint material unchanged; replay performs no second read.
                          • Ordinary xmd run remains unchanged. The components are installed only by a live or partial workflow host; a completed workflow replay installs no provider.
                          • Architecture, executable-MDX, workflow-Workspace, and component inventory prose describe the authenticated read, completeness rule, retention, replay, and failure boundary in present tense.

                          Focused provider evidence belongs with the existing GitHub adapter suite in packages/workflow/tests/pull-request-github.test.ts; component and durable replay evidence belongs in a new focused pull-request-read suite. The Planner freezes the exact normalized item schemas and named test cases before the Implementor handoff.

                          Dependencies

                          Out of scope

                          • Pull-request creation, update, merge, close, review submission, commenting, rerunning checks, or any other mutation.
                          • Giving an Agent network access, credentials, native tools, a Workspace path, or a direct provider handle.
                          • Adding authentication, pagination, mutating methods, or provider selection to <Fetch>.
                          • A generic Git-host query language, raw REST/GraphQL component, caller-selected endpoint, or public credential reference.
                          • Non-GitHub adapters in the first delivery.
                          • Generated-XMD admission of these components.
                          • Workflow scheduling or unattended review polling.

                          Activity

                          Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

                          Metadata

                          Metadata

                          Assignees

                          No one assigned

                            Labels

                            No labels
                            No labels

                            Projects

                            No projects

                              Milestone

                              No milestone

                              Relationships

                              None yet

                              Development

                              No branches or pull requests

                              Issue actions

                              , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
                              Skip to content

                              Read complete pull-request review evidence from a workflow #576

                              Description

                              @taras

                              Story

                              As a workflow author, I want authenticated, complete pull-request review evidence to be readable through host-owned components, so a network-denied reviewing Agent and the supervising user receive the existing objections and check results before they decide what happens next.

                              Motivation

                              The supervised composition in #301 must give both the reviewing Planner and the user every existing review body, pull-request comment, and check result. <PullRequest> deliberately returns only stable evidence about the upsert it reconciled; later reviews, comments, and checks are separate reads.

                              <Fetch> is not this boundary. It is credential-free, performs one GET or HEAD per invocation, and has no pagination contract. Raw authored credential headers are retained document data rather than host authentication, cannot reliably reach a private repository, and would bypass the adapter-private destination and credential ceiling.

                              Authoring contract

                              The workflow host registers three self-closing components beside <PullRequest>:

                              <PullRequest.Reviews number={pullRequest.number} as="reviews" />
                              <PullRequest.Comments number={pullRequest.number} as="comments" />
                              <PullRequest.Checks number={pullRequest.number} as="checks" />
                              • Each component has one required positive-integer prop, number, requires ordinary as, accepts no content, and returns one JSON array.
                              • The enclosing retained Repository and selected checkout identify the Git repository. There is no repository, URL, host, provider, endpoint, token, credential, page, cursor, or limit prop.
                              • Reviews, comments, and checks are separate reads and separate durable effects. One may replay or fail independently of the others; no partial three-list result exists.
                              • The values are closed, provider-neutral normalized records. Their implementation plan freezes the exact item schemas before coding. Original review and comment bodies and check conclusions/messages needed by the reader remain byte-for-byte unchanged; raw provider responses and live handles never cross the component boundary.
                              • PullRequest.Comments accounts for both pull-request conversation comments and inline review comments. It tags their normalized records so the two kinds cannot be confused.
                              • PullRequest.Checks accounts for every check/status result the GitHub pull-request UI associates with the exact head commit read for the numbered pull request. A moved head produces evidence for the newly observed head and retains that head SHA with the result; it is never silently combined with an earlier snapshot.
                              • Arrays retain the adapter's deterministic page/item order. An empty array means the authenticated provider completed the collection and found none.

                              The components render nothing. The caller iterates their arrays with <Each> into the Planner prompt and the user's checkpoint material; it does not stringify or summarize the original evidence.

                              Authority and authentication

                              The first adapter is GitHub for repositories on github.com.

                              • It reuses the host credential broker shipped by 🔐 Reach a private repository as whoever is running the host #532: GH_TOKEN, then GITHUB_TOKEN, then the machine's gh auth token, acquired lazily for the exact retained locator and disposed with that invocation.
                              • The adapter-private ceiling decides which retained repository the credential may reach. Public middleware, props, bindings, a same-name repository component, generated source, and another loaded package copy may narrow or refuse but cannot recover the credential or widen the destination.
                              • The pull-request number is checked against the request and retained Repository. A response naming another repository, pull request, or head is a provider protocol failure rather than data.
                              • A completed replay opens no authentication session and performs no network request.

                              Pagination and completeness

                              Reuse the GitHub adapter's existing pagination boundary: PAGE_SIZE = 100 and PAGE_LIMIT = 32.

                              • Follow GitHub's authenticated pagination until the collection is complete.
                              • A next relation is followed only on the adapter's authorized API origin.
                              • A malformed, off-origin, cyclic, unreadable, or still-present next relation at the page limit makes the read unavailable.
                              • Transport failure, rate limiting, authentication failure, an ambiguous 404, malformed JSON, an unreadable item, or an incomplete page walk is unavailable. None becomes an empty or truncated array.
                              • The component publishes its result only after the complete collection and every normalized item have been validated.

                              Retention, replay, and failure

                              Each invocation is one non-mutating durable read whose identity includes the retained Repository identity, pull-request number, and collection kind. A checks result additionally retains the pull-request head SHA it observed, so the evidence says which revision it describes.

                              The normalized request and complete result cross the existing secret gate before persistence. No credential, endpoint, raw response, provider identity, host path, or pagination transport state is retained.

                              Completed replay restores the exact array without authentication or another request. Interruption before the durable result commits may repeat the authenticated GETs; no incomplete list is retained. An unavailable or protocol-invalid read fails the stage with a fixed diagnostic and binds nothing. It never lets the reviewing workflow continue as though there were no existing objections.

                              Acceptance and focused evidence

                              • A private github.com repository is read through the 🔐 Reach a private repository as whoever is running the host #532 credential broker without exposing or retaining the credential.
                              • Each component validates its closed self-closing shape before contacting the provider and binds its closed normalized array only through as.
                              • Reviews preserve every review body; comments preserve every conversation and inline-review body with an explicit kind; checks preserve every result associated with the exact observed head.
                              • Multi-page fixtures beyond one page return every item exactly once in deterministic order.
                              • Empty completed collections bind []; unavailable, malformed, off-origin, cyclic, over-limit, rate-limited, unauthorized, and ambiguous-404 walks fail and bind nothing.
                              • A payload for another repository, pull request, or head is refused as a protocol failure rather than published.
                              • Reviews, comments, and checks are three distinct durable effects. Completing one does not manufacture either of the others.
                              • Completed replay performs zero HTTP and credential-broker calls and returns byte-identical normalized evidence.
                              • Interruption before commit retains no partial array; continuation performs the unfinished read and commits one complete result.
                              • The complete bodies and check evidence reach both the Compose the supervised adversarial implementation workflow #301 Planner prompt and checkpoint material unchanged; replay performs no second read.
                              • Ordinary xmd run remains unchanged. The components are installed only by a live or partial workflow host; a completed workflow replay installs no provider.
                              • Architecture, executable-MDX, workflow-Workspace, and component inventory prose describe the authenticated read, completeness rule, retention, replay, and failure boundary in present tense.

                              Focused provider evidence belongs with the existing GitHub adapter suite in packages/workflow/tests/pull-request-github.test.ts; component and durable replay evidence belongs in a new focused pull-request-read suite. The Planner freezes the exact normalized item schemas and named test cases before the Implementor handoff.

                              Dependencies

                              Out of scope

                              • Pull-request creation, update, merge, close, review submission, commenting, rerunning checks, or any other mutation.
                              • Giving an Agent network access, credentials, native tools, a Workspace path, or a direct provider handle.
                              • Adding authentication, pagination, mutating methods, or provider selection to <Fetch>.
                              • A generic Git-host query language, raw REST/GraphQL component, caller-selected endpoint, or public credential reference.
                              • Non-GitHub adapters in the first delivery.
                              • Generated-XMD admission of these components.
                              • Workflow scheduling or unattended review polling.

                              Activity

                              Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

                              Metadata

                              Metadata

                              Assignees

                              No one assigned

                                Labels

                                No labels
                                No labels

                                Projects

                                No projects

                                  Milestone

                                  No milestone

                                  Relationships

                                  None yet

                                  Development

                                  No branches or pull requests

                                  Issue actions