Resume through durable effects performed inside generated XMD #589

Description

@taras

Story

As a workflow author, I want a retained workflow to resume through durable effects performed inside an admitted generated-XMD fragment, so completed observations and mutations are restored exactly once and later authored effects continue in order.

Context and ownership

This is a regression against #369's settled continuation contract, not a new admission policy, product decision, or durable-stream schema.

The defect was confirmed while implementing #301 slice 2 on draft PR #181:

  • exact reproducer head: 9ef6edcf205f57ba08cc84ba7a009919ed403957;
  • base/current main when frozen: f230e8fd59df293fb9b1677ef4a7466900be4a99;
  • a generated fragment with a durable effect runs on start;
  • a later suspension is retained;
  • resume diverges before the nested generated effect is re-offered;
  • removing <Evaluate>, or keeping a generated fragment with no durable effect, allows resume to complete.

Leave #369 closed as the historical delivery and link it to this correction.

PR #181 remains paused. This issue and its implementation PR own the production correction; #181 will later rebase and convert AC4 from a blocker assertion into a successful continuation regression with zero repeated evidence-provider reads.

Settled ownership and replay contract

Generated admission and every nested generated effect belong to the same owning durable document expansion. They must be offered in authored order:

generated_xmd
nested generated effect 1
nested generated effect 2
later parent effect
suspension_request

On continuation, the same sequence is offered again. Retained results are consumed without re-executing completed providers or mutations.

The current defect is the non-durable bridge around an operation that can yield durable effects: expand() runs through ephemeral() in packages/core/src/generated-xmd.ts. An ephemeral operation is journal-transparent and reruns on replay, so it cannot own a mixed expansion containing ordinary durable effects.

Use the existing owning document expansion. Do not create a child durable coroutine or another lifecycle owner.

Selected implementation boundary

  • Make evaluateGeneratedXmd() an Operation<GeneratedObservationResult>.
  • Make evaluateGeneratedFragment() and the workflow package's internal admission wrapper Operations.
  • Yield the retained admission directly.
  • Run complete-fragment preflight and the admitted expansion inline.
  • Remove the ephemeral(expand(...)) boundary.
  • Preserve the fragment's existing scoped() ownership for middleware, cancellation, and teardown.
  • Keep policy comparison before the first nested provider or mutation.

This places the fragment's durable effects directly in the expansion operation already owned by the document.

Do not add durableSpawn, a child coroutine, flattened records, skipped history, or mutation reruns. DurablePreparation does not change, and @executablemd/durable-streams gains no schema, protocol, or primitive.

The trusted-host TypeScript surface widens from the narrower Workflow return type to Operation. The authored <Evaluate> API and journal schemas remain unchanged.

Host documentation that says the evaluator is reached from a DurablePreparation must be corrected: the workflow path reaches it through the trusted <Evaluate> component inside the owning document expansion.

Frozen acceptance evidence

  1. A generated fragment containing a durable read resumes past a later suspension and completes.
  2. A generated fragment containing a durable write resumes past a later suspension and completes.
  3. The exact journal order is generated_xmd, every nested effect in authored order, later parent effects, then suspension_request.
  4. Across resume, each completed read provider and mutation is invoked exactly once.
  5. A changed retained admission policy refuses before any nested provider or mutation runs.
  6. Empty fragments and fragments with no durable effects preserve their current behavior.
  7. Existing GX15 and GX16 generated-XMD continuation controls remain green.
  8. Existing GXC9 policy controls remain green.
  9. The Compose the supervised adversarial implementation workflow #301 AC4 reproducer fails before the correction and completes after it, with the exact retained evidence reaching the Planner and checkpoint material and zero repeated evidence-provider reads.

The focused regression must distinguish start from resume and must assert provider/mutation call counts, not only the final result.

Implementation scope

A focused PR targeting current main owns:

  • canonical generated-XMD execution in packages/core/src/generated-xmd.ts;
  • the workflow admission wrapper and its types;
  • generated-XMD read/write continuation regressions;
  • architecture.md generated-XMD ownership wording;
  • workflow specification §8.4 and §9;
  • applicable executable-MDX GX/GXC/WGAC rows;
  • a superseding decision-log clarification that mixed generated expansion offers its durable effects inline rather than hiding them behind a nested non-durable bridge.

Focused feedback evidence

Run the smallest explicit affected set, including the new continuation regression:

deno task test packages/core/tests/generated-xmd.test.ts packages/workflow/tests/generated-observations.test.ts packages/workflow/tests/workflow-suspension-answer.test.ts <new-continuation-regression>
git diff --check

Also run the exact #301 AC4 reproducer or an extracted equivalent against the corrected production path and report the journal order and provider/mutation invocation counts.

Create a feedback commit promptly once this frozen matrix passes. Return its exact SHA, exact base, every command/result, and a criterion-by-criterion evidence map. Implementation feedback does not wait for or inspect CI.

Out of scope

  • Admission-policy, pinned-identity, allowed-effect, or authored <Evaluate> API changes.
  • Durable effect-schema or journal-schema changes.
  • Workspace transaction changes.
  • Suspension, answer-delivery, cancellation, or teardown semantics.
  • A new durable-stream primitive or protocol.
  • A child durable coroutine, flattened history, skipped records, or replaying completed work.
  • Production composition changes in PR ✨ Compose and certify the supervised adversarial implementation workflow #181 before this prerequisite merges.

Dependencies

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + '
      Skip to content

      Resume through durable effects performed inside generated XMD #589

      Description

      @taras

      Story

      As a workflow author, I want a retained workflow to resume through durable effects performed inside an admitted generated-XMD fragment, so completed observations and mutations are restored exactly once and later authored effects continue in order.

      Context and ownership

      This is a regression against #369's settled continuation contract, not a new admission policy, product decision, or durable-stream schema.

      The defect was confirmed while implementing #301 slice 2 on draft PR #181:

      • exact reproducer head: 9ef6edcf205f57ba08cc84ba7a009919ed403957;
      • base/current main when frozen: f230e8fd59df293fb9b1677ef4a7466900be4a99;
      • a generated fragment with a durable effect runs on start;
      • a later suspension is retained;
      • resume diverges before the nested generated effect is re-offered;
      • removing <Evaluate>, or keeping a generated fragment with no durable effect, allows resume to complete.

      Leave #369 closed as the historical delivery and link it to this correction.

      PR #181 remains paused. This issue and its implementation PR own the production correction; #181 will later rebase and convert AC4 from a blocker assertion into a successful continuation regression with zero repeated evidence-provider reads.

      Settled ownership and replay contract

      Generated admission and every nested generated effect belong to the same owning durable document expansion. They must be offered in authored order:

      generated_xmd
      nested generated effect 1
      nested generated effect 2
      later parent effect
      suspension_request
      

      On continuation, the same sequence is offered again. Retained results are consumed without re-executing completed providers or mutations.

      The current defect is the non-durable bridge around an operation that can yield durable effects: expand() runs through ephemeral() in packages/core/src/generated-xmd.ts. An ephemeral operation is journal-transparent and reruns on replay, so it cannot own a mixed expansion containing ordinary durable effects.

      Use the existing owning document expansion. Do not create a child durable coroutine or another lifecycle owner.

      Selected implementation boundary

      • Make evaluateGeneratedXmd() an Operation<GeneratedObservationResult>.
      • Make evaluateGeneratedFragment() and the workflow package's internal admission wrapper Operations.
      • Yield the retained admission directly.
      • Run complete-fragment preflight and the admitted expansion inline.
      • Remove the ephemeral(expand(...)) boundary.
      • Preserve the fragment's existing scoped() ownership for middleware, cancellation, and teardown.
      • Keep policy comparison before the first nested provider or mutation.

      This places the fragment's durable effects directly in the expansion operation already owned by the document.

      Do not add durableSpawn, a child coroutine, flattened records, skipped history, or mutation reruns. DurablePreparation does not change, and @executablemd/durable-streams gains no schema, protocol, or primitive.

      The trusted-host TypeScript surface widens from the narrower Workflow return type to Operation. The authored <Evaluate> API and journal schemas remain unchanged.

      Host documentation that says the evaluator is reached from a DurablePreparation must be corrected: the workflow path reaches it through the trusted <Evaluate> component inside the owning document expansion.

      Frozen acceptance evidence

      1. A generated fragment containing a durable read resumes past a later suspension and completes.
      2. A generated fragment containing a durable write resumes past a later suspension and completes.
      3. The exact journal order is generated_xmd, every nested effect in authored order, later parent effects, then suspension_request.
      4. Across resume, each completed read provider and mutation is invoked exactly once.
      5. A changed retained admission policy refuses before any nested provider or mutation runs.
      6. Empty fragments and fragments with no durable effects preserve their current behavior.
      7. Existing GX15 and GX16 generated-XMD continuation controls remain green.
      8. Existing GXC9 policy controls remain green.
      9. The Compose the supervised adversarial implementation workflow #301 AC4 reproducer fails before the correction and completes after it, with the exact retained evidence reaching the Planner and checkpoint material and zero repeated evidence-provider reads.

      The focused regression must distinguish start from resume and must assert provider/mutation call counts, not only the final result.

      Implementation scope

      A focused PR targeting current main owns:

      • canonical generated-XMD execution in packages/core/src/generated-xmd.ts;
      • the workflow admission wrapper and its types;
      • generated-XMD read/write continuation regressions;
      • architecture.md generated-XMD ownership wording;
      • workflow specification §8.4 and §9;
      • applicable executable-MDX GX/GXC/WGAC rows;
      • a superseding decision-log clarification that mixed generated expansion offers its durable effects inline rather than hiding them behind a nested non-durable bridge.

      Focused feedback evidence

      Run the smallest explicit affected set, including the new continuation regression:

      deno task test packages/core/tests/generated-xmd.test.ts packages/workflow/tests/generated-observations.test.ts packages/workflow/tests/workflow-suspension-answer.test.ts <new-continuation-regression>
      git diff --check

      Also run the exact #301 AC4 reproducer or an extracted equivalent against the corrected production path and report the journal order and provider/mutation invocation counts.

      Create a feedback commit promptly once this frozen matrix passes. Return its exact SHA, exact base, every command/result, and a criterion-by-criterion evidence map. Implementation feedback does not wait for or inspect CI.

      Out of scope

      • Admission-policy, pinned-identity, allowed-effect, or authored <Evaluate> API changes.
      • Durable effect-schema or journal-schema changes.
      • Workspace transaction changes.
      • Suspension, answer-delivery, cancellation, or teardown semantics.
      • A new durable-stream primitive or protocol.
      • A child durable coroutine, flattened history, skipped records, or replaying completed work.
      • Production composition changes in PR ✨ Compose and certify the supervised adversarial implementation workflow #181 before this prerequisite merges.

      Dependencies

      Activity

      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

      Metadata

      Metadata

      Assignees

      No one assigned

        Labels

        No labels
        No labels

        Projects

        No projects

          Milestone

          No milestone

          Relationships

          None yet

          Development

          No branches or pull requests

          Issue actions

          , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
          Skip to content

          Resume through durable effects performed inside generated XMD #589

          Description

          @taras

          Story

          As a workflow author, I want a retained workflow to resume through durable effects performed inside an admitted generated-XMD fragment, so completed observations and mutations are restored exactly once and later authored effects continue in order.

          Context and ownership

          This is a regression against #369's settled continuation contract, not a new admission policy, product decision, or durable-stream schema.

          The defect was confirmed while implementing #301 slice 2 on draft PR #181:

          • exact reproducer head: 9ef6edcf205f57ba08cc84ba7a009919ed403957;
          • base/current main when frozen: f230e8fd59df293fb9b1677ef4a7466900be4a99;
          • a generated fragment with a durable effect runs on start;
          • a later suspension is retained;
          • resume diverges before the nested generated effect is re-offered;
          • removing <Evaluate>, or keeping a generated fragment with no durable effect, allows resume to complete.

          Leave #369 closed as the historical delivery and link it to this correction.

          PR #181 remains paused. This issue and its implementation PR own the production correction; #181 will later rebase and convert AC4 from a blocker assertion into a successful continuation regression with zero repeated evidence-provider reads.

          Settled ownership and replay contract

          Generated admission and every nested generated effect belong to the same owning durable document expansion. They must be offered in authored order:

          generated_xmd
          nested generated effect 1
          nested generated effect 2
          later parent effect
          suspension_request
          

          On continuation, the same sequence is offered again. Retained results are consumed without re-executing completed providers or mutations.

          The current defect is the non-durable bridge around an operation that can yield durable effects: expand() runs through ephemeral() in packages/core/src/generated-xmd.ts. An ephemeral operation is journal-transparent and reruns on replay, so it cannot own a mixed expansion containing ordinary durable effects.

          Use the existing owning document expansion. Do not create a child durable coroutine or another lifecycle owner.

          Selected implementation boundary

          • Make evaluateGeneratedXmd() an Operation<GeneratedObservationResult>.
          • Make evaluateGeneratedFragment() and the workflow package's internal admission wrapper Operations.
          • Yield the retained admission directly.
          • Run complete-fragment preflight and the admitted expansion inline.
          • Remove the ephemeral(expand(...)) boundary.
          • Preserve the fragment's existing scoped() ownership for middleware, cancellation, and teardown.
          • Keep policy comparison before the first nested provider or mutation.

          This places the fragment's durable effects directly in the expansion operation already owned by the document.

          Do not add durableSpawn, a child coroutine, flattened records, skipped history, or mutation reruns. DurablePreparation does not change, and @executablemd/durable-streams gains no schema, protocol, or primitive.

          The trusted-host TypeScript surface widens from the narrower Workflow return type to Operation. The authored <Evaluate> API and journal schemas remain unchanged.

          Host documentation that says the evaluator is reached from a DurablePreparation must be corrected: the workflow path reaches it through the trusted <Evaluate> component inside the owning document expansion.

          Frozen acceptance evidence

          1. A generated fragment containing a durable read resumes past a later suspension and completes.
          2. A generated fragment containing a durable write resumes past a later suspension and completes.
          3. The exact journal order is generated_xmd, every nested effect in authored order, later parent effects, then suspension_request.
          4. Across resume, each completed read provider and mutation is invoked exactly once.
          5. A changed retained admission policy refuses before any nested provider or mutation runs.
          6. Empty fragments and fragments with no durable effects preserve their current behavior.
          7. Existing GX15 and GX16 generated-XMD continuation controls remain green.
          8. Existing GXC9 policy controls remain green.
          9. The Compose the supervised adversarial implementation workflow #301 AC4 reproducer fails before the correction and completes after it, with the exact retained evidence reaching the Planner and checkpoint material and zero repeated evidence-provider reads.

          The focused regression must distinguish start from resume and must assert provider/mutation call counts, not only the final result.

          Implementation scope

          A focused PR targeting current main owns:

          • canonical generated-XMD execution in packages/core/src/generated-xmd.ts;
          • the workflow admission wrapper and its types;
          • generated-XMD read/write continuation regressions;
          • architecture.md generated-XMD ownership wording;
          • workflow specification §8.4 and §9;
          • applicable executable-MDX GX/GXC/WGAC rows;
          • a superseding decision-log clarification that mixed generated expansion offers its durable effects inline rather than hiding them behind a nested non-durable bridge.

          Focused feedback evidence

          Run the smallest explicit affected set, including the new continuation regression:

          deno task test packages/core/tests/generated-xmd.test.ts packages/workflow/tests/generated-observations.test.ts packages/workflow/tests/workflow-suspension-answer.test.ts <new-continuation-regression>
          git diff --check

          Also run the exact #301 AC4 reproducer or an extracted equivalent against the corrected production path and report the journal order and provider/mutation invocation counts.

          Create a feedback commit promptly once this frozen matrix passes. Return its exact SHA, exact base, every command/result, and a criterion-by-criterion evidence map. Implementation feedback does not wait for or inspect CI.

          Out of scope

          • Admission-policy, pinned-identity, allowed-effect, or authored <Evaluate> API changes.
          • Durable effect-schema or journal-schema changes.
          • Workspace transaction changes.
          • Suspension, answer-delivery, cancellation, or teardown semantics.
          • A new durable-stream primitive or protocol.
          • A child durable coroutine, flattened history, skipped records, or replaying completed work.
          • Production composition changes in PR ✨ Compose and certify the supervised adversarial implementation workflow #181 before this prerequisite merges.

          Dependencies

          Activity

          Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

          Metadata

          Metadata

          Assignees

          No one assigned

            Labels

            No labels
            No labels

            Projects

            No projects

              Milestone

              No milestone

              Relationships

              None yet

              Development

              No branches or pull requests

              Issue actions

              , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length \u003e 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
              Skip to content

              Resume through durable effects performed inside generated XMD #589

              Description

              @taras

              Story

              As a workflow author, I want a retained workflow to resume through durable effects performed inside an admitted generated-XMD fragment, so completed observations and mutations are restored exactly once and later authored effects continue in order.

              Context and ownership

              This is a regression against #369's settled continuation contract, not a new admission policy, product decision, or durable-stream schema.

              The defect was confirmed while implementing #301 slice 2 on draft PR #181:

              • exact reproducer head: 9ef6edcf205f57ba08cc84ba7a009919ed403957;
              • base/current main when frozen: f230e8fd59df293fb9b1677ef4a7466900be4a99;
              • a generated fragment with a durable effect runs on start;
              • a later suspension is retained;
              • resume diverges before the nested generated effect is re-offered;
              • removing <Evaluate>, or keeping a generated fragment with no durable effect, allows resume to complete.

              Leave #369 closed as the historical delivery and link it to this correction.

              PR #181 remains paused. This issue and its implementation PR own the production correction; #181 will later rebase and convert AC4 from a blocker assertion into a successful continuation regression with zero repeated evidence-provider reads.

              Settled ownership and replay contract

              Generated admission and every nested generated effect belong to the same owning durable document expansion. They must be offered in authored order:

              generated_xmd
              nested generated effect 1
              nested generated effect 2
              later parent effect
              suspension_request
              

              On continuation, the same sequence is offered again. Retained results are consumed without re-executing completed providers or mutations.

              The current defect is the non-durable bridge around an operation that can yield durable effects: expand() runs through ephemeral() in packages/core/src/generated-xmd.ts. An ephemeral operation is journal-transparent and reruns on replay, so it cannot own a mixed expansion containing ordinary durable effects.

              Use the existing owning document expansion. Do not create a child durable coroutine or another lifecycle owner.

              Selected implementation boundary

              • Make evaluateGeneratedXmd() an Operation<GeneratedObservationResult>.
              • Make evaluateGeneratedFragment() and the workflow package's internal admission wrapper Operations.
              • Yield the retained admission directly.
              • Run complete-fragment preflight and the admitted expansion inline.
              • Remove the ephemeral(expand(...)) boundary.
              • Preserve the fragment's existing scoped() ownership for middleware, cancellation, and teardown.
              • Keep policy comparison before the first nested provider or mutation.

              This places the fragment's durable effects directly in the expansion operation already owned by the document.

              Do not add durableSpawn, a child coroutine, flattened records, skipped history, or mutation reruns. DurablePreparation does not change, and @executablemd/durable-streams gains no schema, protocol, or primitive.

              The trusted-host TypeScript surface widens from the narrower Workflow return type to Operation. The authored <Evaluate> API and journal schemas remain unchanged.

              Host documentation that says the evaluator is reached from a DurablePreparation must be corrected: the workflow path reaches it through the trusted <Evaluate> component inside the owning document expansion.

              Frozen acceptance evidence

              1. A generated fragment containing a durable read resumes past a later suspension and completes.
              2. A generated fragment containing a durable write resumes past a later suspension and completes.
              3. The exact journal order is generated_xmd, every nested effect in authored order, later parent effects, then suspension_request.
              4. Across resume, each completed read provider and mutation is invoked exactly once.
              5. A changed retained admission policy refuses before any nested provider or mutation runs.
              6. Empty fragments and fragments with no durable effects preserve their current behavior.
              7. Existing GX15 and GX16 generated-XMD continuation controls remain green.
              8. Existing GXC9 policy controls remain green.
              9. The Compose the supervised adversarial implementation workflow #301 AC4 reproducer fails before the correction and completes after it, with the exact retained evidence reaching the Planner and checkpoint material and zero repeated evidence-provider reads.

              The focused regression must distinguish start from resume and must assert provider/mutation call counts, not only the final result.

              Implementation scope

              A focused PR targeting current main owns:

              • canonical generated-XMD execution in packages/core/src/generated-xmd.ts;
              • the workflow admission wrapper and its types;
              • generated-XMD read/write continuation regressions;
              • architecture.md generated-XMD ownership wording;
              • workflow specification §8.4 and §9;
              • applicable executable-MDX GX/GXC/WGAC rows;
              • a superseding decision-log clarification that mixed generated expansion offers its durable effects inline rather than hiding them behind a nested non-durable bridge.

              Focused feedback evidence

              Run the smallest explicit affected set, including the new continuation regression:

              deno task test packages/core/tests/generated-xmd.test.ts packages/workflow/tests/generated-observations.test.ts packages/workflow/tests/workflow-suspension-answer.test.ts <new-continuation-regression>
              git diff --check

              Also run the exact #301 AC4 reproducer or an extracted equivalent against the corrected production path and report the journal order and provider/mutation invocation counts.

              Create a feedback commit promptly once this frozen matrix passes. Return its exact SHA, exact base, every command/result, and a criterion-by-criterion evidence map. Implementation feedback does not wait for or inspect CI.

              Out of scope

              • Admission-policy, pinned-identity, allowed-effect, or authored <Evaluate> API changes.
              • Durable effect-schema or journal-schema changes.
              • Workspace transaction changes.
              • Suspension, answer-delivery, cancellation, or teardown semantics.
              • A new durable-stream primitive or protocol.
              • A child durable coroutine, flattened history, skipped records, or replaying completed work.
              • Production composition changes in PR ✨ Compose and certify the supervised adversarial implementation workflow #181 before this prerequisite merges.

              Dependencies

              Activity

              Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

              Metadata

              Metadata

              Assignees

              No one assigned

                Labels

                No labels
                No labels

                Projects

                No projects

                  Milestone

                  No milestone

                  Relationships

                  None yet

                  Development

                  No branches or pull requests

                  Issue actions

                  , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
                  Skip to content

                  Resume through durable effects performed inside generated XMD #589

                  Description

                  @taras

                  Story

                  As a workflow author, I want a retained workflow to resume through durable effects performed inside an admitted generated-XMD fragment, so completed observations and mutations are restored exactly once and later authored effects continue in order.

                  Context and ownership

                  This is a regression against #369's settled continuation contract, not a new admission policy, product decision, or durable-stream schema.

                  The defect was confirmed while implementing #301 slice 2 on draft PR #181:

                  • exact reproducer head: 9ef6edcf205f57ba08cc84ba7a009919ed403957;
                  • base/current main when frozen: f230e8fd59df293fb9b1677ef4a7466900be4a99;
                  • a generated fragment with a durable effect runs on start;
                  • a later suspension is retained;
                  • resume diverges before the nested generated effect is re-offered;
                  • removing <Evaluate>, or keeping a generated fragment with no durable effect, allows resume to complete.

                  Leave #369 closed as the historical delivery and link it to this correction.

                  PR #181 remains paused. This issue and its implementation PR own the production correction; #181 will later rebase and convert AC4 from a blocker assertion into a successful continuation regression with zero repeated evidence-provider reads.

                  Settled ownership and replay contract

                  Generated admission and every nested generated effect belong to the same owning durable document expansion. They must be offered in authored order:

                  generated_xmd
                  nested generated effect 1
                  nested generated effect 2
                  later parent effect
                  suspension_request
                  

                  On continuation, the same sequence is offered again. Retained results are consumed without re-executing completed providers or mutations.

                  The current defect is the non-durable bridge around an operation that can yield durable effects: expand() runs through ephemeral() in packages/core/src/generated-xmd.ts. An ephemeral operation is journal-transparent and reruns on replay, so it cannot own a mixed expansion containing ordinary durable effects.

                  Use the existing owning document expansion. Do not create a child durable coroutine or another lifecycle owner.

                  Selected implementation boundary

                  • Make evaluateGeneratedXmd() an Operation<GeneratedObservationResult>.
                  • Make evaluateGeneratedFragment() and the workflow package's internal admission wrapper Operations.
                  • Yield the retained admission directly.
                  • Run complete-fragment preflight and the admitted expansion inline.
                  • Remove the ephemeral(expand(...)) boundary.
                  • Preserve the fragment's existing scoped() ownership for middleware, cancellation, and teardown.
                  • Keep policy comparison before the first nested provider or mutation.

                  This places the fragment's durable effects directly in the expansion operation already owned by the document.

                  Do not add durableSpawn, a child coroutine, flattened records, skipped history, or mutation reruns. DurablePreparation does not change, and @executablemd/durable-streams gains no schema, protocol, or primitive.

                  The trusted-host TypeScript surface widens from the narrower Workflow return type to Operation. The authored <Evaluate> API and journal schemas remain unchanged.

                  Host documentation that says the evaluator is reached from a DurablePreparation must be corrected: the workflow path reaches it through the trusted <Evaluate> component inside the owning document expansion.

                  Frozen acceptance evidence

                  1. A generated fragment containing a durable read resumes past a later suspension and completes.
                  2. A generated fragment containing a durable write resumes past a later suspension and completes.
                  3. The exact journal order is generated_xmd, every nested effect in authored order, later parent effects, then suspension_request.
                  4. Across resume, each completed read provider and mutation is invoked exactly once.
                  5. A changed retained admission policy refuses before any nested provider or mutation runs.
                  6. Empty fragments and fragments with no durable effects preserve their current behavior.
                  7. Existing GX15 and GX16 generated-XMD continuation controls remain green.
                  8. Existing GXC9 policy controls remain green.
                  9. The Compose the supervised adversarial implementation workflow #301 AC4 reproducer fails before the correction and completes after it, with the exact retained evidence reaching the Planner and checkpoint material and zero repeated evidence-provider reads.

                  The focused regression must distinguish start from resume and must assert provider/mutation call counts, not only the final result.

                  Implementation scope

                  A focused PR targeting current main owns:

                  • canonical generated-XMD execution in packages/core/src/generated-xmd.ts;
                  • the workflow admission wrapper and its types;
                  • generated-XMD read/write continuation regressions;
                  • architecture.md generated-XMD ownership wording;
                  • workflow specification §8.4 and §9;
                  • applicable executable-MDX GX/GXC/WGAC rows;
                  • a superseding decision-log clarification that mixed generated expansion offers its durable effects inline rather than hiding them behind a nested non-durable bridge.

                  Focused feedback evidence

                  Run the smallest explicit affected set, including the new continuation regression:

                  deno task test packages/core/tests/generated-xmd.test.ts packages/workflow/tests/generated-observations.test.ts packages/workflow/tests/workflow-suspension-answer.test.ts <new-continuation-regression>
                  git diff --check

                  Also run the exact #301 AC4 reproducer or an extracted equivalent against the corrected production path and report the journal order and provider/mutation invocation counts.

                  Create a feedback commit promptly once this frozen matrix passes. Return its exact SHA, exact base, every command/result, and a criterion-by-criterion evidence map. Implementation feedback does not wait for or inspect CI.

                  Out of scope

                  • Admission-policy, pinned-identity, allowed-effect, or authored <Evaluate> API changes.
                  • Durable effect-schema or journal-schema changes.
                  • Workspace transaction changes.
                  • Suspension, answer-delivery, cancellation, or teardown semantics.
                  • A new durable-stream primitive or protocol.
                  • A child durable coroutine, flattened history, skipped records, or replaying completed work.
                  • Production composition changes in PR ✨ Compose and certify the supervised adversarial implementation workflow #181 before this prerequisite merges.

                  Dependencies

                  Activity

                  Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

                  Metadata

                  Metadata

                  Assignees

                  No one assigned

                    Labels

                    No labels
                    No labels

                    Projects

                    No projects

                      Milestone

                      No milestone

                      Relationships

                      None yet

                      Development

                      No branches or pull requests

                      Issue actions

                      , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
                      Skip to content

                      Resume through durable effects performed inside generated XMD #589

                      Description

                      @taras

                      Story

                      As a workflow author, I want a retained workflow to resume through durable effects performed inside an admitted generated-XMD fragment, so completed observations and mutations are restored exactly once and later authored effects continue in order.

                      Context and ownership

                      This is a regression against #369's settled continuation contract, not a new admission policy, product decision, or durable-stream schema.

                      The defect was confirmed while implementing #301 slice 2 on draft PR #181:

                      • exact reproducer head: 9ef6edcf205f57ba08cc84ba7a009919ed403957;
                      • base/current main when frozen: f230e8fd59df293fb9b1677ef4a7466900be4a99;
                      • a generated fragment with a durable effect runs on start;
                      • a later suspension is retained;
                      • resume diverges before the nested generated effect is re-offered;
                      • removing <Evaluate>, or keeping a generated fragment with no durable effect, allows resume to complete.

                      Leave #369 closed as the historical delivery and link it to this correction.

                      PR #181 remains paused. This issue and its implementation PR own the production correction; #181 will later rebase and convert AC4 from a blocker assertion into a successful continuation regression with zero repeated evidence-provider reads.

                      Settled ownership and replay contract

                      Generated admission and every nested generated effect belong to the same owning durable document expansion. They must be offered in authored order:

                      generated_xmd
                      nested generated effect 1
                      nested generated effect 2
                      later parent effect
                      suspension_request
                      

                      On continuation, the same sequence is offered again. Retained results are consumed without re-executing completed providers or mutations.

                      The current defect is the non-durable bridge around an operation that can yield durable effects: expand() runs through ephemeral() in packages/core/src/generated-xmd.ts. An ephemeral operation is journal-transparent and reruns on replay, so it cannot own a mixed expansion containing ordinary durable effects.

                      Use the existing owning document expansion. Do not create a child durable coroutine or another lifecycle owner.

                      Selected implementation boundary

                      • Make evaluateGeneratedXmd() an Operation<GeneratedObservationResult>.
                      • Make evaluateGeneratedFragment() and the workflow package's internal admission wrapper Operations.
                      • Yield the retained admission directly.
                      • Run complete-fragment preflight and the admitted expansion inline.
                      • Remove the ephemeral(expand(...)) boundary.
                      • Preserve the fragment's existing scoped() ownership for middleware, cancellation, and teardown.
                      • Keep policy comparison before the first nested provider or mutation.

                      This places the fragment's durable effects directly in the expansion operation already owned by the document.

                      Do not add durableSpawn, a child coroutine, flattened records, skipped history, or mutation reruns. DurablePreparation does not change, and @executablemd/durable-streams gains no schema, protocol, or primitive.

                      The trusted-host TypeScript surface widens from the narrower Workflow return type to Operation. The authored <Evaluate> API and journal schemas remain unchanged.

                      Host documentation that says the evaluator is reached from a DurablePreparation must be corrected: the workflow path reaches it through the trusted <Evaluate> component inside the owning document expansion.

                      Frozen acceptance evidence

                      1. A generated fragment containing a durable read resumes past a later suspension and completes.
                      2. A generated fragment containing a durable write resumes past a later suspension and completes.
                      3. The exact journal order is generated_xmd, every nested effect in authored order, later parent effects, then suspension_request.
                      4. Across resume, each completed read provider and mutation is invoked exactly once.
                      5. A changed retained admission policy refuses before any nested provider or mutation runs.
                      6. Empty fragments and fragments with no durable effects preserve their current behavior.
                      7. Existing GX15 and GX16 generated-XMD continuation controls remain green.
                      8. Existing GXC9 policy controls remain green.
                      9. The Compose the supervised adversarial implementation workflow #301 AC4 reproducer fails before the correction and completes after it, with the exact retained evidence reaching the Planner and checkpoint material and zero repeated evidence-provider reads.

                      The focused regression must distinguish start from resume and must assert provider/mutation call counts, not only the final result.

                      Implementation scope

                      A focused PR targeting current main owns:

                      • canonical generated-XMD execution in packages/core/src/generated-xmd.ts;
                      • the workflow admission wrapper and its types;
                      • generated-XMD read/write continuation regressions;
                      • architecture.md generated-XMD ownership wording;
                      • workflow specification §8.4 and §9;
                      • applicable executable-MDX GX/GXC/WGAC rows;
                      • a superseding decision-log clarification that mixed generated expansion offers its durable effects inline rather than hiding them behind a nested non-durable bridge.

                      Focused feedback evidence

                      Run the smallest explicit affected set, including the new continuation regression:

                      deno task test packages/core/tests/generated-xmd.test.ts packages/workflow/tests/generated-observations.test.ts packages/workflow/tests/workflow-suspension-answer.test.ts <new-continuation-regression>
                      git diff --check

                      Also run the exact #301 AC4 reproducer or an extracted equivalent against the corrected production path and report the journal order and provider/mutation invocation counts.

                      Create a feedback commit promptly once this frozen matrix passes. Return its exact SHA, exact base, every command/result, and a criterion-by-criterion evidence map. Implementation feedback does not wait for or inspect CI.

                      Out of scope

                      • Admission-policy, pinned-identity, allowed-effect, or authored <Evaluate> API changes.
                      • Durable effect-schema or journal-schema changes.
                      • Workspace transaction changes.
                      • Suspension, answer-delivery, cancellation, or teardown semantics.
                      • A new durable-stream primitive or protocol.
                      • A child durable coroutine, flattened history, skipped records, or replaying completed work.
                      • Production composition changes in PR ✨ Compose and certify the supervised adversarial implementation workflow #181 before this prerequisite merges.

                      Dependencies

                      Activity

                      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

                      Metadata

                      Metadata

                      Assignees

                      No one assigned

                        Labels

                        No labels
                        No labels

                        Projects

                        No projects

                          Milestone

                          No milestone

                          Relationships

                          None yet

                          Development

                          No branches or pull requests

                          Issue actions

                          , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
                          Skip to content

                          Resume through durable effects performed inside generated XMD #589

                          Description

                          @taras

                          Story

                          As a workflow author, I want a retained workflow to resume through durable effects performed inside an admitted generated-XMD fragment, so completed observations and mutations are restored exactly once and later authored effects continue in order.

                          Context and ownership

                          This is a regression against #369's settled continuation contract, not a new admission policy, product decision, or durable-stream schema.

                          The defect was confirmed while implementing #301 slice 2 on draft PR #181:

                          • exact reproducer head: 9ef6edcf205f57ba08cc84ba7a009919ed403957;
                          • base/current main when frozen: f230e8fd59df293fb9b1677ef4a7466900be4a99;
                          • a generated fragment with a durable effect runs on start;
                          • a later suspension is retained;
                          • resume diverges before the nested generated effect is re-offered;
                          • removing <Evaluate>, or keeping a generated fragment with no durable effect, allows resume to complete.

                          Leave #369 closed as the historical delivery and link it to this correction.

                          PR #181 remains paused. This issue and its implementation PR own the production correction; #181 will later rebase and convert AC4 from a blocker assertion into a successful continuation regression with zero repeated evidence-provider reads.

                          Settled ownership and replay contract

                          Generated admission and every nested generated effect belong to the same owning durable document expansion. They must be offered in authored order:

                          generated_xmd
                          nested generated effect 1
                          nested generated effect 2
                          later parent effect
                          suspension_request
                          

                          On continuation, the same sequence is offered again. Retained results are consumed without re-executing completed providers or mutations.

                          The current defect is the non-durable bridge around an operation that can yield durable effects: expand() runs through ephemeral() in packages/core/src/generated-xmd.ts. An ephemeral operation is journal-transparent and reruns on replay, so it cannot own a mixed expansion containing ordinary durable effects.

                          Use the existing owning document expansion. Do not create a child durable coroutine or another lifecycle owner.

                          Selected implementation boundary

                          • Make evaluateGeneratedXmd() an Operation<GeneratedObservationResult>.
                          • Make evaluateGeneratedFragment() and the workflow package's internal admission wrapper Operations.
                          • Yield the retained admission directly.
                          • Run complete-fragment preflight and the admitted expansion inline.
                          • Remove the ephemeral(expand(...)) boundary.
                          • Preserve the fragment's existing scoped() ownership for middleware, cancellation, and teardown.
                          • Keep policy comparison before the first nested provider or mutation.

                          This places the fragment's durable effects directly in the expansion operation already owned by the document.

                          Do not add durableSpawn, a child coroutine, flattened records, skipped history, or mutation reruns. DurablePreparation does not change, and @executablemd/durable-streams gains no schema, protocol, or primitive.

                          The trusted-host TypeScript surface widens from the narrower Workflow return type to Operation. The authored <Evaluate> API and journal schemas remain unchanged.

                          Host documentation that says the evaluator is reached from a DurablePreparation must be corrected: the workflow path reaches it through the trusted <Evaluate> component inside the owning document expansion.

                          Frozen acceptance evidence

                          1. A generated fragment containing a durable read resumes past a later suspension and completes.
                          2. A generated fragment containing a durable write resumes past a later suspension and completes.
                          3. The exact journal order is generated_xmd, every nested effect in authored order, later parent effects, then suspension_request.
                          4. Across resume, each completed read provider and mutation is invoked exactly once.
                          5. A changed retained admission policy refuses before any nested provider or mutation runs.
                          6. Empty fragments and fragments with no durable effects preserve their current behavior.
                          7. Existing GX15 and GX16 generated-XMD continuation controls remain green.
                          8. Existing GXC9 policy controls remain green.
                          9. The Compose the supervised adversarial implementation workflow #301 AC4 reproducer fails before the correction and completes after it, with the exact retained evidence reaching the Planner and checkpoint material and zero repeated evidence-provider reads.

                          The focused regression must distinguish start from resume and must assert provider/mutation call counts, not only the final result.

                          Implementation scope

                          A focused PR targeting current main owns:

                          • canonical generated-XMD execution in packages/core/src/generated-xmd.ts;
                          • the workflow admission wrapper and its types;
                          • generated-XMD read/write continuation regressions;
                          • architecture.md generated-XMD ownership wording;
                          • workflow specification §8.4 and §9;
                          • applicable executable-MDX GX/GXC/WGAC rows;
                          • a superseding decision-log clarification that mixed generated expansion offers its durable effects inline rather than hiding them behind a nested non-durable bridge.

                          Focused feedback evidence

                          Run the smallest explicit affected set, including the new continuation regression:

                          deno task test packages/core/tests/generated-xmd.test.ts packages/workflow/tests/generated-observations.test.ts packages/workflow/tests/workflow-suspension-answer.test.ts <new-continuation-regression>
                          git diff --check

                          Also run the exact #301 AC4 reproducer or an extracted equivalent against the corrected production path and report the journal order and provider/mutation invocation counts.

                          Create a feedback commit promptly once this frozen matrix passes. Return its exact SHA, exact base, every command/result, and a criterion-by-criterion evidence map. Implementation feedback does not wait for or inspect CI.

                          Out of scope

                          • Admission-policy, pinned-identity, allowed-effect, or authored <Evaluate> API changes.
                          • Durable effect-schema or journal-schema changes.
                          • Workspace transaction changes.
                          • Suspension, answer-delivery, cancellation, or teardown semantics.
                          • A new durable-stream primitive or protocol.
                          • A child durable coroutine, flattened history, skipped records, or replaying completed work.
                          • Production composition changes in PR ✨ Compose and certify the supervised adversarial implementation workflow #181 before this prerequisite merges.

                          Dependencies

                          Activity

                          Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

                          Metadata

                          Metadata

                          Assignees

                          No one assigned

                            Labels

                            No labels
                            No labels

                            Projects

                            No projects

                              Milestone

                              No milestone

                              Relationships

                              None yet

                              Development

                              No branches or pull requests

                              Issue actions

                              , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
                              Skip to content

                              Resume through durable effects performed inside generated XMD #589

                              Description

                              @taras

                              Story

                              As a workflow author, I want a retained workflow to resume through durable effects performed inside an admitted generated-XMD fragment, so completed observations and mutations are restored exactly once and later authored effects continue in order.

                              Context and ownership

                              This is a regression against #369's settled continuation contract, not a new admission policy, product decision, or durable-stream schema.

                              The defect was confirmed while implementing #301 slice 2 on draft PR #181:

                              • exact reproducer head: 9ef6edcf205f57ba08cc84ba7a009919ed403957;
                              • base/current main when frozen: f230e8fd59df293fb9b1677ef4a7466900be4a99;
                              • a generated fragment with a durable effect runs on start;
                              • a later suspension is retained;
                              • resume diverges before the nested generated effect is re-offered;
                              • removing <Evaluate>, or keeping a generated fragment with no durable effect, allows resume to complete.

                              Leave #369 closed as the historical delivery and link it to this correction.

                              PR #181 remains paused. This issue and its implementation PR own the production correction; #181 will later rebase and convert AC4 from a blocker assertion into a successful continuation regression with zero repeated evidence-provider reads.

                              Settled ownership and replay contract

                              Generated admission and every nested generated effect belong to the same owning durable document expansion. They must be offered in authored order:

                              generated_xmd
                              nested generated effect 1
                              nested generated effect 2
                              later parent effect
                              suspension_request
                              

                              On continuation, the same sequence is offered again. Retained results are consumed without re-executing completed providers or mutations.

                              The current defect is the non-durable bridge around an operation that can yield durable effects: expand() runs through ephemeral() in packages/core/src/generated-xmd.ts. An ephemeral operation is journal-transparent and reruns on replay, so it cannot own a mixed expansion containing ordinary durable effects.

                              Use the existing owning document expansion. Do not create a child durable coroutine or another lifecycle owner.

                              Selected implementation boundary

                              • Make evaluateGeneratedXmd() an Operation<GeneratedObservationResult>.
                              • Make evaluateGeneratedFragment() and the workflow package's internal admission wrapper Operations.
                              • Yield the retained admission directly.
                              • Run complete-fragment preflight and the admitted expansion inline.
                              • Remove the ephemeral(expand(...)) boundary.
                              • Preserve the fragment's existing scoped() ownership for middleware, cancellation, and teardown.
                              • Keep policy comparison before the first nested provider or mutation.

                              This places the fragment's durable effects directly in the expansion operation already owned by the document.

                              Do not add durableSpawn, a child coroutine, flattened records, skipped history, or mutation reruns. DurablePreparation does not change, and @executablemd/durable-streams gains no schema, protocol, or primitive.

                              The trusted-host TypeScript surface widens from the narrower Workflow return type to Operation. The authored <Evaluate> API and journal schemas remain unchanged.

                              Host documentation that says the evaluator is reached from a DurablePreparation must be corrected: the workflow path reaches it through the trusted <Evaluate> component inside the owning document expansion.

                              Frozen acceptance evidence

                              1. A generated fragment containing a durable read resumes past a later suspension and completes.
                              2. A generated fragment containing a durable write resumes past a later suspension and completes.
                              3. The exact journal order is generated_xmd, every nested effect in authored order, later parent effects, then suspension_request.
                              4. Across resume, each completed read provider and mutation is invoked exactly once.
                              5. A changed retained admission policy refuses before any nested provider or mutation runs.
                              6. Empty fragments and fragments with no durable effects preserve their current behavior.
                              7. Existing GX15 and GX16 generated-XMD continuation controls remain green.
                              8. Existing GXC9 policy controls remain green.
                              9. The Compose the supervised adversarial implementation workflow #301 AC4 reproducer fails before the correction and completes after it, with the exact retained evidence reaching the Planner and checkpoint material and zero repeated evidence-provider reads.

                              The focused regression must distinguish start from resume and must assert provider/mutation call counts, not only the final result.

                              Implementation scope

                              A focused PR targeting current main owns:

                              • canonical generated-XMD execution in packages/core/src/generated-xmd.ts;
                              • the workflow admission wrapper and its types;
                              • generated-XMD read/write continuation regressions;
                              • architecture.md generated-XMD ownership wording;
                              • workflow specification §8.4 and §9;
                              • applicable executable-MDX GX/GXC/WGAC rows;
                              • a superseding decision-log clarification that mixed generated expansion offers its durable effects inline rather than hiding them behind a nested non-durable bridge.

                              Focused feedback evidence

                              Run the smallest explicit affected set, including the new continuation regression:

                              deno task test packages/core/tests/generated-xmd.test.ts packages/workflow/tests/generated-observations.test.ts packages/workflow/tests/workflow-suspension-answer.test.ts <new-continuation-regression>
                              git diff --check

                              Also run the exact #301 AC4 reproducer or an extracted equivalent against the corrected production path and report the journal order and provider/mutation invocation counts.

                              Create a feedback commit promptly once this frozen matrix passes. Return its exact SHA, exact base, every command/result, and a criterion-by-criterion evidence map. Implementation feedback does not wait for or inspect CI.

                              Out of scope

                              • Admission-policy, pinned-identity, allowed-effect, or authored <Evaluate> API changes.
                              • Durable effect-schema or journal-schema changes.
                              • Workspace transaction changes.
                              • Suspension, answer-delivery, cancellation, or teardown semantics.
                              • A new durable-stream primitive or protocol.
                              • A child durable coroutine, flattened history, skipped records, or replaying completed work.
                              • Production composition changes in PR ✨ Compose and certify the supervised adversarial implementation workflow #181 before this prerequisite merges.

                              Dependencies

                              Activity

                              Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

                              Metadata

                              Metadata

                              Assignees

                              No one assigned

                                Labels

                                No labels
                                No labels

                                Projects

                                No projects

                                  Milestone

                                  No milestone

                                  Relationships

                                  None yet

                                  Development

                                  No branches or pull requests

                                  Issue actions