🔐 Make the executor lock the only way a run's lifecycle moves

packages/cli/src/deno-workflow.ts

@@ -20,9 +20,10 @@ import type { Operation } from "effection";
 import { env as readEnv } from "@executablemd/runtime";
 import {
  useWorkflowLifecycle,
-useWorkflowRunStorage,
+useWorkflowRunHost,
  withWorkflowWorkspace,
 } from "@executablemd/workflow/deno";
+import type { WorkflowExecutionTransitions } from "@executablemd/workflow/deno";
 import type { WorkflowRunDatabase } from "@executablemd/workflow";
 import type { WorkflowHost } from "./workflow.ts";
 
@@ -37,8 +38,8 @@ export function* useDenoWorkflowHost(): Operation<WorkflowHost> {
  const root =
  configured === undefined || configured === "" ? DEFAULT_RUN_STORAGE_ROOT : configured;
  return {
-useStorage(): Operation<void> {
- return useWorkflowRunStorage({ root });
+useRunHost(): Operation<WorkflowExecutionTransitions> {
+ return useWorkflowRunHost({ root });
  },
  useLifecycle(): Operation<void> {
  return useWorkflowLifecycle({ root });

packages/cli/src/workflow-management.ts

@@ -2,7 +2,7 @@
  * `xmd workflow status`, `list` and `history` — reading a run without running it.
  *
  * These commands answer from immutable lifecycle snapshots. Nothing here opens
- * a writable database, acquires a lease, replays, attaches a Workspace,
+ * a writable database, acquires the executor lock, replays, attaches a Workspace,
  * materializes a root, imports a document or contacts a provider: what a
  * reading command may do is read.
  *
@@ -25,7 +25,7 @@
 
 import { scoped } from "effection";
 import type { Operation } from "effection";
-import { WorkflowLifecycle, WorkflowLifecycleProviderError } from "@executablemd/workflow";
+import { WorkflowLifecycle } from "@executablemd/workflow";
 import type {
  WorkflowHistoryEntry,
  WorkflowLifecycleSnapshot,
@@ -76,26 +76,25 @@ export function runWorkflowManagement(
  write(request.json ? json(entries.value) : renderHistory(entries.value));
  return { exitCode: 0 };
  }
- case "cancel":
+ case "cancel": {
+ const cancelled = yield* WorkflowLifecycle.operations.cancel(request.runId);
+ if (!cancelled.ok) {
+ return refuse(cancelled.error);
+ }
+ // The command reports its own request, not the run's outcome: asking
+ // for a cancellation and getting one is success, however terminal the
+ // status it left behind.
+ write(`workflow cancel: ${cancelled.value.runId} (${cancelled.value.status})`);
+ return { exitCode: 0 };
+ }
  case "delete": {
- // An operation this host installs no handler for is a refusal to
- // report, not a crash: the Api's fail-closed default says exactly which
- // operation has no provider, and that sentence is the answer.
- try {
- const answered =
- request.action === "cancel"
- ? yield* WorkflowLifecycle.operations.cancel(request.runId)
- : yield* WorkflowLifecycle.operations.delete(request.runId);
- if (!answered.ok) {
- return refuse(answered.error);
- }
- } catch (error) {
- if (error instanceof WorkflowLifecycleProviderError) {
- return refuse(error);
- }
- throw error;
+ const deleted = yield* WorkflowLifecycle.operations.delete(request.runId);
+ if (!deleted.ok) {
+ return refuse(deleted.error);
  }
- write(`workflow ${request.action}: ${request.runId}`);
+ // Only what actually went. Nothing here claims to have undone an
+ // effect the run had on anything outside itself.
+ write(`workflow delete: ${request.runId} (${deleted.value.removed.join(", ")})`);
  return { exitCode: 0 };
  }
  }

packages/cli/src/deno-workflow.ts

@@ -20,9 +20,10 @@ import type { Operation } from "effection";
 import { env as readEnv } from "@executablemd/runtime";
 import {
  useWorkflowLifecycle,
-useWorkflowRunStorage,
+useWorkflowRunHost,
  withWorkflowWorkspace,
 } from "@executablemd/workflow/deno";
+import type { WorkflowExecutionTransitions } from "@executablemd/workflow/deno";
 import type { WorkflowRunDatabase } from "@executablemd/workflow";
 import type { WorkflowHost } from "./workflow.ts";
 
@@ -37,8 +38,8 @@ export function* useDenoWorkflowHost(): Operation<WorkflowHost> {
  const root =
  configured === undefined || configured === "" ? DEFAULT_RUN_STORAGE_ROOT : configured;
  return {
-useStorage(): Operation<void> {
- return useWorkflowRunStorage({ root });
+useRunHost(): Operation<WorkflowExecutionTransitions> {
+ return useWorkflowRunHost({ root });
  },
  useLifecycle(): Operation<void> {
  return useWorkflowLifecycle({ root });

packages/cli/src/workflow-management.ts

@@ -2,7 +2,7 @@
  * `xmd workflow status`, `list` and `history` — reading a run without running it.
  *
  * These commands answer from immutable lifecycle snapshots. Nothing here opens
- * a writable database, acquires a lease, replays, attaches a Workspace,
+ * a writable database, acquires the executor lock, replays, attaches a Workspace,
  * materializes a root, imports a document or contacts a provider: what a
  * reading command may do is read.
  *
@@ -25,7 +25,7 @@
 
 import { scoped } from "effection";
 import type { Operation } from "effection";
-import { WorkflowLifecycle, WorkflowLifecycleProviderError } from "@executablemd/workflow";
+import { WorkflowLifecycle } from "@executablemd/workflow";
 import type {
  WorkflowHistoryEntry,
  WorkflowLifecycleSnapshot,
@@ -76,26 +76,25 @@ export function runWorkflowManagement(
  write(request.json ? json(entries.value) : renderHistory(entries.value));
  return { exitCode: 0 };
  }
- case "cancel":
+ case "cancel": {
+ const cancelled = yield* WorkflowLifecycle.operations.cancel(request.runId);
+ if (!cancelled.ok) {
+ return refuse(cancelled.error);
+ }
+ // The command reports its own request, not the run's outcome: asking
+ // for a cancellation and getting one is success, however terminal the
+ // status it left behind.
+ write(`workflow cancel: ${cancelled.value.runId} (${cancelled.value.status})`);
+ return { exitCode: 0 };
+ }
  case "delete": {
- // An operation this host installs no handler for is a refusal to
- // report, not a crash: the Api's fail-closed default says exactly which
- // operation has no provider, and that sentence is the answer.
- try {
- const answered =
- request.action === "cancel"
- ? yield* WorkflowLifecycle.operations.cancel(request.runId)
- : yield* WorkflowLifecycle.operations.delete(request.runId);
- if (!answered.ok) {
- return refuse(answered.error);
- }
- } catch (error) {
- if (error instanceof WorkflowLifecycleProviderError) {
- return refuse(error);
- }
- throw error;
+ const deleted = yield* WorkflowLifecycle.operations.delete(request.runId);
+ if (!deleted.ok) {
+ return refuse(deleted.error);
  }
- write(`workflow ${request.action}: ${request.runId}`);
+ // Only what actually went. Nothing here claims to have undone an
+ // effect the run had on anything outside itself.
+ write(`workflow delete: ${request.runId} (${deleted.value.removed.join(", ")})`);
  return { exitCode: 0 };
  }
  }

packages/cli/src/deno-workflow.ts

@@ -20,9 +20,10 @@ import type { Operation } from "effection";
 import { env as readEnv } from "@executablemd/runtime";
 import {
  useWorkflowLifecycle,
-useWorkflowRunStorage,
+useWorkflowRunHost,
  withWorkflowWorkspace,
 } from "@executablemd/workflow/deno";
+import type { WorkflowExecutionTransitions } from "@executablemd/workflow/deno";
 import type { WorkflowRunDatabase } from "@executablemd/workflow";
 import type { WorkflowHost } from "./workflow.ts";
 
@@ -37,8 +38,8 @@ export function* useDenoWorkflowHost(): Operation<WorkflowHost> {
  const root =
  configured === undefined || configured === "" ? DEFAULT_RUN_STORAGE_ROOT : configured;
  return {
-useStorage(): Operation<void> {
- return useWorkflowRunStorage({ root });
+useRunHost(): Operation<WorkflowExecutionTransitions> {
+ return useWorkflowRunHost({ root });
  },
  useLifecycle(): Operation<void> {
  return useWorkflowLifecycle({ root });

packages/cli/src/workflow-management.ts

@@ -2,7 +2,7 @@
  * `xmd workflow status`, `list` and `history` — reading a run without running it.
  *
  * These commands answer from immutable lifecycle snapshots. Nothing here opens
- * a writable database, acquires a lease, replays, attaches a Workspace,
+ * a writable database, acquires the executor lock, replays, attaches a Workspace,
  * materializes a root, imports a document or contacts a provider: what a
  * reading command may do is read.
  *
@@ -25,7 +25,7 @@
 
 import { scoped } from "effection";
 import type { Operation } from "effection";
-import { WorkflowLifecycle, WorkflowLifecycleProviderError } from "@executablemd/workflow";
+import { WorkflowLifecycle } from "@executablemd/workflow";
 import type {
  WorkflowHistoryEntry,
  WorkflowLifecycleSnapshot,
@@ -76,26 +76,25 @@ export function runWorkflowManagement(
  write(request.json ? json(entries.value) : renderHistory(entries.value));
  return { exitCode: 0 };
  }
- case "cancel":
+ case "cancel": {
+ const cancelled = yield* WorkflowLifecycle.operations.cancel(request.runId);
+ if (!cancelled.ok) {
+ return refuse(cancelled.error);
+ }
+ // The command reports its own request, not the run's outcome: asking
+ // for a cancellation and getting one is success, however terminal the
+ // status it left behind.
+ write(`workflow cancel: ${cancelled.value.runId} (${cancelled.value.status})`);
+ return { exitCode: 0 };
+ }
  case "delete": {
- // An operation this host installs no handler for is a refusal to
- // report, not a crash: the Api's fail-closed default says exactly which
- // operation has no provider, and that sentence is the answer.
- try {
- const answered =
- request.action === "cancel"
- ? yield* WorkflowLifecycle.operations.cancel(request.runId)
- : yield* WorkflowLifecycle.operations.delete(request.runId);
- if (!answered.ok) {
- return refuse(answered.error);
- }
- } catch (error) {
- if (error instanceof WorkflowLifecycleProviderError) {
- return refuse(error);
- }
- throw error;
+ const deleted = yield* WorkflowLifecycle.operations.delete(request.runId);
+ if (!deleted.ok) {
+ return refuse(deleted.error);
  }
- write(`workflow ${request.action}: ${request.runId}`);
+ // Only what actually went. Nothing here claims to have undone an
+ // effect the run had on anything outside itself.
+ write(`workflow delete: ${request.runId} (${deleted.value.removed.join(", ")})`);
  return { exitCode: 0 };
  }
  }

packages/cli/src/deno-workflow.ts

@@ -20,9 +20,10 @@ import type { Operation } from "effection";
 import { env as readEnv } from "@executablemd/runtime";
 import {
  useWorkflowLifecycle,
-useWorkflowRunStorage,
+useWorkflowRunHost,
  withWorkflowWorkspace,
 } from "@executablemd/workflow/deno";
+import type { WorkflowExecutionTransitions } from "@executablemd/workflow/deno";
 import type { WorkflowRunDatabase } from "@executablemd/workflow";
 import type { WorkflowHost } from "./workflow.ts";
 
@@ -37,8 +38,8 @@ export function* useDenoWorkflowHost(): Operation<WorkflowHost> {
  const root =
  configured === undefined || configured === "" ? DEFAULT_RUN_STORAGE_ROOT : configured;
  return {
-useStorage(): Operation<void> {
- return useWorkflowRunStorage({ root });
+useRunHost(): Operation<WorkflowExecutionTransitions> {
+ return useWorkflowRunHost({ root });
  },
  useLifecycle(): Operation<void> {
  return useWorkflowLifecycle({ root });

packages/cli/src/workflow-management.ts

@@ -2,7 +2,7 @@
  * `xmd workflow status`, `list` and `history` — reading a run without running it.
  *
  * These commands answer from immutable lifecycle snapshots. Nothing here opens
- * a writable database, acquires a lease, replays, attaches a Workspace,
+ * a writable database, acquires the executor lock, replays, attaches a Workspace,
  * materializes a root, imports a document or contacts a provider: what a
  * reading command may do is read.
  *
@@ -25,7 +25,7 @@
 
 import { scoped } from "effection";
 import type { Operation } from "effection";
-import { WorkflowLifecycle, WorkflowLifecycleProviderError } from "@executablemd/workflow";
+import { WorkflowLifecycle } from "@executablemd/workflow";
 import type {
  WorkflowHistoryEntry,
  WorkflowLifecycleSnapshot,
@@ -76,26 +76,25 @@ export function runWorkflowManagement(
  write(request.json ? json(entries.value) : renderHistory(entries.value));
  return { exitCode: 0 };
  }
- case "cancel":
+ case "cancel": {
+ const cancelled = yield* WorkflowLifecycle.operations.cancel(request.runId);
+ if (!cancelled.ok) {
+ return refuse(cancelled.error);
+ }
+ // The command reports its own request, not the run's outcome: asking
+ // for a cancellation and getting one is success, however terminal the
+ // status it left behind.
+ write(`workflow cancel: ${cancelled.value.runId} (${cancelled.value.status})`);
+ return { exitCode: 0 };
+ }
  case "delete": {
- // An operation this host installs no handler for is a refusal to
- // report, not a crash: the Api's fail-closed default says exactly which
- // operation has no provider, and that sentence is the answer.
- try {
- const answered =
- request.action === "cancel"
- ? yield* WorkflowLifecycle.operations.cancel(request.runId)
- : yield* WorkflowLifecycle.operations.delete(request.runId);
- if (!answered.ok) {
- return refuse(answered.error);
- }
- } catch (error) {
- if (error instanceof WorkflowLifecycleProviderError) {
- return refuse(error);
- }
- throw error;
+ const deleted = yield* WorkflowLifecycle.operations.delete(request.runId);
+ if (!deleted.ok) {
+ return refuse(deleted.error);
  }
- write(`workflow ${request.action}: ${request.runId}`);
+ // Only what actually went. Nothing here claims to have undone an
+ // effect the run had on anything outside itself.
+ write(`workflow delete: ${request.runId} (${deleted.value.removed.join(", ")})`);
  return { exitCode: 0 };
  }
  }

packages/cli/src/deno-workflow.ts

@@ -20,9 +20,10 @@ import type { Operation } from "effection";
 import { env as readEnv } from "@executablemd/runtime";
 import {
  useWorkflowLifecycle,
-useWorkflowRunStorage,
+useWorkflowRunHost,
  withWorkflowWorkspace,
 } from "@executablemd/workflow/deno";
+import type { WorkflowExecutionTransitions } from "@executablemd/workflow/deno";
 import type { WorkflowRunDatabase } from "@executablemd/workflow";
 import type { WorkflowHost } from "./workflow.ts";
 
@@ -37,8 +38,8 @@ export function* useDenoWorkflowHost(): Operation<WorkflowHost> {
  const root =
  configured === undefined || configured === "" ? DEFAULT_RUN_STORAGE_ROOT : configured;
  return {
-useStorage(): Operation<void> {
- return useWorkflowRunStorage({ root });
+useRunHost(): Operation<WorkflowExecutionTransitions> {
+ return useWorkflowRunHost({ root });
  },
  useLifecycle(): Operation<void> {
  return useWorkflowLifecycle({ root });

packages/cli/src/workflow-management.ts

@@ -2,7 +2,7 @@
  * `xmd workflow status`, `list` and `history` — reading a run without running it.
  *
  * These commands answer from immutable lifecycle snapshots. Nothing here opens
- * a writable database, acquires a lease, replays, attaches a Workspace,
+ * a writable database, acquires the executor lock, replays, attaches a Workspace,
  * materializes a root, imports a document or contacts a provider: what a
  * reading command may do is read.
  *
@@ -25,7 +25,7 @@
 
 import { scoped } from "effection";
 import type { Operation } from "effection";
-import { WorkflowLifecycle, WorkflowLifecycleProviderError } from "@executablemd/workflow";
+import { WorkflowLifecycle } from "@executablemd/workflow";
 import type {
  WorkflowHistoryEntry,
  WorkflowLifecycleSnapshot,
@@ -76,26 +76,25 @@ export function runWorkflowManagement(
  write(request.json ? json(entries.value) : renderHistory(entries.value));
  return { exitCode: 0 };
  }
- case "cancel":
+ case "cancel": {
+ const cancelled = yield* WorkflowLifecycle.operations.cancel(request.runId);
+ if (!cancelled.ok) {
+ return refuse(cancelled.error);
+ }
+ // The command reports its own request, not the run's outcome: asking
+ // for a cancellation and getting one is success, however terminal the
+ // status it left behind.
+ write(`workflow cancel: ${cancelled.value.runId} (${cancelled.value.status})`);
+ return { exitCode: 0 };
+ }
  case "delete": {
- // An operation this host installs no handler for is a refusal to
- // report, not a crash: the Api's fail-closed default says exactly which
- // operation has no provider, and that sentence is the answer.
- try {
- const answered =
- request.action === "cancel"
- ? yield* WorkflowLifecycle.operations.cancel(request.runId)
- : yield* WorkflowLifecycle.operations.delete(request.runId);
- if (!answered.ok) {
- return refuse(answered.error);
- }
- } catch (error) {
- if (error instanceof WorkflowLifecycleProviderError) {
- return refuse(error);
- }
- throw error;
+ const deleted = yield* WorkflowLifecycle.operations.delete(request.runId);
+ if (!deleted.ok) {
+ return refuse(deleted.error);
  }
- write(`workflow ${request.action}: ${request.runId}`);
+ // Only what actually went. Nothing here claims to have undone an
+ // effect the run had on anything outside itself.
+ write(`workflow delete: ${request.runId} (${deleted.value.removed.join(", ")})`);
  return { exitCode: 0 };
  }
  }

packages/cli/src/deno-workflow.ts

@@ -20,9 +20,10 @@ import type { Operation } from "effection";
 import { env as readEnv } from "@executablemd/runtime";
 import {
  useWorkflowLifecycle,
-useWorkflowRunStorage,
+useWorkflowRunHost,
  withWorkflowWorkspace,
 } from "@executablemd/workflow/deno";
+import type { WorkflowExecutionTransitions } from "@executablemd/workflow/deno";
 import type { WorkflowRunDatabase } from "@executablemd/workflow";
 import type { WorkflowHost } from "./workflow.ts";
 
@@ -37,8 +38,8 @@ export function* useDenoWorkflowHost(): Operation<WorkflowHost> {
  const root =
  configured === undefined || configured === "" ? DEFAULT_RUN_STORAGE_ROOT : configured;
  return {
-useStorage(): Operation<void> {
- return useWorkflowRunStorage({ root });
+useRunHost(): Operation<WorkflowExecutionTransitions> {
+ return useWorkflowRunHost({ root });
  },
  useLifecycle(): Operation<void> {
  return useWorkflowLifecycle({ root });

packages/cli/src/workflow-management.ts

@@ -2,7 +2,7 @@
  * `xmd workflow status`, `list` and `history` — reading a run without running it.
  *
  * These commands answer from immutable lifecycle snapshots. Nothing here opens
- * a writable database, acquires a lease, replays, attaches a Workspace,
+ * a writable database, acquires the executor lock, replays, attaches a Workspace,
  * materializes a root, imports a document or contacts a provider: what a
  * reading command may do is read.
  *
@@ -25,7 +25,7 @@
 
 import { scoped } from "effection";
 import type { Operation } from "effection";
-import { WorkflowLifecycle, WorkflowLifecycleProviderError } from "@executablemd/workflow";
+import { WorkflowLifecycle } from "@executablemd/workflow";
 import type {
  WorkflowHistoryEntry,
  WorkflowLifecycleSnapshot,
@@ -76,26 +76,25 @@ export function runWorkflowManagement(
  write(request.json ? json(entries.value) : renderHistory(entries.value));
  return { exitCode: 0 };
  }
- case "cancel":
+ case "cancel": {
+ const cancelled = yield* WorkflowLifecycle.operations.cancel(request.runId);
+ if (!cancelled.ok) {
+ return refuse(cancelled.error);
+ }
+ // The command reports its own request, not the run's outcome: asking
+ // for a cancellation and getting one is success, however terminal the
+ // status it left behind.
+ write(`workflow cancel: ${cancelled.value.runId} (${cancelled.value.status})`);
+ return { exitCode: 0 };
+ }
  case "delete": {
- // An operation this host installs no handler for is a refusal to
- // report, not a crash: the Api's fail-closed default says exactly which
- // operation has no provider, and that sentence is the answer.
- try {
- const answered =
- request.action === "cancel"
- ? yield* WorkflowLifecycle.operations.cancel(request.runId)
- : yield* WorkflowLifecycle.operations.delete(request.runId);
- if (!answered.ok) {
- return refuse(answered.error);
- }
- } catch (error) {
- if (error instanceof WorkflowLifecycleProviderError) {
- return refuse(error);
- }
- throw error;
+ const deleted = yield* WorkflowLifecycle.operations.delete(request.runId);
+ if (!deleted.ok) {
+ return refuse(deleted.error);
  }
- write(`workflow ${request.action}: ${request.runId}`);
+ // Only what actually went. Nothing here claims to have undone an
+ // effect the run had on anything outside itself.
+ write(`workflow delete: ${request.runId} (${deleted.value.removed.join(", ")})`);
  return { exitCode: 0 };
  }
  }

packages/cli/src/deno-workflow.ts

@@ -20,9 +20,10 @@ import type { Operation } from "effection";
 import { env as readEnv } from "@executablemd/runtime";
 import {
  useWorkflowLifecycle,
-useWorkflowRunStorage,
+useWorkflowRunHost,
  withWorkflowWorkspace,
 } from "@executablemd/workflow/deno";
+import type { WorkflowExecutionTransitions } from "@executablemd/workflow/deno";
 import type { WorkflowRunDatabase } from "@executablemd/workflow";
 import type { WorkflowHost } from "./workflow.ts";
 
@@ -37,8 +38,8 @@ export function* useDenoWorkflowHost(): Operation<WorkflowHost> {
  const root =
  configured === undefined || configured === "" ? DEFAULT_RUN_STORAGE_ROOT : configured;
  return {
-useStorage(): Operation<void> {
- return useWorkflowRunStorage({ root });
+useRunHost(): Operation<WorkflowExecutionTransitions> {
+ return useWorkflowRunHost({ root });
  },
  useLifecycle(): Operation<void> {
  return useWorkflowLifecycle({ root });

packages/cli/src/workflow-management.ts

@@ -2,7 +2,7 @@
  * `xmd workflow status`, `list` and `history` — reading a run without running it.
  *
  * These commands answer from immutable lifecycle snapshots. Nothing here opens
- * a writable database, acquires a lease, replays, attaches a Workspace,
+ * a writable database, acquires the executor lock, replays, attaches a Workspace,
  * materializes a root, imports a document or contacts a provider: what a
  * reading command may do is read.
  *
@@ -25,7 +25,7 @@
 
 import { scoped } from "effection";
 import type { Operation } from "effection";
-import { WorkflowLifecycle, WorkflowLifecycleProviderError } from "@executablemd/workflow";
+import { WorkflowLifecycle } from "@executablemd/workflow";
 import type {
  WorkflowHistoryEntry,
  WorkflowLifecycleSnapshot,
@@ -76,26 +76,25 @@ export function runWorkflowManagement(
  write(request.json ? json(entries.value) : renderHistory(entries.value));
  return { exitCode: 0 };
  }
- case "cancel":
+ case "cancel": {
+ const cancelled = yield* WorkflowLifecycle.operations.cancel(request.runId);
+ if (!cancelled.ok) {
+ return refuse(cancelled.error);
+ }
+ // The command reports its own request, not the run's outcome: asking
+ // for a cancellation and getting one is success, however terminal the
+ // status it left behind.
+ write(`workflow cancel: ${cancelled.value.runId} (${cancelled.value.status})`);
+ return { exitCode: 0 };
+ }
  case "delete": {
- // An operation this host installs no handler for is a refusal to
- // report, not a crash: the Api's fail-closed default says exactly which
- // operation has no provider, and that sentence is the answer.
- try {
- const answered =
- request.action === "cancel"
- ? yield* WorkflowLifecycle.operations.cancel(request.runId)
- : yield* WorkflowLifecycle.operations.delete(request.runId);
- if (!answered.ok) {
- return refuse(answered.error);
- }
- } catch (error) {
- if (error instanceof WorkflowLifecycleProviderError) {
- return refuse(error);
- }
- throw error;
+ const deleted = yield* WorkflowLifecycle.operations.delete(request.runId);
+ if (!deleted.ok) {
+ return refuse(deleted.error);
  }
- write(`workflow ${request.action}: ${request.runId}`);
+ // Only what actually went. Nothing here claims to have undone an
+ // effect the run had on anything outside itself.
+ write(`workflow delete: ${request.runId} (${deleted.value.removed.join(", ")})`);
  return { exitCode: 0 };
  }
  }

packages/cli/src/deno-workflow.ts

@@ -20,9 +20,10 @@ import type { Operation } from "effection";
 import { env as readEnv } from "@executablemd/runtime";
 import {
  useWorkflowLifecycle,
-useWorkflowRunStorage,
+useWorkflowRunHost,
  withWorkflowWorkspace,
 } from "@executablemd/workflow/deno";
+import type { WorkflowExecutionTransitions } from "@executablemd/workflow/deno";
 import type { WorkflowRunDatabase } from "@executablemd/workflow";
 import type { WorkflowHost } from "./workflow.ts";
 
@@ -37,8 +38,8 @@ export function* useDenoWorkflowHost(): Operation<WorkflowHost> {
  const root =
  configured === undefined || configured === "" ? DEFAULT_RUN_STORAGE_ROOT : configured;
  return {
-useStorage(): Operation<void> {
- return useWorkflowRunStorage({ root });
+useRunHost(): Operation<WorkflowExecutionTransitions> {
+ return useWorkflowRunHost({ root });
  },
  useLifecycle(): Operation<void> {
  return useWorkflowLifecycle({ root });

packages/cli/src/workflow-management.ts

@@ -2,7 +2,7 @@
  * `xmd workflow status`, `list` and `history` — reading a run without running it.
  *
  * These commands answer from immutable lifecycle snapshots. Nothing here opens
- * a writable database, acquires a lease, replays, attaches a Workspace,
+ * a writable database, acquires the executor lock, replays, attaches a Workspace,
  * materializes a root, imports a document or contacts a provider: what a
  * reading command may do is read.
  *
@@ -25,7 +25,7 @@
 
 import { scoped } from "effection";
 import type { Operation } from "effection";
-import { WorkflowLifecycle, WorkflowLifecycleProviderError } from "@executablemd/workflow";
+import { WorkflowLifecycle } from "@executablemd/workflow";
 import type {
  WorkflowHistoryEntry,
  WorkflowLifecycleSnapshot,
@@ -76,26 +76,25 @@ export function runWorkflowManagement(
  write(request.json ? json(entries.value) : renderHistory(entries.value));
  return { exitCode: 0 };
  }
- case "cancel":
+ case "cancel": {
+ const cancelled = yield* WorkflowLifecycle.operations.cancel(request.runId);
+ if (!cancelled.ok) {
+ return refuse(cancelled.error);
+ }
+ // The command reports its own request, not the run's outcome: asking
+ // for a cancellation and getting one is success, however terminal the
+ // status it left behind.
+ write(`workflow cancel: ${cancelled.value.runId} (${cancelled.value.status})`);
+ return { exitCode: 0 };
+ }
  case "delete": {
- // An operation this host installs no handler for is a refusal to
- // report, not a crash: the Api's fail-closed default says exactly which
- // operation has no provider, and that sentence is the answer.
- try {
- const answered =
- request.action === "cancel"
- ? yield* WorkflowLifecycle.operations.cancel(request.runId)
- : yield* WorkflowLifecycle.operations.delete(request.runId);
- if (!answered.ok) {
- return refuse(answered.error);
- }
- } catch (error) {
- if (error instanceof WorkflowLifecycleProviderError) {
- return refuse(error);
- }
- throw error;
+ const deleted = yield* WorkflowLifecycle.operations.delete(request.runId);
+ if (!deleted.ok) {
+ return refuse(deleted.error);
  }
- write(`workflow ${request.action}: ${request.runId}`);
+ // Only what actually went. Nothing here claims to have undone an
+ // effect the run had on anything outside itself.
+ write(`workflow delete: ${request.runId} (${deleted.value.removed.join(", ")})`);
  return { exitCode: 0 };
  }
  }