Uh oh!
There was an error while loading. Please reload this page.
テストコード例をわかりやすくする - #5
Closed
yattom wants to merge 15 commits into
Closed
Conversation
ContributorAuthor
コード例に含めたいものとして、下記を意識しています。
意識して今回入れなかったもの:
|
yattom
commented
May 11, 2021
ContributorAuthor
別のPRに依存させてしまいましたが、内容的には独立できるはずなのに手順的にうっかりしました。 |
grimrose
commented
May 11, 2021
Member
Pythonらしい良いテストコードだと思います 👍
気になったので、これを意識して今回入れなかった理由があれば教えて下さい 🙏 |
yattom
commented
May 12, 2021
ContributorAuthor
根拠はないのですが、
と考えました。 |
toshi-kawanishi
commented
May 12, 2021
Member
ありがとうございます 🙇♂️ #2 以降マージして良いかなと思うのですがどうでしょう? |
yattom
commented
May 13, 2021
ContributorAuthor
あ、私はマージ権限ないので、どなたかお願いします。念のため |
grimrose
commented
May 13, 2021
Member
yattom
commented
May 13, 2021
ContributorAuthor
masterに対して #6 で作り直しました。こちらはクローズします。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pytestの最新バージョンで使える、わかりやすいパラメタ化テストやフィクスチャの書き方でテストコード例をわかりやすくする。
先行するPR #2#3#4 に依存しています。