rex3: frame narrow DCB stores by access width, not store address - #83
Open
kaloz wants to merge 1 commit into
Open
rex3: frame narrow DCB stores by access width, not store address#83kaloz wants to merge 1 commit into
kaloz wants to merge 1 commit into
Conversation
write8 and write16 position a narrow store inside the 32-bit dcb_write value by the store's low address bits, but REX3_DCBDATA0 is a fixed auto-incrementing port: the hardware left-justifies a narrow value by its access width. A halfword store at the port's base address gets shift 0 instead of 16, dcb_write's MSB-first extraction reads two zero bytes, and every CMAP ADDRESS_LOW write lands on palette index 0 - NetBSD's console palette collapses into slot 0 and the console renders white on white. Shift by the access width instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
write8 and write16 position a narrow store inside the 32-bit dcb_write value by the store's low address bits, but REX3_DCBDATA0 is a fixed auto-incrementing port: the hardware left-justifies a narrow value by its access width. A halfword store at the port's base address gets shift 0 instead of 16, dcb_write's MSB-first extraction reads two zero bytes, and every CMAP ADDRESS_LOW write lands on palette index 0 - NetBSD's console palette collapses into slot 0 and the console renders white on white. Shift by the access width instead.