Skip to content

rex3: frame narrow DCB stores by access width, not store address - #83

Open
kaloz wants to merge 1 commit into
techomancer:mainfrom
kaloz:main
Open

rex3: frame narrow DCB stores by access width, not store address#83
kaloz wants to merge 1 commit into
techomancer:mainfrom
kaloz:main

Conversation

@kaloz

Copy link
Copy Markdown

write8 and write16 position a narrow store inside the 32-bit dcb_write value by the store's low address bits, but REX3_DCBDATA0 is a fixed auto-incrementing port: the hardware left-justifies a narrow value by its access width. A halfword store at the port's base address gets shift 0 instead of 16, dcb_write's MSB-first extraction reads two zero bytes, and every CMAP ADDRESS_LOW write lands on palette index 0 - NetBSD's console palette collapses into slot 0 and the console renders white on white. Shift by the access width instead.

write8 and write16 position a narrow store inside the 32-bit dcb_write
value by the store's low address bits, but REX3_DCBDATA0 is a fixed
auto-incrementing port: the hardware left-justifies a narrow value by
its access width. A halfword store at the port's base address gets
shift 0 instead of 16, dcb_write's MSB-first extraction reads two zero
bytes, and every CMAP ADDRESS_LOW write lands on palette index 0 -
NetBSD's console palette collapses into slot 0 and the console renders
white on white. Shift by the access width instead.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@kaloz