Eliminate use of unrefined types to simplify API appearance - #6
Open
tel wants to merge 2 commits into
Open
Conversation
telforce-pushed
the
feat-no-unrefined-types
branch
from
January 31, 2016 01:00
c16d3bd to
da22b15Comparetel
commented
Jan 31, 2016
OwnerAuthor
These instances are a bit broken by this change: instanceHeaderEncode 'AccessControlAllowHeaders (Set (HeaderTypeText)) where
headerEncode _ = displaySetOpt .Set.map headerName
instanceHeaderEncode 'AccessControlAllowHeaders [HeaderTypeText] where
headerEncode = uniqueSet |
tel
commented
Feb 5, 2016
OwnerAuthor
I could probably replace those with something like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now the
Apitype is ugly as all hellWhat is that?
nat symbol star? Ugly! Confusing!We can eliminate (probably?) the uses of
natandsymbolif we never actually use unrefined types (see here) though I'm not yet sure how. This will reduce the type noise to justApi starwhich is easier to explain and less noisy. This is a big improvement!