Uh oh!
There was an error while loading. Please reload this page.
Fix loading of request models and *params - #28
Closed
adambartholomew wants to merge 2 commits into
Closed
Conversation
jhaagmans
commented
Aug 15, 2018
@adambartholomew I don't see any differences between this PR and #27. |
adambartholomew
commented
Aug 15, 2018
Author
You are correct. Apologies, I went back and forth with some ideas. Closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combining the commits/comments from the two outstanding PRs. Credit to https://github.com/jhaagmans
#27
#24
I can also confirm that *params and the requestModel properties are being ignored in the serverless.yml configuration. The DefinitionGenerator needs to check for a value in the documentationConfig, not the being-generated operationObj.
This seems to be a regression from 0.3 > 0.4.