Skip to content

bump server for Nexus Query support - #1172

Merged
chaptersix merged 2 commits into
mainfrom
release/1.8.x-nexus-sdk-ergonomics
Aug 22, 2026
Merged

bump server for Nexus Query support#1172
chaptersix merged 2 commits into
mainfrom
release/1.8.x-nexus-sdk-ergonomics

Conversation

@mavemuri

Copy link
Copy Markdown
Contributor

bump server for Nexus Query support

includes minor fix for temporalio/api#846

Related issues

What changed?

Checklist

Stability

  • Breaking changes are marked with 💥 in the PR title and release notes
  • Changes to JSON output (-o json / -o jsonl) are treated as breaking changes

Design

  • This feature does not depend on Cloud-only APIs or behavior (it works against an OSS server)
  • New commands follow temporal <noun> <verb> structure (e.g. temporal workflow start)
  • New flags are named after the API concept, not the implementation mechanism (good: --search-attribute, bad: --index-field)
  • New flags don't duplicate an existing flag that serves the same purpose
  • New flags do not have short aliases without strong justification
  • Experimental features are marked with (Experimental) in commands.yaml

Help text (see style guide at the top of commands.yaml)

  • All flags shown in help text and examples are implemented and functional
  • Summaries use sentence case and have no trailing period
  • Long descriptions end with a period and include at least one example invocation
  • Examples use long flags (--namespace, not -n), one flag per line
  • Placeholder values use YourXxx form (YourWorkflowId, YourNamespace)

Behavior

  • Results go to stdout; errors and warnings go to stderr
  • Error messages are lowercase with no trailing punctuation

Tests

  • Added functional test(s) (SharedServerSuite)
  • Added unit test(s) (func TestXxx) where applicable

Manual tests

Setup

temporal server start-dev --headless
temporal workflow start \
--type YourWorkflowType \
--task-queue YourTaskQueue \
--workflow-id YourWorkflowId

Happy path

$ temporal <command> \
--flag value
<expected output>

Error case

$ temporal <command> \
--invalid-combination
Error: <expected error message>
$ echo $?
1

Composition

$ temporal <command-one> ...
$ temporal <command-two> --flag <value-from-above>
<expected output>

@mavemuri
mavemuri requested a review from a team as a code ownerAugust 21, 2026 23:22
@CLAassistant

CLAassistant commented Aug 21, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:e7ccedb826

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment threadinternal/temporalcli/commands.activity.go
@chaptersix
chaptersix added this pull request to the merge queueAug 22, 2026
Merged via the queue into main with commit f4895a4Aug 22, 2026
11 checks passed
@chaptersix
chaptersix deleted the release/1.8.x-nexus-sdk-ergonomics branch August 22, 2026 17:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mavemuri@CLAassistant@chaptersix