Skip to content

NOT FOR MERGE: standalone activity server feature release - #922

Closed
dandavison wants to merge 8 commits into
standalone-activity-server-release-basefrom
standalone-activity-server
Closed

NOT FOR MERGE: standalone activity server feature release#922
dandavison wants to merge 8 commits into
standalone-activity-server-release-basefrom
standalone-activity-server

Conversation

@dandavison

@dandavisondandavison commented Jan 29, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

This PR represents the state that will be used for release v1.5.1-standalone-activity-server.

See draft release: https://github.com/temporalio/cli/releases

What was changed

Starting from v1.5.1

  • Bump server to v1.30.0-149.0, and api & sdk to versions used by that server version
  • Adapt to breaking changes in those libraries
  • Port pinned version validation and test fixes from main

Why?

  • In order to release a version of the CLI with server support for standalone activity

Checklist

How was this tested:

@dandavison
Bump server to v1.30.0-149.0, and api & sdk to versions used by that …
2ac7514
…server version
go get go.temporal.io/server@v1.30.0-149.0 go.temporal.io/api@v1.61.0 go.temporal.io/sdk@v1.38.0
go mod tidy
@dandavison
Adapt to API v1.61.0 and server v1.30.0 breaking changes
90c33c8
1. dynamicconfig.MakeKey() in devserver/server.go
Server library
change (temporalio/temporal#8171). The CLI
allows users to pass dynamic config values via command line.
dynamicconfig.Key is no longer a string type alias, so we must use
MakeKey(string) constructor.
2. WorkerGroupingKey in commands.worker.go
API protobuf change (temporalio/api#637).
The `temporal worker list` and `temporal worker describe` commands
import go.temporal.io/api/worker/v1 to format server responses.
WorkerHostInfo.ProcessKey was renamed to WorkerGroupingKey.
3. sadefs.ExecutionStatus in commands.workflow_reset_test.go
Server library
change (temporalio/temporal#8673). Test
code imports server internals to construct visibility queries using
canonical search attribute names. The constants moved from
searchattribute to searchattribute/sadefs.
@dandavison
Port pinned version validation and test fixes from main
bafc29a
Backport changes from #905 to
work with server v1.30.0-149.0.
Server PR temporalio/temporal#9020 added
validation that pinned version overrides must reference a version
that exists in the task queue. This broke tests that were setting
pinned overrides without first registering workers for those versions.
Changes:
1. commands.workflow.go: Fix validation to require BOTH deployment
name AND build ID for pinned behavior (change && to ||)
2. commands.workflow_test.go: Update versioning override tests to
start workers for both version1 and version2 before setting
overrides, ensuring versions exist in the task queue
3. commands.workflow_reset_update_options_test.go: Update pinned
behavior reset tests to start a versioned worker before attempting
reset with pinned override
@dandavison
dandavison changed the base branch from main to standalone-activity-server-release-baseJanuary 29, 2026 20:15
@dandavisondandavison reopened this Jan 29, 2026
@dandavison
Enable SA in DC
c43a2eb
@dandavison
Remove obsolete sqlite version pinning test
4b42b89
The sqlite_test.go was pinning modernc.org/sqlite to v1.34.1 due to
https://gitlab.com/cznic/sqlite/-/issues/196 which has since been
resolved. Main branch no longer has this test.
@dandavison
Switch to server main
4bca125
$ go get go.temporal.io/server@f911e1e7a go.temporal.io/api@v1.61.1-0.20260128230845-c246540cf2ed go.temporal.io/sdk@v1.38.0
go: downloading go.temporal.io/server v1.29.0-135.0.0.20260129233227-f911e1e7a56d
go: upgraded go.temporal.io/api v1.61.0 => v1.61.1-0.20260128230845-c246540cf2ed
go: downgraded go.temporal.io/server v1.30.0-149.0 => v1.29.0-135.0.0.20260129233227-f911e1e7a56d
@dandavison
Revert "Switch to server main"
449ca03
This reverts commit 4bca125.
bergundy
bergundy reviewed Feb 4, 2026
View reviewed changes
Comment threadtemporalcli/commands.server.go Outdated
Comment on lines +14 to +16
"history.enableChasm": true,
"history.enableTransitionHistory": true,
"activity.enableStandalone": true,

@bergundybergundyFeb 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocking on this because it's a special release just for the SDK tests, but typically we don't turn features on in the CLI.

@dandavisondandavisonFeb 4, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, reverted the DC changes

@bergundy

bergundy commented Feb 4, 2026

Copy link
Copy Markdown
Member

This LGTM for the temporary release but this base branch is quite behind the main branch. I think you can minimize the changes if you rebase the base on main.

@dandavison

dandavison commented Feb 4, 2026

Copy link
Copy Markdown
ContributorAuthor

This LGTM for the temporary release but this base branch is quite behind the main branch. I think you can minimize the changes if you rebase the base on main.

I based this on the latest CLI release v1.5.1 because it's going to be used in SDK CI, and there's a desire there to stay as close as possible to stable CLI releases when producing ad-hoc releases like this.

@dandavison
dandavison marked this pull request as ready for review February 4, 2026 20:20
@dandavison
dandavison requested review from a team as code ownersFebruary 4, 2026 20:20
cretz
cretz approved these changes Feb 4, 2026
View reviewed changes

@cretzcretz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with the understanding this PR isn't going to be merged anyways

@yuandrew

yuandrew commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

I based this on the latest CLI release v1.5.1 because it's going to be used in SDK CI, and there's a desire there to stay as close as possible to stable CLI releases when producing ad-hoc releases like this.

This sounds good, I was already going to bump the SDK to 1.5.1 due to worker heartbeating, https://github.com/temporalio/sdk-go/pull/2148/changes#diff-265865b1cb4e06ecf08b23b205f709fb4281ba4d4804cbe46f8b91a725073fd5

@chaptersix

chaptersix commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

SAA cli commands are now in main

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergundybergundybergundy left review comments
@yuandrewyuandrewyuandrew approved these changes
@chaptersixchaptersixAwaiting requested review from chaptersix
+1 more reviewer
@cretzcretzcretz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dandavison@bergundy@yuandrew@chaptersix@cretz