Skip to content
This repository was archived by the owner on Jul 10, 2025. It is now read-only.

experimental API policy - #218

Merged
martinwicke merged 9 commits into
tensorflow:masterfrom
alextp:experimental
Apr 6, 2020
Merged

experimental API policy#218
martinwicke merged 9 commits into
tensorflow:masterfrom
alextp:experimental

Conversation

@alextp

Copy link
Copy Markdown
Contributor

No description provided.

@karmelkarmel left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a user, some questions I would have:

  1. How will this be enforced?
  2. I was using the experimental ABC API, and it was non-compliant because of XYZ. Why did that happen?What recourse do I have?

Comment threadgovernance/api-reviews.md Outdated
Comment threadgovernance/api-reviews.md Outdated
Comment threadgovernance/api-reviews.md Outdated
Comment threadgovernance/api-reviews.md Outdated
Comment threadgovernance/api-reviews.md Outdated
alextpand others added 4 commits March 20, 2020 10:28
Co-Authored-By: Martin Wicke <577277+martinwicke@users.noreply.github.com>
Co-Authored-By: Martin Wicke <577277+martinwicke@users.noreply.github.com>
@alextp

Copy link
Copy Markdown
ContributorAuthor
  1. How will this be enforced?

By the same API review process we use to enforce our other API policies? Or did you mean something else (like: "will we write tools to introspect into these APIs?", to which the answer is yes, soon)

  1. I was using the experimental ABC API, and it was non-compliant because of XYZ. Why did that happen?What recourse do I have?

I think this policy says that we cannot remove experimental APIs that break people without a lot of warning (or at all, if we cannot find a good replacement), so it's on us to fix noncompliant APIs as much as we can.

Comment threadgovernance/api-reviews.md
Comment threadgovernance/api-reviews.md
Comment threadgovernance/api-reviews.md Outdated
Comment threadgovernance/api-reviews.md Outdated
Comment threadgovernance/api-reviews.md
@alextp

alextp commented Apr 6, 2020 via email

Copy link
Copy Markdown
ContributorAuthor

Experimental APIs are APIs intended to be added to TensorFlow as-is, but which
we reserve the right to change in backwards-incompatible ways if we have
to.
to. This is different from apis in `tensorflow/addons`, many of which are not

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes it more clear - thanks!

@martinwicke
martinwicke merged commit 62e34f5 into tensorflow:masterApr 6, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@alextp@martinwicke@karmel@lc0@bhack@guptapriya@googlebot