Skip to content

Modify --plat-name for macosx wheels - #1311

Merged
yongtang merged 2 commits into
tensorflow:masterfrom
kvignesh1420:macos-version-fix
Feb 13, 2021
Merged

Modify --plat-name for macosx wheels#1311
yongtang merged 2 commits into
tensorflow:masterfrom
kvignesh1420:macos-version-fix

Conversation

@kvignesh1420

Copy link
Copy Markdown
Member

This PR updates the --plat-name from macosx_10_13_x86_64 to macosx_10_15_x86_64 while building the tfio wheel as per the github actions env.

@kvignesh1420kvignesh1420 changed the title Macos version fixModify --plat-name for macosx wheelsFeb 13, 2021
@yongtang

Copy link
Copy Markdown
Member

@kvignesh1420 While GitHub Actions have macos 10.15, we actually limit the macOS binary compatibility to 10.14 (used to be 10.13):
https://github.com/tensorflow/io/blob/master/tools/build/configure.py#L122-L123

In GitHub Actions we limit to 10.13 in the past to allow the binaries we built could run on lower versions of macOS (not just 10.15).

If we want to change the --plat-name, maybe we can change to 10.14 instead (and drop the 10.13 support)?

@kvignesh1420

Copy link
Copy Markdown
MemberAuthor

@yongtang yes sure, made the change.

@yongtang
yongtang merged commit a59fac2 into tensorflow:masterFeb 13, 2021
@kvignesh1420
kvignesh1420 deleted the macos-version-fix branch February 13, 2021 20:07
i-ony pushed a commit to i-ony/io that referenced this pull request Mar 8, 2021
* modify --plat-name for macosx wheels
* switch to 10.14
michaelbanfield pushed a commit to michaelbanfield/io that referenced this pull request Mar 30, 2021
* modify --plat-name for macosx wheels
* switch to 10.14
zheolong pushed a commit to zheolong/io-1 that referenced this pull request Jul 24, 2025
* modify --plat-name for macosx wheels
* switch to 10.14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@kvignesh1420@yongtang