Skip to content

Update to use https for http file system test also registers https file system - #1357

Merged
yongtang merged 2 commits into
tensorflow:masterfrom
yongtang:https
Apr 11, 2021
Merged

Update to use https for http file system test also registers https file system#1357
yongtang merged 2 commits into
tensorflow:masterfrom
yongtang:https

Conversation

@yongtang

Copy link
Copy Markdown
Member

The http test is failing as apache switched to use https for license page.

This PR makes adjustment to fix the issue.

Signed-off-by: Yong Tang yong.tang.github@outlook.com

…le system
The http test is failing as apache switched to use https for license page.
This PR makes adjustment to fix the issue.
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

@kvignesh1420kvignesh1420 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vnghia

Copy link
Copy Markdown
Contributor

@yongtang Could you also change the example in README.md to https ? Thank you !

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
@yongtang

Copy link
Copy Markdown
MemberAuthor

@vnvo2409 The PR has been updated.

@vnghiavnghia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@yongtang
yongtang merged commit 52a8893 into tensorflow:masterApr 11, 2021
@yongtang
yongtang deleted the https branch April 11, 2021 04:36
yongtang added a commit to yongtang/io that referenced this pull request Apr 11, 2021
…le system (tensorflow#1357)
* Update to use https for http file system test also registers https file system
The http test is failing as apache switched to use https for license page.
This PR makes adjustment to fix the issue.
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
* Update README.md to use https
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
yongtang added a commit to yongtang/io that referenced this pull request Apr 11, 2021
…le system (tensorflow#1357)
* Update to use https for http file system test also registers https file system
The http test is failing as apache switched to use https for license page.
This PR makes adjustment to fix the issue.
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
* Update README.md to use https
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
yongtang added a commit to yongtang/io that referenced this pull request Apr 11, 2021
…le system (tensorflow#1357)
* Update to use https for http file system test also registers https file system
The http test is failing as apache switched to use https for license page.
This PR makes adjustment to fix the issue.
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
* Update README.md to use https
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
yongtang added a commit to yongtang/io that referenced this pull request Apr 11, 2021
…le system (tensorflow#1357)
* Update to use https for http file system test also registers https file system
The http test is failing as apache switched to use https for license page.
This PR makes adjustment to fix the issue.
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
* Update README.md to use https
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
yongtang added a commit that referenced this pull request Apr 12, 2021
* Bump to 0.17.1
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
* Fix incomplete row reading issue in parquet files
This PR tries to address the issue raised in 1254 where reading parquet
files will results in `InvalidArgumentError: null value in column`
The issue comes from the fact that parquet's ColumnReader C++ API
`ReadBatch(...)` does not necessarily respect the number of rows
requested and may return less instead.
This PR fixes 1254.
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
* Bump Apache Arrow to 2.0.0 (#1231)
* Bump Apache Arrow to 2.0.0
Also bumps Apache Thrift to 0.13.0
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
* Update code to match Arrow
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
* Bump pyarrow to 2.0.0
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
* Stay with version=1 for write_feather to pass tests
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
* Bump flatbuffers to 1.12.0
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
* Fix Windows issue
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
* Fix tests
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
* Fix Windows
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
* Remove -std=c++11 and leave default -std=c++14 for arrow build
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
* Update sha256 of libapr1
As the hash changed by the repo.
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
* Bump Apache Arrow to 3.0.0 (#1285)
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
* Patch arrow to temporarily resolve the ARROW-11518 issue
This PR patchs arrow to temporarily resolve the ARROW-11518 issue.
See 1281 for details
Credit to diggerk.
We will update arrow after the upstream PR is merged.
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
* Enable GitHub Actions on R0.17
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
* Update pulsar download link.
This PR updates pulsar download link as old link does not work anymore.
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
* Update to use https for http file system test also registers https file system (#1357)
* Update to use https for http file system test also registers https file system
The http test is failing as apache switched to use https for license page.
This PR makes adjustment to fix the issue.
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
* Update README.md to use https
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
zheolong pushed a commit to zheolong/io-1 that referenced this pull request Jul 24, 2025
…le system (tensorflow#1357)
* Update to use https for http file system test also registers https file system
The http test is failing as apache switched to use https for license page.
This PR makes adjustment to fix the issue.
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
* Update README.md to use https
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@yongtang@vnghia@terrytangyuan@kvignesh1420