Skip to content

[Type Refactor] Move type implementations and mappers to internal package - #172

Merged
karllessard merged 3 commits into
tensorflow:masterfrom
karllessard:type-refactor-mappers
Dec 18, 2020
Merged

[Type Refactor] Move type implementations and mappers to internal package#172
karllessard merged 3 commits into
tensorflow:masterfrom
karllessard:type-refactor-mappers

Conversation

@karllessard

@karllessardkarllessard commented Dec 18, 2020•
edited
Loading

Copy link
Copy Markdown
Collaborator

In this relatively-simple PR, I move the implementations of the typed tensors (TType) and their mapping method to the internal package as separate objects.

While the reason for doing it might seem unclear at this point, it will make more sense in the next PR where the *Mapper class could be referenced from a new @TensorType annotation. In addition, segregating the implementation classes from their respective interfaces is more scalable for when we'll start supporting different categories of tensors, like sparse and ragged.

Note that these changes has no impact on the user API and is completely backward compatible.

CC\ @deansher

Craigacp
Craigacp requested changes Dec 18, 2020
View reviewed changes

@CraigacpCraigacp left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments.

Comment threadtensorflow-core/tensorflow-core-api/src/main/java/org/tensorflow/TensorMapper.java
Comment thread...low-core/tensorflow-core-api/src/main/java/org/tensorflow/internal/buffer/ByteSequencer.java Outdated
Comment thread...ow-core/tensorflow-core-api/src/main/java/org/tensorflow/internal/types/TBfloat16Mapper.java Outdated
Comment thread...rflow-core/tensorflow-core-api/src/main/java/org/tensorflow/internal/types/TInt64Mapper.java Outdated
Comment thread...rflow-core/tensorflow-core-api/src/main/java/org/tensorflow/internal/types/TInt64Mapper.java Outdated
Comment threadtensorflow-core/tensorflow-core-api/src/main/java/org/tensorflow/types/TBfloat16.java
Comment threadtensorflow-core/tensorflow-core-api/src/main/java/org/tensorflow/types/TBool.java
Craigacp
Craigacp previously approved these changes Dec 18, 2020
View reviewed changes

@CraigacpCraigacp left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karllessardkarllessard changed the title [Type Refactor] Move type implementations and mappers to internal packageMove type implementations and mappers to internal packageDec 18, 2020
@karllessardkarllessard changed the title Move type implementations and mappers to internal package[Type Refactor] Move type implementations and mappers to internal packageDec 18, 2020
@karllessard
karllessard merged commit 04f9d0d into tensorflow:masterDec 18, 2020
@karllessard
karllessard deleted the type-refactor-mappers branch December 18, 2020 19:15
@karllessard

karllessard commented Dec 18, 2020

Copy link
Copy Markdown
CollaboratorAuthor

Thanks a lot @Craigacp for this quick review!

rnett pushed a commit to rnett/tensorflow-java that referenced this pull request Dec 28, 2020
@karllessard@rnett
Move type implementations and mappers to internal package (tensorflow…
8b14b1d
…#172)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CraigacpCraigacpCraigacp left review comments
+1 more reviewer
@saudetsaudetsaudet left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@karllessard@Craigacp@saudet