Skip to content

Add easy to use configuration scripts - #235

Open
rnett wants to merge 5 commits into
tensorflow:masterfrom
rnett:rn_configure
Open

Add easy to use configuration scripts#235
rnett wants to merge 5 commits into
tensorflow:masterfrom
rnett:rn_configure

Conversation

@rnett

@rnettrnett commented Mar 9, 2021

Copy link
Copy Markdown
Contributor

Adds bazel configuration scripts that download the tensorflow binary and call its configure scripts. The bazel info output_base use is because in some cases (such as switching OSs), the symlinks become corrupted and bazel doesn't generate new ones. The .bazelversion file is for bazelisk, since tensorflow doesn't support 4.0.0 yet.

Fixes#206

rnett added 3 commits March 8, 2021 21:43
Signed-off-by: Ryan Nett <rnett@calpoly.edu>
Signed-off-by: Ryan Nett <rnett@calpoly.edu>
Signed-off-by: Ryan Nett <rnett@calpoly.edu>
karllessard
karllessard previously approved these changes Mar 9, 2021

@karllessardkarllessard left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just left two small comments there but it's approved for merging

Comment threadtensorflow-core/tensorflow-core-api/build.sh Outdated
Comment threadtensorflow-core/tensorflow-core-api/configure Outdated
Signed-off-by: Ryan Nett <rnett@calpoly.edu>
@rnett

rnett commented Mar 9, 2021

Copy link
Copy Markdown
ContributorAuthor

Your approval got removed when I pushed changes, and I don't think I can override the CI.

Comment threadtensorflow-core/tensorflow-core-api/.bazelversion Outdated
Signed-off-by: Ryan Nett <JNett96@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

README should include an example of a build command with explicit component paths

3 participants

@rnett@Craigacp@karllessard