Uh oh!
There was an error while loading. Please reload this page.
Add pbtxt op converter - #305
Closed
rnett wants to merge 2 commits into
Closed
Conversation
Signed-off-by: Ryan Nett <JNett96@gmail.com>
karllessard
commented
Apr 28, 2021
Collaborator
Can't the C++ bazel job create both? |
rnett
commented
Apr 28, 2021
ContributorAuthor
Yeah, it can. I just had to write this up anyways to check #303. Don't merge this, I'll add it to the exporter. |
rnett
marked this pull request as draft
April 28, 2021 03:53
karllessard
commented
May 1, 2021
Collaborator
@rnett , closing this one now that the pbtxt is generated by the C++ generator |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a utility
mainto convert the exported ops to protobuf text, for diffing (i.e. #303).I'm very tempted to have the op exporter do this, it will cause op differences to show up in the git diffs (and doesn't increase the Jar size, since it's not included). Thoughts?