Uh oh!
There was an error while loading. Please reload this page.
Use spotless plugin for formating - #308
Conversation
Signed-off-by: Ryan Nett <JNett96@gmail.com>
Signed-off-by: Ryan Nett <JNett96@gmail.com>
Signed-off-by: Ryan Nett <JNett96@gmail.com>
karllessard
commented
May 21, 2021
I'm not convinced about reformatting source code with Maven, any reason why simply using Google Java Style formatting isn't enough? |
The XML differs a bit from the actual plugin, at least for me (things like line length and single line comments). Plus, it's easy to forget and have a bunch of improperly formatted files end up in the repo, like we have now. This doesn't actually do any formatting, it just checks it as part of the build, like the lint checks. |
karllessard
commented
May 23, 2021
@rnett I should have labeled that PR with CI build before merging... can you please check the multiple errors we are facing on many platforms from GitHub Actions? I might need |
rnett
commented
May 23, 2021
Ugh, it seems to be that |
rnett
commented
May 23, 2021
Do you or @Craigacp know if there's a way to have a version-dependent |
rnett
commented
May 23, 2021
See #324. |
Uses the spotless plugin for formatting. Will check formatting in the
initializephase (so its before codegen & native builds), and auto-format can be ran withmvn spotless:apply. We can use it for the Kotlin API as well once diffplug/spotless#142 is fixed.I have it set to ratchet from
master(i.e. only check changed files), do we want to do a big "apply formatting everywhere" PR (it's ~500 files)?