Uh oh!
There was an error while loading. Please reload this page.
Modify tensorflow-sys/src/lib.rs to be bindgen generated - #67
Conversation
Version of bindgen used: 0.22.1 Command used: bindgen --blacklist-type max_align_t /usr/include/tensorflow/c_api.h > src/bindgen.rs
Note that the enums values are rexported (`pub use TF_[...]::*`)
See discussions about libc: * rust-lang/rust#31536 * rust-lang/libc#180 * rust-lang/libc#547
googlebot
commented
Mar 8, 2017
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
nbigaouette-eai
commented
Mar 8, 2017
I signed it! |
googlebot
commented
Mar 8, 2017
CLAs look good, thanks! |
…ead of using `libc::c_void`
The CI failure is due to tensorflow failing to build and not this MR. See similar issues in the main tensorflow repository:
MR #65 could aleviate this problem by using a pre-built binary for tensoflow. This would help a lot! |
adamcrume
commented
Mar 10, 2017
Could you add a script for running bindgen? |
adamcrume
commented
Mar 11, 2017
Thanks! |
daschl
commented
Mar 15, 2017
I think this is a great middle ground between hand-generating the API and forcing couple of compile time dependencies on the user :) |
This MR gets rid of the hand-written
tensorflow-sys/src/lib.rsfile, and replaces it with two files:tensorflow-sys/src/bindgen.rsis the result ofbindgen --blacklist-type max_align_t /usr/include/tensorflow/c_api.h > tensorflow-sys/src/bindgen.rs;tensorflow-sys/src/lib.rssimplyinclude!()the generated wrapper, adding some#![allow(...)]and re-exporting the enum values.I've added the option
--blacklist-type max_align_tto bindgen so that the automatically generated unit tests don't fail:See rust-lang/rust-bindgen#550 for the bindgen issue about this unit test.
Should close issue #57.