Uh oh!
There was an error while loading. Please reload this page.
Exploring a baseline Action build - #48421
Conversation
As expected we had a Github Action timeout on the TensorFlow build step after Github Actions are currently running on a Standard_DS2_v2 machine. As we already know this is really a bottleneck for an average TF external (Episodic or not) contributor as we ask to reproduce these steps on its own local machine just for preparing an occasional code PR. I think that it is important to continuously monitor this Action over time to expect that we could execute it in the expected time that it seems to us reasonable for an Episodic/Average TF contributor. Some proposed solutions to enable this action in order of preference:
|
bhack
commented
Apr 13, 2021
Just in the case we want to explore the first option with the self hosted |
bhack
commented
Apr 13, 2021
There is also a Terraform Github Self Hosted Runners on GKE repo maintained by Google Cloud members (/cc @bharathkkb) at https://github.com/terraform-google-modules/terraform-google-github-actions-runners |
bhack
commented
Apr 14, 2021
/cc @perfinion If we can do some steps together on this. |
Update: We discussed a pilot plan with @perfinion yesterday on SIG-Build Gitter. |
vnghia
commented
Apr 15, 2021
I would add one more difficulty: Even with local cache, it seems to be invalidated each time I pull the commits from upstream. ( I think LLVM-related commits like 17e6dc2 are the culprits ). |
bhack
commented
Apr 15, 2021
What cache command are you using? |
I am using |
vnghia
commented
Apr 15, 2021
I found that in #40505 (comment), @mihaimaruseac said the same thing. Do you have any problem regarding this issue @bhack ? |
bhack
commented
Apr 15, 2021
We are waiting to have a bootstrapped GCS cache for this action produced with a fresh master build in |
bhack
commented
Apr 15, 2021
If the llvm sync will totally invalidate the remote bazel cache we cannot use Github Action but we need to use self hosted github Actions as suggested in #48421 (comment). |
gbaned
commented
Jun 25, 2021
@bhack This PR is in draft, any update on this? Please. Thanks! |
bhack
commented
Jun 25, 2021
@gbaned It is a draft cause as you can see the introduced action go in Timeout on Github. |
bhack
commented
Oct 14, 2021
Just for reference, it is going in timeout on this kind of HW resources: |
1b12917 to
3175de1Comparebhack
commented
Sep 27, 2022
Closing this for #57630 |
With this I want to explore a new testing baseline with Github Action and our official CPU
tensorflow/tensorflow:develimage.The idea is to test in the CI the (more or less) Episodic contributor journey to contribute code to Tensorflow at least on CPU.
This is the proposed list of steps:
tensorflow/tensorflow:develimage rebuid build (or Dockerhub pull?)ci_sanity.shselected steps (--pylint, -- see Supersed pylint_allowlist #48294)./configurebazel build --config=opt //tensorflow/tools/pip_package:build_pip_packagebazel test //tensorflow/As the average user it is already experiencing, this will probably require a bazel cache (on GCS like for TF/IO?) to achieve reasonable compilation times.
I think that reproducibility and the timing of these build steps will let us to monitor the experience of a Tensorflow episodic contribution.
/cc @angerson@mihaimaruseac@theadactyl@joanafilipa