Skip to content
This repository was archived by the owner on Feb 3, 2025. It is now read-only.

add_benchmark_mode - #21

Merged
pooyadavoodi merged 11 commits into
tensorflow:masterfrom
mdrozdowski1996:add_benchmark_mode
Feb 28, 2019
Merged

add_benchmark_mode#21
pooyadavoodi merged 11 commits into
tensorflow:masterfrom
mdrozdowski1996:add_benchmark_mode

Conversation

@mdrozdowski1996

@mdrozdowski1996mdrozdowski1996 commented Feb 5, 2019

Copy link
Copy Markdown
Contributor

No description provided.

pooyadavoodi
pooyadavoodi reviewed Feb 5, 2019
View reviewed changes
Comment threadtftrt/examples/image-classification/image_classification.py Outdated
pooyadavoodi
pooyadavoodi reviewed Feb 5, 2019
View reviewed changes
Comment threadtftrt/examples/image-classification/image_classification.py Outdated
pooyadavoodi
pooyadavoodi reviewed Feb 5, 2019
View reviewed changes
Comment threadtftrt/examples/image-classification/image_classification.py Outdated
pooyadavoodi
pooyadavoodi reviewed Feb 5, 2019
View reviewed changes
Comment threadtftrt/examples/image-classification/image_classification.py Outdated
pooyadavoodi
pooyadavoodi reviewed Feb 5, 2019
View reviewed changes
Comment threadtftrt/examples/image-classification/image_classification.py Outdated
pooyadavoodi
pooyadavoodi reviewed Feb 5, 2019
View reviewed changes
Comment threadtftrt/examples/image-classification/image_classification.py Outdated
pooyadavoodi
pooyadavoodi reviewed Feb 5, 2019
View reviewed changes
Comment threadtftrt/examples/image-classification/image_classification.py
pooyadavoodi
pooyadavoodi reviewed Feb 5, 2019
View reviewed changes
Comment threadtftrt/examples/image-classification/image_classification.py Outdated
pooyadavoodi
pooyadavoodi reviewed Feb 5, 2019
View reviewed changes
Comment threadtftrt/examples/image-classification/image_classification.py Outdated
pooyadavoodi
pooyadavoodi reviewed Feb 5, 2019
View reviewed changes
Comment threadtftrt/examples/image-classification/image_classification.py Outdated
pooyadavoodi
pooyadavoodi reviewed Feb 5, 2019
View reviewed changes
Comment threadtftrt/examples/image-classification/image_classification.py
pooyadavoodi
pooyadavoodi reviewed Feb 5, 2019
View reviewed changes
Comment threadtftrt/examples/image-classification/image_classification.py Outdated
pooyadavoodi
pooyadavoodi reviewed Feb 5, 2019
View reviewed changes
Comment threadtftrt/examples/image-classification/image_classification.py Outdated
@pooyadavoodi

pooyadavoodi commented Feb 5, 2019

Copy link
Copy Markdown

Please post an example of the log here after all the comments are resolved.

@mdrozdowski1996

mdrozdowski1996 commented Feb 6, 2019

Copy link
Copy Markdown
ContributorAuthor

output_tftrt_fp32_bs8_inception_v3_dynamic_op=False.txt

pooyadavoodi
pooyadavoodi reviewed Feb 12, 2019
View reviewed changes
Comment threadtftrt/examples/image-classification/image_classification.py Outdated
pooyadavoodi
pooyadavoodi reviewed Feb 12, 2019
View reviewed changes
Comment threadtftrt/examples/image-classification/image_classification.py Outdated
@pooyadavoodi

pooyadavoodi commented Feb 12, 2019

Copy link
Copy Markdown

Please resolve merge conflicts.
We just added another Hook that's used for benchmarking. It's called DurationHook.

Some parts of your PR would need to use DurationHook.

pooyadavoodi
pooyadavoodi reviewed Feb 12, 2019
View reviewed changes
Comment threadtftrt/examples/image-classification/image_classification.py
pooyadavoodi
pooyadavoodi reviewed Feb 12, 2019
View reviewed changes
Comment threadtftrt/examples/image-classification/image_classification.py Outdated
pooyadavoodi
pooyadavoodi reviewed Feb 12, 2019
View reviewed changes
Comment threadtftrt/examples/image-classification/image_classification.py Outdated
pooyadavoodi
pooyadavoodi reviewed Feb 12, 2019
View reviewed changes
Comment threadtftrt/examples/image-classification/image_classification.py Outdated
pooyadavoodi
pooyadavoodi reviewed Feb 12, 2019
View reviewed changes
Comment threadtftrt/examples/image-classification/image_classification.py Outdated
pooyadavoodi
pooyadavoodi reviewed Feb 12, 2019
View reviewed changes
Comment threadtftrt/examples/image-classification/image_classification.py Outdated
pooyadavoodi
pooyadavoodi reviewed Feb 12, 2019
View reviewed changes
Comment threadtftrt/examples/image-classification/image_classification.py Outdated
pooyadavoodi
pooyadavoodi reviewed Feb 12, 2019
View reviewed changes
Comment threadtftrt/examples/image-classification/image_classification.py Outdated
pooyadavoodi
pooyadavoodi reviewed Feb 25, 2019
View reviewed changes
Comment threadtftrt/examples/image-classification/image_classification.py
pooyadavoodi
pooyadavoodi reviewed Feb 25, 2019
View reviewed changes
Comment threadtftrt/examples/image-classification/image_classification.py Outdated
pooyadavoodi
pooyadavoodi reviewed Feb 25, 2019
View reviewed changes
Comment threadtftrt/examples/image-classification/image_classification.py Outdated
pooyadavoodi
pooyadavoodi reviewed Feb 25, 2019
View reviewed changes
Comment threadtftrt/examples/image-classification/image_classification.py Outdated
pooyadavoodi
pooyadavoodi reviewed Feb 25, 2019
View reviewed changes
Comment threadtftrt/examples/image-classification/image_classification.py Outdated
pooyadavoodi
pooyadavoodi reviewed Feb 25, 2019
View reviewed changes
Comment threadtftrt/examples/image-classification/image_classification.py Outdated
pooyadavoodi
pooyadavoodi reviewed Feb 25, 2019
View reviewed changes
Comment threadtftrt/examples/image-classification/image_classification.py Outdated
pooyadavoodi
pooyadavoodi reviewed Feb 25, 2019
View reviewed changes
Comment threadtftrt/examples/image-classification/image_classification.py Outdated
pooyadavoodi
pooyadavoodi reviewed Feb 25, 2019
View reviewed changes
Comment threadtftrt/examples/image-classification/image_classification.py Outdated
pooyadavoodi
pooyadavoodi reviewed Feb 25, 2019
View reviewed changes
Comment threadtftrt/examples/image-classification/image_classification.py Outdated
pooyadavoodi
pooyadavoodi reviewed Feb 25, 2019
View reviewed changes
Comment threadtftrt/examples/image-classification/image_classification.py Outdated
pooyadavoodi
pooyadavoodi reviewed Feb 25, 2019
View reviewed changes
Comment threadtftrt/examples/image-classification/image_classification.py Outdated
pooyadavoodi
pooyadavoodi reviewed Feb 25, 2019
View reviewed changes
Comment threadtftrt/examples/image-classification/image_classification.py Outdated
pooyadavoodi
pooyadavoodi reviewed Feb 26, 2019
View reviewed changes
Comment threadtftrt/examples/image-classification/image_classification.py Outdated
@pooyadavoodi
pooyadavoodi merged commit ee7f173 into tensorflow:masterFeb 28, 2019
DEKHTIARJonathan pushed a commit that referenced this pull request Nov 19, 2021
mdrozdowski1996Pooya Davoodi
add_benchmark_mode (#21)
bbde059
* add_benchmark_mode
* refactor_changes
* fix infinity loop using synthetic mode
* convert duration_hooks into benchmark_hooks
* change target_duration and iteration_limit for the optional paramteters
* refactor code
* update comment
* update error message
* remove space
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@pooyadavoodipooyadavoodipooyadavoodi left review comments
@trevor-mtrevor-mtrevor-m left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mdrozdowski1996@pooyadavoodi@trevor-m