Skip to content
This repository was archived by the owner on Feb 3, 2025. It is now read-only.

TF-TRT C++ conversion example - #271

Merged
DEKHTIARJonathan merged 2 commits into
tensorflow:masterfrom
tfeher:cpp_conversion_example
Jun 28, 2022
Merged

TF-TRT C++ conversion example#271
DEKHTIARJonathan merged 2 commits into
tensorflow:masterfrom
tfeher:cpp_conversion_example

Conversation

@tfeher

@tfehertfeher commented Sep 22, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

C++ conversion example to illustrate conversion using dynamic shape mode.

This PR depends on tensorflow/tensorflow#52012

@tfehertfeher mentioned this pull request Sep 22, 2021
Merged
@tfeher
tfeherforce-pushed the cpp_conversion_example branch from 5cbb42d to c50c2bdCompareSeptember 26, 2021 23:46
@tfeher
tfeher marked this pull request as ready for review September 26, 2021 23:47
@christopherbate

christopherbate commented Sep 27, 2021

Copy link
Copy Markdown

I think we're trying to follow convention of labeling PR titles with the tag [TF:TRT]

christopherbate
christopherbate suggested changes Sep 27, 2021
View reviewed changes

@christopherbatechristopherbate left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly build system / scripts and instructions need to be updated for final version, other things are minor.

Comment threadtftrt/examples/cpp/image-classification/CMakeLists.txt
Comment threadtftrt/examples/cpp/image-classification/README.md Outdated
Comment threadtftrt/examples/cpp/image-classification/README.md Outdated
Comment threadtftrt/examples/cpp/image-classification/README.md Outdated
Comment threadtftrt/examples/cpp/image-classification/README.md
cd tensorrt/tftrt/examples/cpp/image-classification
mkdir build
cd build
cmake ..

@christopherbatechristopherbateSep 27, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update to include -D... when CMakeLists is finalized

@tfehertfeherOct 19, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of the these, do we want to add hints for TF_SOURCE_DIR / TF_INSTALL_DIR?

Comment threadtftrt/examples/cpp/image-classification/main.cc Outdated
Comment threadtftrt/examples/cpp/image-classification/main.cc Outdated
Comment threadtftrt/examples/cpp/image-classification/main.cc Outdated
Comment threadtftrt/examples/cpp/image-classification/main.cc Outdated
Comment threadtftrt/examples/cpp/image-classification/main.cc
@DEKHTIARJonathan
DEKHTIARJonathanforce-pushed the master branch 5 times, most recently from 94c43ee to 114ebe1CompareOctober 20, 2021 00:33
@tfeher
tfeherforce-pushed the cpp_conversion_example branch from c50c2bd to 08a055cCompareOctober 20, 2021 14:51
tfeher
tfeher commented Oct 20, 2021
View reviewed changes

@tfehertfeher left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @christopherbate for the review, I have addressed the issues.

Comment threadtftrt/examples/cpp/image-classification/README.md Outdated
Comment threadtftrt/examples/cpp/image-classification/README.md Outdated
Comment threadtftrt/examples/cpp/image-classification/README.md Outdated
Comment threadtftrt/examples/cpp/image-classification/main.cc Outdated
Comment threadtftrt/examples/cpp/image-classification/main.cc
Comment threadtftrt/examples/cpp/image-classification/mnist.cc Outdated
Comment threadtftrt/examples/cpp/image-classification/mnist.h Outdated
Comment threadtftrt/examples/cpp/image-classification/mnist.h Outdated
Comment threadtftrt/examples/cpp/image-classification/mnist.cc
Comment threadtftrt/examples/cpp/image-classification/main.cc Outdated
@tfeher

tfeher commented Oct 20, 2021

Copy link
Copy Markdown
ContributorAuthor

To compile the example, one needs PR tensorflow/tensorflow#52595

@tfeher
tfeherforce-pushed the cpp_conversion_example branch from 08a055c to 81910f9CompareNovember 8, 2021 11:39
@tfeher
tfeherforce-pushed the cpp_conversion_example branch from 81910f9 to fb0a2cfCompareDecember 3, 2021 22:06
@tfehertfeher mentioned this pull request Jan 17, 2022
Draft
2 tasks
@DEKHTIARJonathan
DEKHTIARJonathanforce-pushed the master branch 4 times, most recently from dd03467 to 653ea0aCompareMarch 11, 2022 20:52
@DEKHTIARJonathan
DEKHTIARJonathanforce-pushed the master branch 3 times, most recently from cf30938 to 8d2c59fCompareApril 7, 2022 01:06
@DEKHTIARJonathan
DEKHTIARJonathanforce-pushed the master branch 2 times, most recently from 27ef7b8 to 535c132CompareMay 10, 2022 21:42
@DEKHTIARJonathan

DEKHTIARJonathan commented Jun 13, 2022

Copy link
Copy Markdown
Contributor

@meena-at-work: for review

meena-at-work
meena-at-work approved these changes Jun 17, 2022
View reviewed changes

@meena-at-workmeena-at-work left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DEKHTIARJonathan
DEKHTIARJonathan merged commit acef51e into tensorflow:masterJun 28, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@christopherbatechristopherbatechristopherbate requested changes
@meena-at-workmeena-at-workmeena-at-work approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tfeher@christopherbate@DEKHTIARJonathan@meena-at-work