fix: disambiguate duplicate Verso labels in Section 5.4 - #640
fix: disambiguate duplicate Verso labels in Section 5.4#640Chessing234 wants to merge 2 commits into
Conversation
teorth
commented
Aug 11, 2026
Almost all of this is good — the descriptive qualifiers on Definition 5.4.1 The one hunk to change is Proposition 5.4.4, which this labels
So (a)/(b)/(c) label the three alternatives of the trichotomy, not three separate results — and there is no (d)–(g) at all. Under this PR, Descriptive qualifiers of the kind you already use elsewhere in this very PR would fit well, e.g. Any equivalent wording is fine — the point is just not to reuse (a)/(b)/(c) for a different decomposition. Worth flagging that #616 has the same issue elsewhere in this file: it labels Exercise 5.4.9 For reference, #639 is the model — it keeps the book’s real letters for Proposition 4.3.3(a)/(c)/(d)/(e)/(g) and adds descriptive qualifiers only to separate declarations sharing a letter. I merged that one, along with 14 others today. |
Proposition 5.4.4 alone had seven declarations under one label, so the rendered book repeats the same heading seven times. Letter the unlettered clusters (Examples 5.4.2, Proposition 5.4.4) and add a short descriptor where the text already supplies a letter (Definitions 5.4.1/5.4.5/5.4.6, Proposition 5.4.7(a) and (e)). Signed-off-by: Taksh <takshkothari09@gmail.com>
The book's (a)/(b)/(c) on Prop 5.4.4 are the trichotomy alternatives, not seven separate results, and Ex 5.4.9 is numbered (i)-(iv). Fold in descriptive Examples 5.4.2 parentheticals while touching the same file.
37a5837 to
0627332CompareChessing234
commented
Aug 25, 2026
done — prop 5.4.4 now uses the descriptive trichotomy/negation/sum/product labels, and 5.4.9 is (i)–(iv) with descriptors so it matches the book's roman parts. examples 5.4.2 got the same treatment (the text doesn't number those either). |
proposition 5.4.4 alone had seven declarations sharing one docstring label, so the rendered book repeats the same heading seven times in a row.
lettered the clusters the text leaves unlettered (examples 5.4.2, proposition 5.4.4) and added a short descriptor where the text already supplies a letter (definitions 5.4.1 / 5.4.5 / 5.4.6, proposition 5.4.7(a) and (e)).
comment-only, no statements or proofs touched.
Generated by Claude Code