fix: disambiguate duplicate Verso labels in Section 5.3 - #652
fix: disambiguate duplicate Verso labels in Section 5.3#652Chessing234 wants to merge 2 commits into
Conversation
Fifteen docstrings across five groups shared a label: Proposition 5.3.3, Definition 5.3.1, Definition 5.3.4, Proposition 5.3.11 and Examples 5.3.13. The definitions and propositions fold the part into the parenthetical; the five examples take part letters, as in Examples 5.2.2.
teorth
commented
Aug 23, 2026
Thanks — most of this is exactly right, and I've merged the sibling PRs (#651, #653, #655, #656, #657, #659, #660, #661) that use the same descriptive style. One change here I'd like adjusted before merging. The
So there are no parts (a)–(e) to refer to; adding them makes the docstring claim a structure the book doesn't have, and a reader who goes looking for "Examples 5.3.13(c)" won't find it. Could you use the same descriptive parentheticals you've used everywhere else in this PR? Something like:
Everything else in the PR is good to go as-is. |
The book's Examples 5.3.13 is a single prose paragraph with no enumerated parts, so (a)-(e) claimed a structure the text does not have. Replace them with the descriptive parentheticals used for the other labels in this PR.
Done in 0248c0d — the five |
Section 5.3 has five groups of declarations sharing one docstring:
Proposition 5.3.3 / Exercise 5.3.1— 2Definition 5.3.1 (Real numbers)— 2Definition 5.3.4 (Addition of reals)— 2Proposition 5.3.11 (laws of algebra)— 4 instancesExamples 5.3.13— 5 examplesDefinitions and propositions fold the part into the parenthetical (as in #624); the five examples take part letters (as in #634 for Examples 5.2.2). Docstrings only.
Checked: no duplicate one-line docstrings remain in the file, all edited lines within 100 characters.
lake build Analysis.Section_5_3succeeds locally —✔ [3268/3268] Built Analysis.Section_5_3 (103s),Build completed successfully.