Fix Test Github Action pipeline - #88
Open
siarhei-luskanau wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes the failing Test GitHub Action pipeline for generated Compose Multiplatform projects.
Web targets (
js/wasmJs)It is necessary to add
binaries.executable()to thejsandwasmJsconfigurationsin order to successfully pass tests for web targets.
iOS tests on CI
The simulator device filter in
GeneratedComposeAppProjectTestis relaxed from the exact"iphone 15"/"iphone 14"names to the"iphone 1"prefix, so the test picks up anyavailable iPhone 1x simulator on the CI runner image and no longer breaks when runner
images ship with a newer simulator set.
Testing
Verified via the GitHub Actions Test workflow — generated projects for JS, Wasm,
and iOS targets now build successfully.