Add cockroach db support by tolkonepiu · Pull Request #499 · testcontainers/testcontainers-java

tolkonepiu · 2017-11-19T14:08:55Z

kiview · 2017-11-28T23:17:45Z

Hi @tolkonepiu, thanks for the PR. I think our current approach advises to add such functionality as a module in a seperate repo.

@rnorth We still encourage extra module repos, do we?

kiview · 2017-12-09T10:45:49Z

Please ignore my last point, we'll include small modules in core for now 😃

kiview

Can you please also add a test for CockroachContainer? Or am I missing something and it's tested implicitly?

rnorth · 2018-02-11T15:39:47Z

We're shortly going to be merging #574, which changes our build system to Gradle. This is in part intended to make contributions of modules easier (per #564), but unfortunately means that for a short while your PR is going to show merge conflicts with the master branch.

I just want to let you know we don't want to create new work for you: we'll take care of the merge conflicts shortly. Please don't worry - we're grateful for your PR and want to help integrate it soon. Thank you.

rnorth · 2018-02-25T20:48:20Z

@tolkonepiu I've locally made changes to bring this into the new Gradle-based build, as we'd love to merge this soon.

Could you perhaps allow us to push to your fork so that I can make the necessary changes? This page describes the steps: https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/

Thank you in advance!

stale · 2019-01-07T02:51:46Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

rnorth · 2019-01-08T08:07:38Z

We should keep this open.

_{Sent with GitHawk}

kiview · 2019-01-08T19:45:45Z

@tolkonepiu Sorry for keeping thins dangling so long.
@rnorth I've fixed the merge conflicts, I think it's good to go?

bsideup · 2019-01-08T19:52:11Z

@kiview let's drop the self typing

rnorth · 2019-05-27T19:40:53Z

I'll take on @bsideup's comment.

Use an appropriate default test database (see cockroachdb/cockroach#19826 (comment))

rnorth · 2019-05-28T08:29:33Z

FWIW I've raised this ticket around the current gap in our docs for new module contributors. I'd like to have a bit of a think about the third point specifically before merging this, but otherwise I'm fine with this new module at an overall level: #1503

stale · 2019-08-26T08:37:27Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

rnorth · 2019-08-26T15:35:02Z

Not stale - reopening.

reinierbos · 2019-09-20T08:10:59Z

Any idea when this PR will be merged to master (and then released)? I would love to start using it!

Rename module to `cockroachdb`

Dismissing stale review

bsideup · 2019-10-01T20:59:41Z

+ super(dockerImageName);
+
+ withExposedPorts(REST_API_PORT, DB_PORT);
+ withEnv("COCKROACH_USER", username);


Should go to "configure" method

Done (disabling these settings, since they don't work!)

Since there is no current way to make them do what we want

Add cockroach db support
246a82b

glebsts reviewed Nov 22, 2017
View reviewed changes

Comment threadmodules/cockroach/src/main/java/org/testcontainers/containers/CockroachContainer.java Outdated

kiview previously requested changes Dec 10, 2017
View reviewed changes

kiview added the enhancement label Dec 10, 2017

bsideup added the type/new module label Feb 11, 2018

tolkonepiu added 4 commits February 26, 2018 17:06

Merge branch 'master' into cockroach
ff1e673

Add cockroach dep in jdbc-test
33a0ece

Review fixes
1ec9fed

Remove unused imports
1babef3

bsideup removed the type/enhancement label Mar 15, 2018

staleBot added the stale label Jan 7, 2019

Merge branch 'master' into cockroach
e5bb1ed

kiview requested a review from bsideup as a code owner January 8, 2019 19:44

staleBot removed stale labels Jan 8, 2019

bsideup reviewed Jan 8, 2019
View reviewed changes

Comment threadmodules/cockroach/src/main/java/org/testcontainers/containers/CockroachContainer.java Outdated

bsideup reviewed Jan 8, 2019
View reviewed changes

Comment threadmodules/cockroach/src/main/java/org/testcontainers/containers/CockroachContainer.java Outdated

bsideup reviewed Jan 8, 2019
View reviewed changes

Comment threadmodules/cockroach/src/main/java/org/testcontainers/containers/CockroachContainer.java Outdated

testcontainers deleted a comment Jan 11, 2019

tolkonepiu added 2 commits February 10, 2019 04:55

Another review fixes
246f1e3

Merge branch 'master' into cockroach
74b8ddc

Merge branch 'master' into cockroach
aa7d63c

rnorth self-assigned this May 27, 2019

rnorthand others added 5 commits May 27, 2019 20:56

Merge branch 'master' into cockroach
9070c1f

Remove redundant test dependencies (tests are in jdbc-test)
9967066

Move container configuration to constructor
4fa1900

Add simple JUnit test for CockroachDB
be73c91
Use an appropriate default test database (see cockroachdb/cockroach#19826 (comment))

Disable noisy JUL logs from Postgres Driver
b408f53

rnorth requested review from bsideup and kiview May 27, 2019 20:41

bsideup approved these changes May 28, 2019
View reviewed changes

Merge branch 'master' into cockroach
a335db5

staleBot added the stale label Aug 26, 2019

staleBot removed the stale label Aug 26, 2019

rnorth added 3 commits September 23, 2019 21:31

Merge branch 'master' into cockroach
f633218

Merge branch 'master' into cockroach
f4260e1

Add minimal docs for CockroachDB module
dbe6069
Rename module to `cockroachdb`

rnorth approved these changes Sep 29, 2019
View reviewed changes

rnorth added this to the next milestone Oct 1, 2019

bsideup requested changes Oct 1, 2019
View reviewed changes

Disable use of withUsername/withPassword/withDatabaseName methods
17a7728
Since there is no current way to make them do what we want

rnorth requested a review from bsideup October 3, 2019 13:07

bsideup approved these changes Oct 3, 2019
View reviewed changes

rnorth merged commit 15140c5 into testcontainers:masterOct 3, 2019

vpavic mentioned this pull request Oct 3, 2019
CockroackDB - retry txn (RETRY_WRITE_TOO_OLD) spring-projects/spring-session#1494
Closed

Uh oh!

Uh oh!

Conversation

tolkonepiu commented Nov 19, 2017

Uh oh!

Uh oh!

kiview commented Nov 28, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kiview commented Dec 9, 2017

Uh oh!

kiview left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rnorth commented Feb 11, 2018

Uh oh!

rnorth commented Feb 25, 2018

Uh oh!

staleBot commented Jan 7, 2019

Uh oh!

rnorth commented Jan 8, 2019

Uh oh!

kiview commented Jan 8, 2019

Uh oh!

bsideup commented Jan 8, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rnorth commented May 27, 2019

Uh oh!

rnorth commented May 28, 2019

Uh oh!

staleBot commented Aug 26, 2019

Uh oh!

rnorth commented Aug 26, 2019

Uh oh!

reinierbos commented Sep 20, 2019

Uh oh!

bsideupOct 1, 2019

Choose a reason for hiding this comment

Uh oh!

rnorthOct 3, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

kiview commented Nov 28, 2017•
edited
Loading

rnorthOct 3, 2019•
edited
Loading