Skip to content

Add documentation to reusable containers - #6216

Merged
eddumelendez merged 12 commits into
mainfrom
reuse_docs
Nov 17, 2022
Merged

Add documentation to reusable containers#6216
eddumelendez merged 12 commits into
mainfrom
reuse_docs

Conversation

@eddumelendez

@eddumelendezeddumelendez commented Nov 16, 2022

Copy link
Copy Markdown
Member

Reusable containers is an experimental features and docs should
address questions around what is it? and how to enable it?

@eddumelendez
Add documentation to reusable containers
4d87f0a
Reusable containers is an experimental features and docs should
address questions around `what is it?` and `how to enable it?`
@eddumelendez
eddumelendez requested a review from a teamNovember 16, 2022 19:33
bsideup
bsideup reviewed Nov 17, 2022
View reviewed changes
Comment threaddocs/features/reuse.md Outdated
bsideup
bsideup reviewed Nov 17, 2022
View reviewed changes
Comment threaddocs/features/reuse.md Outdated
bsideup
bsideup reviewed Nov 17, 2022
View reviewed changes
Comment threaddocs/features/reuse.md Outdated
bsideup
bsideup reviewed Nov 17, 2022
View reviewed changes
Comment threaddocs/features/reuse.md Outdated
eddumelendezand others added 3 commits November 16, 2022 16:51
@eddumelendez@bsideup
Update docs/features/reuse.md
6b98a3a
Co-authored-by: Sergei Egorov <bsideup@gmail.com>
@eddumelendez@bsideup
Update docs/features/reuse.md
662bc72
Co-authored-by: Sergei Egorov <bsideup@gmail.com>
@eddumelendez
Add TC JDBC URL example
c8e0267
@eddumelendezeddumelendez added this to the next milestone Nov 17, 2022
bsideup
bsideup reviewed Nov 17, 2022
View reviewed changes
Comment threaddocs/features/reuse.md Outdated
Comment threaddocs/features/reuse.md Outdated
Comment threaddocs/features/reuse.md Outdated
eddumelendezand others added 2 commits November 16, 2022 17:17
@eddumelendez@bsideup
Update docs/features/reuse.md
1504288
Co-authored-by: Sergei Egorov <bsideup@gmail.com>
@eddumelendez
Apply comments
3a67629
kiview
kiview previously approved these changes Nov 17, 2022
View reviewed changes

@kiviewkiview left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See suggestions, happy to finally include in in our docs 🙂

Comment threaddocs/features/reuse.md
* Define container with `withReuse(true)`

```java
GenericContainer container = new GenericContainer("redis:6-alpine")

@kiviewkiviewNov 17, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we have a code include, but I think for such a small snippet, it is fine 😉

Comment threaddocs/features/reuse.md Outdated
Comment threaddocs/features/reuse.md Outdated
Comment threaddocs/features/reuse.md Outdated
Comment threaddocs/features/reuse.md Outdated
Comment threaddocs/features/reuse.md Outdated
Comment threaddocs/features/reuse.md Outdated
@eddumelendez@kiview
Update docs/features/reuse.md
b960e71
Co-authored-by: Kevin Wittek <kiview@users.noreply.github.com>
eddumelendezand others added 5 commits November 17, 2022 05:49
@eddumelendez@kiview
Update docs/features/reuse.md
2b8b3c1
Co-authored-by: Kevin Wittek <kiview@users.noreply.github.com>
@eddumelendez@kiview
Update docs/features/reuse.md
5b36363
Co-authored-by: Kevin Wittek <kiview@users.noreply.github.com>
@eddumelendez@kiview
Update docs/features/reuse.md
6e4bb62
Co-authored-by: Kevin Wittek <kiview@users.noreply.github.com>
@eddumelendez@kiview
Update docs/features/reuse.md
8182b0e
Co-authored-by: Kevin Wittek <kiview@users.noreply.github.com>
@eddumelendez@kiview
Update docs/features/reuse.md
9e841b5
Co-authored-by: Kevin Wittek <kiview@users.noreply.github.com>
@eddumelendez
eddumelendez merged commit b48a0fd into mainNov 17, 2022
@eddumelendez
eddumelendez deleted the reuse_docs branch November 17, 2022 14:39
@ghaiszaherghaiszaher mentioned this pull request Sep 25, 2023
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bsideupbsideupbsideup left review comments
@kiviewkiviewkiview left review comments

Assignees

No one assigned

Labels

type/docs

Projects

None yet

Milestone

1.18.0

Development

Successfully merging this pull request may close these issues.

3 participants

@eddumelendez@bsideup@kiview