Uh oh!
There was an error while loading. Please reload this page.
Conversation
…tCluster() method, remove excess exception usage
Implement Cassandra support
kiview
reviewed
Jul 10, 2018
| return getCluster(this); | ||
| } | ||
| public static Cluster getCluster(ContainerState containerState) { |
Member
There was a problem hiding this comment.
Why does this method need to be public?
MemberAuthor
There was a problem hiding this comment.
because the argument is ContainerState and not GenericContainer
| @Override | ||
| protected Session createNewConnection() { | ||
| try { | ||
| return CassandraContainer.getCluster(container) |
Member
There was a problem hiding this comment.
Same question as above, why not calling getCluster() on the container?
kiview
commented
Jul 10, 2018
Member
LGTM apart from this minor questions. |
kiview
approved these changes
Jul 10, 2018
bsideup
commented
Jul 10, 2018
MemberAuthor
Finally merged :D Thanks @AnkBurov for your contribution! |
AnkBurov
commented
Jul 10, 2018
Contributor
Nice! Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseeds #525 by @AnkBurov