Uh oh!
There was an error while loading. Please reload this page.
Add ClickHouse module - #846
Merged
Merged
Conversation
Closed
bsideup
reviewed
Sep 5, 2018
| import java.time.Duration; | ||
| public class ClickHouseContainer<SELF extends ClickHouseContainer<SELF>> extends JdbcDatabaseContainer<SELF> { |
Member
There was a problem hiding this comment.
there is no need for self-typing here
ContributorAuthor
There was a problem hiding this comment.
I don't get it. Almost all other JDBC containers have 'SELF', why this one shouldn't?
bsideup
approved these changes
Sep 6, 2018
bsideup
commented
Sep 6, 2018
Member
@VladRassokhin@tolkonepiu merged, thanks! |
rnorth
commented
Sep 10, 2018
Member
We have this out in a Release Candidate build (1.9.0-rc1) for anyone who is keen to try it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase of #498 onto master with additional changes