Fix duct-tape:1.0.8 Zombie thread

[dadoonet]

This is a naive implementation for the bug described in #9227.

I basically moved the code from https://github.com/rnorth/duct-tape/ to org.testcontainers.utility.ducttape TC new package. And I removed the dependency on the duct-tape jar.
Then I added a method Timeouts.shutdown() which basically calls the shutdown() method on the Thread.
Finally, when we stop a container, I'm calling this Timeouts.shutdown().

This should close the remaining thread.

Let me know what you think and if I should continue on this path or not.

Thanks!

[austince]

@dadoonet@eddumelendez , sorry for the ping -- is there any help that we could give to get this one merged?

I offer a genuine-human-spotted-and-crafted-bug-fix as initial offering testcontainers/testcontainers-site#252

[dadoonet]

I rebased all the work done by @rnorth and myself on main so I have a better view of what was added.

But, when running ./gradlew :testcontainers:check, it's failing with:

❯ ./gradlew :testcontainers:check
Configuration on demand is an incubating feature.
> Task :testcontainers:japicmp FAILED
> Task :testcontainers:delombok
warning: unknown enum constant org.immutables.value.Value.Style.ImplementationVisibility.PACKAGE
reason: class file for org.immutables.value.Value$Style$ImplementationVisibility not found
/Users/david/IdeaProjects/3rdparty/testcontainers-java/core/src/main/java/org/testcontainers/images/AgeBasedPullPolicy.java:14: warning: Generating equals/hashCode implementation but without a call to superclass, even though this class does not extend java.lang.Object. If this is intentional, add '@EqualsAndHashCode(callSuper=false)' to your type.
@Value
^
warning: unknown enum constant org.immutables.value.Value.Style.ImplementationVisibility.PACKAGE
reason: class file for org.immutables.value.Value$Style$ImplementationVisibility not found
warning: unknown enum constant org.immutables.value.Value.Style.ImplementationVisibility.PACKAGE
reason: class file for org.immutables.value.Value$Style$ImplementationVisibility not found
warning: unknown enum constant org.immutables.value.Value.Style.ImplementationVisibility.PACKAGE
reason: class file for org.immutables.value.Value$Style$ImplementationVisibility not found
warning: unknown enum constant org.immutables.value.Value.Style.ImplementationVisibility.PACKAGE
reason: class file for org.immutables.value.Value$Style$ImplementationVisibility not found
> Task :testcontainers:checkstyleMain FAILED
[ant:checkstyle] [ERROR] /Users/david/IdeaProjects/3rdparty/testcontainers-java/core/src/main/java/org/testcontainers/containers/wait/strategy/HttpWaitStrategy.java:37:62: L'utilisation des imports statiques est prohibé - org.testcontainers.utility.ducttape.Unreliables.retryUntilSuccess [AvoidStaticImport][ant:checkstyle] [ERROR] /Users/david/IdeaProjects/3rdparty/testcontainers-java/core/src/main/java/org/testcontainers/utility/ducttape/Unreliables.java:10:64: L'utilisation des imports statiques est prohibé - org.testcontainers.utility.ducttape.Preconditions.check [AvoidStaticImport]
[ant:checkstyle] [ERROR] /Users/david/IdeaProjects/3rdparty/testcontainers-java/core/src/main/java/org/testcontainers/utility/ducttape/RateLimiterBuilder.java:5:64: L'utilisation des imports statiques est prohibé - org.testcontainers.utility.ducttape.Preconditions.check [AvoidStaticImport][ant:checkstyle] [ERROR] /Users/david/IdeaProjects/3rdparty/testcontainers-java/core/src/main/java/org/testcontainers/utility/ducttape/RateLimiterBuilder.java:14:5: 'VARIABLE_DEF' doit être séparé de la ligne précédente. [EmptyLineSeparator][ant:checkstyle] [ERROR] /Users/david/IdeaProjects/3rdparty/testcontainers-java/core/src/main/java/org/testcontainers/utility/ducttape/RateLimiterBuilder.java:15:5: 'VARIABLE_DEF' doit être séparé de la ligne précédente. [EmptyLineSeparator][ant:checkstyle] [ERROR] /Users/david/IdeaProjects/3rdparty/testcontainers-java/core/src/main/java/org/testcontainers/utility/ducttape/Timeouts.java:3:28: L'utilisation des import.* est prohibé - java.util.concurrent.*. [AvoidStarImport]
[Incubating] Problems report is available at: file:///Users/david/IdeaProjects/3rdparty/testcontainers-java/build/reports/problems/problems-report.html
FAILURE: Build completed with 2 failures.
1: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':testcontainers:japicmp'.
> A failure occurred while executing me.champeau.gradle.japicmp.JApiCmpWorkAction
> Detected binary changes.
- current: testcontainers.jar
- baseline: testcontainers-2.0.2.jar.
See failure report at file:///Users/david/IdeaProjects/3rdparty/testcontainers-java/core/build/reports/japi.html

I can work on this but I think it's unrelated to the current PR. Should I?

[rnorth]

@dadoonet I'll have a quick look now

[rnorth]

OK, based on the japicmp report it's due to the removal of
org.testcontainers.containers.wait.strategy.AbstractWaitStrategy's withRateLimiter(org.rnorth.ducttape.ratelimits.RateLimiter) public method and change of the return type of getRateLimiter() (which is a protected method).

It's correctly flagging that this is a (probably very low impact) breaking change. I'm guessing we want to avoid a major version increment just for this, but perhaps it might be tolerable in a minor release?
@eddumelendez@kiview what do you think?

[eddumelendez]

Hi, sorry for the late reply. But, my main issue with merging the PR is maintaining another domain under Testcontainers source code. That's why in the past I suggested to move to another library.