fix(core): make config editable to avoid monkeypatching.1

[alexanderankin]

see #531

[alexanderankin]

ok, i checked against #519 and shouldnt be too hard to rebase (if even necessary), unfortunately re #525 and #527 - 527 is a draft and 525 is a feat, which deprioritizes over things which can be considered fixes - unless the changes are inspired by tc-go or tc-java or other sources of truth on how to deal with things like mssql, may even be "breaking" even though they are "fixing" - i unfortunately have a lot of pent up sympathy for people doing unusual software things. nothing against the PR, we will figure it out and hopefully release it as a fix rather than a feat)

so with that said, not sure why i shouldnt merge this

[CarliJoy]

Dear, @alexanderankin

Imports like

fromtestcontainers.core.configimporttestcontainers_configasconfig

will have the same problems as

fromtestcontainers.core.configimportSETTING

Only difference is that one can monkeypatch values of the testcontainers_config dataclass object.

But if you goal was to allow to make testcontainers_config replaceable with a new TestcontainersConfiguration instance, it won't work.

But thank you for adopting my idea so fast.
It's good enough for me.

[alexanderankin]

The data class is not frozen

…

On Mon, Apr 8, 2024, 10:07 AM Kound ***@***.***> wrote: Dear, @alexanderankin <https://github.com/alexanderankin> Imports like from testcontainers.core.config import testcontainers_config as config will have the same problems as from testcontainers.core.config import SETTING Only difference is that one can monkeypatch values of the testcontainers_config dataclass object. But if you goal was to allow to make testcontainers_config replaceable with a new TestcontainersConfiguration instance, it won't work. But thank you for adopting my idea so fast. It's good enough for me. — Reply to this email directly, view it on GitHub <#532 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACECGJCXAA3UJV7EJPJKHIDY4KQCFAVCNFSM6AAAAABF4JQBFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBSHA2TGNRSGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>