Skip to content

fix(vault): add support for HashiCorp Vault container - #366

Merged
santi merged 12 commits into
testcontainers:mainfrom
f4z3r:feat/vault
Apr 5, 2024
Merged

fix(vault): add support for HashiCorp Vault container#366
santi merged 12 commits into
testcontainers:mainfrom
f4z3r:feat/vault

Conversation

@f4z3r

@f4z3rf4z3r commented Jul 4, 2023

Copy link
Copy Markdown
Contributor

Add support for a Vault container.

@f4z3r

f4z3r commented Aug 4, 2023

Copy link
Copy Markdown
ContributorAuthor

@tillahoffmann Am I correct in assuming I need to wait for workflow approval before I can continue to update the dependencies for this PR?

@alexanderankinalexanderankin added 🛠️ needs more work Need to invest more time, can be a rebase or code updates ✨ feat and removed 👀 requires attention labels Mar 9, 2024
@alexanderankinalexanderankin added the 👥 community feat feature but its a community module so we wont bump tc core for it label Mar 26, 2024
@alexanderankinalexanderankin changed the title feat(vault): add support for HashiCorp Vault containerfix(vault): add support for HashiCorp Vault containerApr 2, 2024
@santi

santi commented Apr 3, 2024

Copy link
Copy Markdown
Contributor

Hi @f4z3r!

Thank you for your contribution, Hashicorp's Vault is something we would like to see supported. We are sorry for the extended delay in feedback and merged PRs, but are now on back on track with active maintainers.

Could you please rebase or merge in the latest changes from main? That way we can start moving this PR forward

@f4z3r

f4z3r commented Apr 3, 2024

Copy link
Copy Markdown
ContributorAuthor

@santi sure thing. I will get to it over the next couple of days 👍🏽

@f4z3r

f4z3r commented Apr 4, 2024

Copy link
Copy Markdown
ContributorAuthor

@santi alright I updated the PR to be according to the new repo structure. I am not super familiar with Poetry, but it seemed I needed to update the entire lock file to install the required packages I added to run the tests. As far as I could check, it seems to run fine, make modules/vault/tests ran the tests successfully.

santi
santi reviewed Apr 5, 2024
View reviewed changes
Comment threadmodules/vault/tests/test_vault.py Outdated
santi
santi reviewed Apr 5, 2024
View reviewed changes
Comment threadpoetry.lock
santi
santi reviewed Apr 5, 2024
View reviewed changes
Comment threadmodules/vault/testcontainers/vault/__init__.py Outdated
santi
santi reviewed Apr 5, 2024
View reviewed changes
Comment threadmodules/vault/testcontainers/vault/__init__.py Outdated
santi
santi reviewed Apr 5, 2024
View reviewed changes
Comment threadmodules/vault/testcontainers/vault/__init__.py Outdated
santi
santi reviewed Apr 5, 2024
View reviewed changes
Comment threadmodules/vault/testcontainers/vault/__init__.py Outdated
santi
santi reviewed Apr 5, 2024
View reviewed changes
Comment threadmodules/vault/testcontainers/vault/__init__.py Outdated
@santi

santi commented Apr 5, 2024

Copy link
Copy Markdown
Contributor

Good work so far, @f4z3r! With this speed we are ready to merge the module today 😄

santi
santi reviewed Apr 5, 2024
View reviewed changes
Comment threadmodules/vault/testcontainers/vault/__init__.py
@santi

santi commented Apr 5, 2024

Copy link
Copy Markdown
Contributor

Tests are failing because the specified extravault does not exist. You can add it in pyproject.toml under [tool.poetry.extras] as vault = [] (Same as the kafka entry in the list)

@f4z3r

f4z3r commented Apr 5, 2024

Copy link
Copy Markdown
ContributorAuthor

Good work so far, @f4z3r! With this speed we are ready to merge the module today 😄

Well thanks for the quick reviews and your help! 😄

santi
santi approved these changes Apr 5, 2024
View reviewed changes

@santisanti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 💯 Thank you for your contribution.

Looks like Github Actions hit a bit of a bump right when everything was done, so only half of the checks have passed, and I'm getting 500 Errors randomly. Once https://github.com/testcontainers/testcontainers-python/actions/runs/8567034738, https://github.com/testcontainers/testcontainers-python/actions/runs/8567034549 and https://github.com/testcontainers/testcontainers-python/actions/runs/8567034548 have run, I'll merge 👍

@f4z3r

f4z3r commented Apr 5, 2024

Copy link
Copy Markdown
ContributorAuthor

Great work! 💯 Thank you for your contribution.

Looks like Github Actions hit a bit of a bump right when everything was done, so only half of the checks have passed, and I'm getting 500 Errors randomly. Once https://github.com/testcontainers/testcontainers-python/actions/runs/8567034738, https://github.com/testcontainers/testcontainers-python/actions/runs/8567034549 and https://github.com/testcontainers/testcontainers-python/actions/runs/8567034548 have run, I'll merge 👍

Yup, seems GitHub is experiencing issues: https://www.githubstatus.com/

@santi

santi commented Apr 5, 2024

Copy link
Copy Markdown
Contributor

@f4z3r Seems like the trouble is over, but the queued tasks are not running. Could you re-trigger a new set of checks by pushing a commit with git commit --allow-empty -m "Re-trigger PR checks"?

@santi
santi merged commit 1326278 into testcontainers:mainApr 5, 2024
@github-actionsgithub-actionsBot mentioned this pull request Apr 5, 2024
Merged
alexanderankin pushed a commit that referenced this pull request Apr 8, 2024
@github-actions
chore(main): release testcontainers 4.3.2 (#530)
fe22758
🤖 I have created a release *beep* *boop*
---
##
[4.3.2](testcontainers-v4.3.1...testcontainers-v4.3.2)
(2024-04-08)
### Bug Fixes
* **core:** Improve typing for common container usage scenarios
([#523](#523))
([d5b8553](d5b8553))
* **core:** make config editable to avoid monkeypatching.1
([#532](#532))
([3be6da3](3be6da3))
* **vault:** add support for HashiCorp Vault container
([#366](#366))
([1326278](1326278))
---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
mloesch pushed a commit to mloesch/testcontainers-python that referenced this pull request Apr 8, 2024
@f4z3r@mloesch
fix(vault): add support for HashiCorp Vault container (testcontainers…
a00d8dd
…#366)
Add support for a Vault container.
mloesch pushed a commit to mloesch/testcontainers-python that referenced this pull request Apr 8, 2024
@github-actions@mloesch
chore(main): release testcontainers 4.3.2 (testcontainers#530)
ba33506
🤖 I have created a release *beep* *boop*
---
##
[4.3.2](testcontainers/testcontainers-python@testcontainers-v4.3.1...testcontainers-v4.3.2)
(2024-04-08)
### Bug Fixes
* **core:** Improve typing for common container usage scenarios
([testcontainers#523](testcontainers#523))
([d5b8553](testcontainers@d5b8553))
* **core:** make config editable to avoid monkeypatching.1
([testcontainers#532](testcontainers#532))
([3be6da3](testcontainers@3be6da3))
* **vault:** add support for HashiCorp Vault container
([testcontainers#366](testcontainers#366))
([1326278](testcontainers@1326278))
---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@santisantisanti approved these changes

Assignees

No one assigned

Labels

👥 community featfeature but its a community module so we wont bump tc core for it✨ feat🛠️ needs more workNeed to invest more time, can be a rebase or code updates✨ package: new

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@f4z3r@santi@alexanderankin