Skip to content

fix: Container for Milvus database - #606

Merged
alexanderankin merged 9 commits into
testcontainers:mainfrom
nightblure:feature/milvus-container
Jun 13, 2024
Merged

fix: Container for Milvus database#606
alexanderankin merged 9 commits into
testcontainers:mainfrom
nightblure:feature/milvus-container

Conversation

@nightblure

Copy link
Copy Markdown
Contributor

I use this wonderful package for writing tests, but I did not find a container for Milvus vector database

Please check, I'm ready to correct comments

@nightblurenightblure changed the title Create container for Milvusfeat: container for Milvus databaseJun 12, 2024
@nightblurenightblure changed the title feat: container for Milvus databasefeat: Container for Milvus databaseJun 12, 2024
@alexanderankinalexanderankin changed the title feat: Container for Milvus databasefix: Container for Milvus databaseJun 13, 2024
@alexanderankinalexanderankin added the 👥 community feat feature but its a community module so we wont bump tc core for it label Jun 13, 2024
@codecov

codecovBot commented Jun 13, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@f5a019b). Learn more about missing BASE report.

Additional details and impacted files
@@ Coverage Diff @@## main #606 +/- ##
=======================================
Coverage ? 75.18% =======================================
Files ? 10 Lines ? 548 Branches ? 77 =======================================
Hits ? 412 Misses ? 110 Partials ? 26 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nightblure

Copy link
Copy Markdown
ContributorAuthor

@alexanderankin thanks for your edits! Is there anything else required from me or is this solution suitable?

@alexanderankin

Copy link
Copy Markdown
Member

if it looks good to you it looks good to me

@nightblure

Copy link
Copy Markdown
ContributorAuthor

if it looks good to you it looks good to me

I think it's good

@alexanderankin
alexanderankin merged commit ec76df2 into testcontainers:mainJun 13, 2024
alexanderankin pushed a commit that referenced this pull request Jun 20, 2024
🤖 I have created a release *beep* *boop*
---
##
[4.6.0](testcontainers-v4.5.1...testcontainers-v4.6.0)
(2024-06-18)
### Features
* **core:** Added ServerContainer
([#595](#595))
([0768490](0768490))
* **core:** Image build (Dockerfile support)
([#585](#585))
([54c88cf](54c88cf))
### Bug Fixes
* Add Cockroach DB Module to Testcontainers
([#608](#608))
([4aff679](4aff679))
* Container for Milvus database
([#606](#606))
([ec76df2](ec76df2))
* move TESTCONTAINERS_HOST_OVERRIDE to config.py
([#603](#603))
([2a5a190](2a5a190)),
closes
[#602](#602)
* **mqtt:** Add mqtt.MosquittoContainer
([#568](#568))
([#599](#599))
([59cb6fc](59cb6fc))
### Documentation
* **main:** Private registry
([#598](#598))
([9045c0a](9045c0a))
* Update private registry instructions
([#604](#604))
([f5a019b](f5a019b))
---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👥 community featfeature but its a community module so we wont bump tc core for it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@nightblure@alexanderankin