Skip to content

fix(core): add container logs to TimeoutError when wait strategy times out - #1007

Merged
Tranquility2 merged 3 commits into
testcontainers:mainfrom
ticapix:main
May 29, 2026
Merged

fix(core): add container logs to TimeoutError when wait strategy times out#1007
Tranquility2 merged 3 commits into
testcontainers:mainfrom
ticapix:main

Conversation

@ticapix

Copy link
Copy Markdown
Contributor

Hello,

Thanks for testcontainers !

I had a lot of trouble to understand why my docker strategy was timing out and I ended up patching the code like in this PR to get the container logs when there is a timeout.

I hope it can help others when debugging.

make tests runs ok

Happy to update the PR if needed

@alexanderankin

Copy link
Copy Markdown
Member

not sure why the cicd is not running 👀

@alexanderankinalexanderankin changed the title add container logs to TimeoutError when wait strategy times outfix(core): add container logs to TimeoutError when wait strategy times outMay 18, 2026
@alexanderankin

Copy link
Copy Markdown
Member

core/testcontainers/core/container.py:223: error: "TimeoutError" has no
attribute "add_note" [attr-defined]
ex.add_note(self._container.logs().decode())
^~~~~~~~~~~
Found 1 error in 1 file (checked 45 source files)

@codecov

codecovBot commented May 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.06%. Comparing base (4c53b89) to head (365da09).

Additional details and impacted files
@@ Coverage Diff @@## main #1007 +/- ##
==========================================
+ Coverage 83.01% 83.06% +0.04% 
==========================================
Files 16 16 Lines 1725 1730 +5 Branches 189 190 +1 ==========================================
+ Hits 1432 1437 +5 
Misses 236 236 Partials 57 57 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Tranquility2
Tranquility2 merged commit 1fadb40 into testcontainers:mainMay 29, 2026
8 checks passed
alexanderankin added a commit that referenced this pull request Jun 3, 2026
🤖 I have created a release *beep* *boop*
---
##
[4.15.0-rc3](testcontainers-v4.15.0-rc2...testcontainers-v4.15.0-rc3)
(2026-06-03)
### Features
* **core:** add Podman compatibility
([#1028](#1028))
([37093ab](37093ab))
* **core:** auto-detect DOCKER_HOST from current docker context
([#1026](#1026))
([d4b8ff6](d4b8ff6)),
closes
[#1025](#1025)
### Bug Fixes
* **core:** add container logs to TimeoutError when wait strategy times
out
([#1007](#1007))
([1fadb40](1fadb40))
* **core:** close Reaper socket at interpreter exit to prevent
ResourceWarning
([#1017](#1017))
([d3a1517](d3a1517))
* **cosmosdb:** replace distutils.strtobool removed in Python 3.12
([#1018](#1018))
([3e487f4](3e487f4))
* **mongodb:** Use wait strategy instead of deprecated wait_for_logs
([#943](#943))
([c8118e7](c8118e7))
* **mssql:** use `ExecWaitStrategy` instead of deprecated
`wait_container_is_ready`
([#1016](#1016))
([4c53b89](4c53b89)),
closes
[#874](#874)
* **neo4j:** Swap out use of depricated wait utils for wait_strategies
([#1012](#1012))
([6deaf3b](6deaf3b))
---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Co-authored-by: David Ankin <daveankin@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ticapix@alexanderankin@Tranquility2