Uh oh!
There was an error while loading. Please reload this page.
Build option for DockerCompose - #168
Conversation
yakimka
commented
Apr 1, 2022
@aloosley, hello. Can you update this PR? |
Uh oh!
There was an error while loading. Please reload this page.
aloosley
commented
Apr 1, 2022
Hi both, thanks for checking in on this PR! First glance, the needed change looks small. I'll do this (and try to write a better test) in the next day when I get to a computer. |
…ners-python into compose-build-option
Codecov Report
@@ Coverage Diff @@## master #168 +/- ##
=======================================
Coverage 85.07% 85.08% =======================================
Files 24 24 Lines 630 637 +7 Branches 59 61 +2 =======================================
+ Hits 536 542 +6
Misses 75 75 - Partials 19 20 +1
Continue to review full report at Codecov.
|
aloosley
commented
Apr 2, 2022
Alright @yakimka, I cleaned up the PR a bit. Testing |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
aloosley
commented
Apr 2, 2022
🥳 Thanks @yakimka, any other steps needed here? |
yakimka
commented
Apr 2, 2022
@aloosley thank you =) |
There are some usecases where it is useful to force building to occur when using docker-compose (the equivalent to
docker-compose up --build).In this PR, a boolean parameter is added to allow for this, similar to the
pullboolean parameter that already exists to force image pulling.