Skip to content

Add ability to expose both http and native ports for clickhouse (#257) - #261

Open
yakimka wants to merge 1 commit into
mainfrom
clickhouse-multiple-ports
Open

Add ability to expose both http and native ports for clickhouse (#257)#261
yakimka wants to merge 1 commit into
mainfrom
clickhouse-multiple-ports

Conversation

@yakimka

@yakimkayakimka commented Oct 31, 2022

Copy link
Copy Markdown
Contributor

Fixed#257

@yakimkayakimka changed the title Draft: Add ability to expose both http and native ports for clickhouse (#257)Add ability to expose both http and native ports for clickhouse (#257)Oct 31, 2022
@tillahoffmann

Copy link
Copy Markdown
Contributor

@yakimka, sorry for the slow follow up on this. Would you mind rebasing on master? I'm also planning a major-version release so we can squeeze in the breaking change of dropping the port argument. I'm breaking a bunch of other things in #296.

@codecov-commenter

codecov-commenter commented Mar 9, 2024

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.65%. Comparing base (472da35) to head (618b83d).
⚠️ Report is 533 commits behind head on main.

Files with missing linesPatch %Lines
testcontainers/clickhouse.py62.50%2 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #261 +/- ##
==========================================
- Coverage 85.93% 85.65% -0.28% 
==========================================
Files 28 28 Lines 782 788 +6 Branches 77 78 +1 ==========================================
+ Hits 672 675 +3 - Misses 81 83 +2 - Partials 29 30 +1 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexanderankinalexanderankin added the 👥 community feat feature but its a community module so we wont bump tc core for it label Mar 26, 2024
@Tranquility2Tranquility2 added the 🛠️ needs more work Need to invest more time, can be a rebase or code updates label Apr 8, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👥 community featfeature but its a community module so we wont bump tc core for it✨ feat🛠️ needs more workNeed to invest more time, can be a rebase or code updates📦 package: clickhouse

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clickhouse container exposing ports setup is strange

5 participants

@yakimka@tillahoffmann@codecov-commenter@Tranquility2@alexanderankin