Uh oh!
There was an error while loading. Please reload this page.
fix: pin PyYAML to 5.3.1 for Python versions >= 3.10 - #376
Closed
mloesch wants to merge 1 commit into
Closed
Conversation
mloesch
commented
Nov 23, 2023
ContributorAuthor
Superseded by #394 |
kiview
commented
Nov 24, 2023
Member
Thank you for providing this PR and sorry for not reviewing and considering it before implementing #394. Please see this comment explaining our rationale to do so. |
mloesch
commented
Nov 27, 2023
ContributorAuthor
@kiview thanks for the explanation! No worries, my intention here was just to unblock the failing build. I agree that abandoning the deprecated V1 compose is the better solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR builds are currently failing with PyYAML 5.4.1 due to a Cython incompatibility.
E.g. https://github.com/testcontainers/testcontainers-python/actions/runs/5570814818/job/15393831115?pr=371
Upgrading PyYAML to 6.X is not an option because docker-compose V1 is incompatible and won't receive any updates due to EOL (see docker/compose#9114).
This should be the temporary fix until #358 is implemented.
References: