Skip to content

fix: Close docker client when stopping the docker container - #380

Merged
alexanderankin merged 2 commits into
testcontainers:mainfrom
rodrigoscc:main
Mar 9, 2024
Merged

fix: Close docker client when stopping the docker container#380
alexanderankin merged 2 commits into
testcontainers:mainfrom
rodrigoscc:main

Conversation

@rodrigoscc

@rodrigosccrodrigoscc commented Aug 17, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes the following warning

sys:1: ResourceWarning: unclosed <socket.socket fd=7, family=AddressFamily.AF_UNIX, type=SocketKind.SOCK_STREAM, proto=0, raddr=/Users/rodrigo/.docker/run/docker.sock>

Related to #379

@rodrigosccrodrigoscc mentioned this pull request Aug 17, 2023
Closed
@alexanderankin

alexanderankin commented Nov 3, 2023

Copy link
Copy Markdown
Member

can you add a reproducer? i cannot replicate with:

PostgresContainer.py
fromtypingimportAnyfromsqlalchemyimportcreate_engine, Engine, Connection, CursorResult, textfromtestcontainers.postgresimportPostgresContainerp=PostgresContainer("postgres:14-alpine")
defmain():
p.start()
engine: Engine=create_engine(p.get_connection_url())
withengine.connect() asconn:
conn: Connection=connconn.execute(text("create table if not exists hero(name varchar(500) unique)"))
conn.execute(text("insert into hero(name) values ('alice')"))
conn.execute(text("insert into hero(name) values ('bob')"))
withconn.execute(text('select * from hero')) asexecute:
execute: CursorResult[Any] =executeprint(execute.fetchall())
if__name__=='__main__':
main()

@alexanderankinalexanderankin changed the title Close docker client when stopping the docker containerfix: Close docker client when stopping the docker containerMar 9, 2024
@alexanderankin
alexanderankin merged commit efb1683 into testcontainers:mainMar 9, 2024
@github-actionsgithub-actionsBot mentioned this pull request Mar 9, 2024
Merged
bearrito pushed a commit to bearrito/testcontainers-python that referenced this pull request Mar 9, 2024
@rodrigoscc@alexanderankin@bearrito
fix: Close docker client when stopping the docker container (testcont…
7bc73ce
…ainers#380)
Fixes the following warning
```
sys:1: ResourceWarning: unclosed <socket.socket fd=7, family=AddressFamily.AF_UNIX, type=SocketKind.SOCK_STREAM, proto=0, raddr=/Users/rodrigo/.docker/run/docker.sock>
```
Related to testcontainers#379
Co-authored-by: David Ankin <daveankin@gmail.com>
alexanderankin added a commit that referenced this pull request Mar 11, 2024
@github-actions@alexanderankin
chore(main): release testcontainers 4.0.1 (#456)
5dcda88
🤖 I have created a release *beep* *boop*
---
##
[4.0.1](testcontainers-v4.0.0...testcontainers-v4.0.1)
(2024-03-11)
### Features
* **postgres:** Remove SqlAlchemy dependency from postgres container
([#445](#445))
([f30eb1d](f30eb1d))
### Bug Fixes
* **clickhouse:** clickhouse waiting
([#428](#428))
([902a5a3](902a5a3))
* Close docker client when stopping the docker container
([#380](#380))
([efb1683](efb1683))
* failing tests for elasticsearch on machines with ARM CPU
([#454](#454))
([701b23a](701b23a))
* **mongodb:** waiting for container to start (it was not waiting at all
before?)
([#461](#461))
([2c4f171](2c4f171))
* unclosed socket warning in db containers
([#378](#378))
([cd90aa7](cd90aa7))
* Update the copyright header for readthedocs
([#341](#341))
([5bef18a](5bef18a))
---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: David Ankin <daveankin@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Mar 11, 2024
Merged
alexanderankin added a commit that referenced this pull request Mar 11, 2024
@github-actions@alexanderankin
chore(main): release testcontainers 4.0.1 (#466)
e72a0eb
🤖 I have created a release *beep* *boop*
---
##
[4.0.1](testcontainers-v4.0.0...testcontainers-v4.0.1)
(2024-03-11)
### Features
* **postgres:** Remove SqlAlchemy dependency from postgres container
([#445](#445))
([f30eb1d](f30eb1d))
### Bug Fixes
* **clickhouse:** clickhouse waiting
([#428](#428))
([902a5a3](902a5a3))
* Close docker client when stopping the docker container
([#380](#380))
([efb1683](efb1683))
* failing tests for elasticsearch on machines with ARM CPU
([#454](#454))
([701b23a](701b23a))
* go back to 4.0.1
([#465](#465))
([1ac8c24](1ac8c24))
* **mongodb:** waiting for container to start (it was not waiting at all
before?)
([#461](#461))
([2c4f171](2c4f171))
* unclosed socket warning in db containers
([#378](#378))
([cd90aa7](cd90aa7))
* Update the copyright header for readthedocs
([#341](#341))
([5bef18a](5bef18a))
---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: David Ankin <daveankin@gmail.com>
This was referenced Mar 11, 2024
Closed
Merged
bearrito pushed a commit to bearrito/testcontainers-python that referenced this pull request Mar 30, 2024
@github-actions@alexanderankin@bearrito
chore(main): release testcontainers 4.0.1 (testcontainers#456)
177f9c7
🤖 I have created a release *beep* *boop*
---
##
[4.0.1](testcontainers/testcontainers-python@testcontainers-v4.0.0...testcontainers-v4.0.1)
(2024-03-11)
### Features
* **postgres:** Remove SqlAlchemy dependency from postgres container
([testcontainers#445](testcontainers#445))
([f30eb1d](testcontainers@f30eb1d))
### Bug Fixes
* **clickhouse:** clickhouse waiting
([testcontainers#428](testcontainers#428))
([902a5a3](testcontainers@902a5a3))
* Close docker client when stopping the docker container
([testcontainers#380](testcontainers#380))
([efb1683](testcontainers@efb1683))
* failing tests for elasticsearch on machines with ARM CPU
([testcontainers#454](testcontainers#454))
([701b23a](testcontainers@701b23a))
* **mongodb:** waiting for container to start (it was not waiting at all
before?)
([testcontainers#461](testcontainers#461))
([2c4f171](testcontainers@2c4f171))
* unclosed socket warning in db containers
([testcontainers#378](testcontainers#378))
([cd90aa7](testcontainers@cd90aa7))
* Update the copyright header for readthedocs
([testcontainers#341](testcontainers#341))
([5bef18a](testcontainers@5bef18a))
---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: David Ankin <daveankin@gmail.com>
bearrito pushed a commit to bearrito/testcontainers-python that referenced this pull request Mar 30, 2024
@github-actions@alexanderankin@bearrito
chore(main): release testcontainers 4.0.1 (testcontainers#466)
7b68523
🤖 I have created a release *beep* *boop*
---
##
[4.0.1](testcontainers/testcontainers-python@testcontainers-v4.0.0...testcontainers-v4.0.1)
(2024-03-11)
### Features
* **postgres:** Remove SqlAlchemy dependency from postgres container
([testcontainers#445](testcontainers#445))
([f30eb1d](testcontainers@f30eb1d))
### Bug Fixes
* **clickhouse:** clickhouse waiting
([testcontainers#428](testcontainers#428))
([902a5a3](testcontainers@902a5a3))
* Close docker client when stopping the docker container
([testcontainers#380](testcontainers#380))
([efb1683](testcontainers@efb1683))
* failing tests for elasticsearch on machines with ARM CPU
([testcontainers#454](testcontainers#454))
([701b23a](testcontainers@701b23a))
* go back to 4.0.1
([testcontainers#465](testcontainers#465))
([1ac8c24](testcontainers@1ac8c24))
* **mongodb:** waiting for container to start (it was not waiting at all
before?)
([testcontainers#461](testcontainers#461))
([2c4f171](testcontainers@2c4f171))
* unclosed socket warning in db containers
([testcontainers#378](testcontainers#378))
([cd90aa7](testcontainers@cd90aa7))
* Update the copyright header for readthedocs
([testcontainers#341](testcontainers#341))
([5bef18a](testcontainers@5bef18a))
---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: David Ankin <daveankin@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

👀 requires attention

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rodrigoscc@alexanderankin