Uh oh!
There was an error while loading. Please reload this page.
feat(redis): add AsyncRedis support - #434
Conversation
totallyzen
commented
Mar 1, 2024
hey @bearrito thanks for the contrib! Apologies for the failures on the different module things, I'll double check my mistake on it. Will fix so you can rebase and have your checks passing! :) |
bearrito
commented
Mar 1, 2024
@totallyzen I'm 99% sure I did the wrong thing with dependencies. I can see they should go under the module group extras. In another issue (#436) I'm trying to create a new module. I think the docs are out of date on this - https://testcontainers-python.readthedocs.io/en/latest/README.html |
| anyio = "^4.3.0" | ||
| pre-commit = "^3.6.2" |
There was a problem hiding this comment.
for these,
- make
anyioa dev dependency for now - you don't actually needanyioto run redis - I tend not to install
pre-commitunder poetry because then you will need poetry-ception - just usepip install pre-commitfor that one! - the rest should be fine, and in fact after fix(build): early exit strategy for modules #437 you seem to be just fine so fixing these two should be all you need.
totallyzen
commented
Mar 1, 2024
I fixed the early-exit strat in #437 - was a doozy but I'm happy with the results! (dynamic matrix, no errors!) |
bearrito
commented
Mar 2, 2024
Updated. |
…v and CI (testcontainers#438) I could not install pre-commit handler because the package was missing in [tool.poetry.group.dev.dependencies]. I also updated the configuration for the pre-commit handler as black and ruff packages were outdated. Also removed deprecation for ruff v0.3.0 config in pyproject.toml. --------- Co-authored-by: Balint Bartha <39852431+totallyzen@users.noreply.github.com>
Adds support for async redis
Discussed somewhat here - #374
Tested in the recently fixed devcontainers.
There is currently no working tests for pub/sub.