Skip to content

chore(codestyle): switch to ruff from black for code formatting - #529

Merged
totallyzen merged 1 commit into
testcontainers:mainfrom
max-pfeiffer:feature/code-formatting-with-ruff
Apr 5, 2024
Merged

chore(codestyle): switch to ruff from black for code formatting#529
totallyzen merged 1 commit into
testcontainers:mainfrom
max-pfeiffer:feature/code-formatting-with-ruff

Conversation

@max-pfeiffer

Copy link
Copy Markdown
Contributor

Changed pre-commit config. Some files
became re-formatted.

Changed pre-commit config. Some files
became re-formatted.
@santisanti changed the title feat: switched to Ruff for code formattingfeat(codestyle): switched to Ruff for code formattingApr 5, 2024

@santisanti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Always nice with fewer dependencies and tools for development setups. 🎉

I am all for merging this, but I think @totallyzen also should have a look as he is the one that set this up in the first place.

@santi
santi requested a review from totallyzenApril 5, 2024 09:43
@santisanti changed the title feat(codestyle): switched to Ruff for code formattingfix(codestyle): switched to Ruff for code formattingApr 5, 2024
@totallyzentotallyzen changed the title fix(codestyle): switched to Ruff for code formattingchore(codestyle): switch to ruff from black for code formattingApr 5, 2024

@totallyzentotallyzen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I changed the title to chore(): ... because this only impacts readability and I don't think we need it on the changelogs

@totallyzen

Copy link
Copy Markdown
Contributor

he is the one that set this up in the first place

I like writing clean code, but sometimes copy/pasta is the way to go for productivity so I'm not immune either. 😂

@totallyzen
totallyzen merged commit 9a89748 into testcontainers:mainApr 5, 2024
mloesch pushed a commit to mloesch/testcontainers-python that referenced this pull request Apr 8, 2024
…estcontainers#529)
Changed pre-commit config. Some files became re-formatted.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@max-pfeiffer@totallyzen@santi@alexanderankin