Skip to content

fix: added types to exec & tc_properties_get_tc_host - #561

Merged
alexanderankin merged 2 commits into
testcontainers:mainfrom
Dandiggas:docker-container-exec-type
May 17, 2024
Merged

fix: added types to exec & tc_properties_get_tc_host#561
alexanderankin merged 2 commits into
testcontainers:mainfrom
Dandiggas:docker-container-exec-type

Conversation

@Dandiggas

@DandiggasDandiggas commented Apr 29, 2024

Copy link
Copy Markdown
Contributor

#557 - trying to solve this issue by adding types.

errordeveloper
errordeveloper approved these changes Apr 29, 2024
View reviewed changes

@errordevelopererrordeveloper left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this LGTM overall, thanks @Dandiggas!

@errordeveloper

errordeveloper commented Apr 29, 2024

Copy link
Copy Markdown

@kiview could you please approve the workflows to run?

@alexanderankin

alexanderankin commented Apr 29, 2024

Copy link
Copy Markdown
Member

We'll take a look

@alexanderankin

alexanderankin commented May 11, 2024

Copy link
Copy Markdown
Member

yep so we support python 3.9 for now so cant use the pipe syntax for typing.Union - but the other type is indeed wrong so we could merge a pr that just fixes a single type, would probably prefer a PR that fixes types more comprehensively like #504 - if you want to provide feedback on that branch, that could help it along - it was only not merged because i was not confident in 100% of the choices made in there at the time.

ill leave this open in case you want to replace with from typing import Union

@Dandiggas
Dandiggasforce-pushed the docker-container-exec-type branch from b66a469 to a43d3b5CompareMay 16, 2024 22:34
@Dandiggas

Dandiggas commented May 16, 2024

Copy link
Copy Markdown
ContributorAuthor

@alexanderankin Now supports python 3.9, please review when possible

@alexanderankinalexanderankin changed the title added types to exec & tc_properties_get_tc_hostfix: added types to exec & tc_properties_get_tc_hostMay 17, 2024
@alexanderankin
alexanderankin merged commit 9eabb79 into testcontainers:mainMay 17, 2024
@github-actionsgithub-actionsBot mentioned this pull request May 17, 2024
Merged
@alexanderankin

alexanderankin commented May 17, 2024

Copy link
Copy Markdown
Member

thank you for the contribution! if you are interested in improving typing in this library are other types that I have started but did not feel confident enough to merge #504

alexanderankin pushed a commit that referenced this pull request May 25, 2024
@github-actions
chore(main): release testcontainers 4.5.0 (#575)
70414db
🤖 I have created a release *beep* *boop*
---
##
[4.5.0](testcontainers-v4.4.1...testcontainers-v4.5.0)
(2024-05-25)
### Features
* **core:** Private registry
([#566](#566))
([59fbcfa](59fbcfa))
### Bug Fixes
* added types to exec & tc_properties_get_tc_host
([#561](#561))
([9eabb79](9eabb79))
* on windows, DockerCompose.get_service_host returns an unusable
"0.0.0.0" - adjust to 127.0.0.1
([#457](#457))
([2aa3d37](2aa3d37))
---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
mbenabda pushed a commit to mbenabda/testcontainers-python that referenced this pull request May 25, 2024
@github-actionsMehdi BEN ABDALLAH
chore(main): release testcontainers 4.5.0 (testcontainers#575)
cfc12c5
🤖 I have created a release *beep* *boop*
---
##
[4.5.0](testcontainers/testcontainers-python@testcontainers-v4.4.1...testcontainers-v4.5.0)
(2024-05-25)
### Features
* **core:** Private registry
([testcontainers#566](testcontainers#566))
([59fbcfa](testcontainers@59fbcfa))
### Bug Fixes
* added types to exec & tc_properties_get_tc_host
([testcontainers#561](testcontainers#561))
([9eabb79](testcontainers@9eabb79))
* on windows, DockerCompose.get_service_host returns an unusable
"0.0.0.0" - adjust to 127.0.0.1
([testcontainers#457](testcontainers#457))
([2aa3d37](testcontainers@2aa3d37))
---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@errordevelopererrordevelopererrordeveloper approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

👀 requires attention

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Dandiggas@errordeveloper@alexanderankin