Skip to content

chore(core): Display status on readme - #589

Merged
alexanderankin merged 6 commits into
testcontainers:mainfrom
Tranquility2:export_code_coverage
Jun 5, 2024
Merged

chore(core): Display status on readme#589
alexanderankin merged 6 commits into
testcontainers:mainfrom
Tranquility2:export_code_coverage

Conversation

@Tranquility2

@Tranquility2Tranquility2 commented May 28, 2024

Copy link
Copy Markdown
Contributor

Make the Readme display some more details regarding the project:

  • using ruff (just a nice reference)
  • pypi version (good visibility)
  • license (good visibility)
  • supported python versions (good visibility)
  • code coverage reporting (main driver for this PR)

image

Relates to #544 - export code coverage (e.g. to codecov)

@alexanderankinalexanderankin changed the title Display status on readmechore(core): Display status on readmeMay 28, 2024
Comment thread.github/workflows/ci-core.yml Outdated
@Tranquility2
Tranquility2force-pushed the export_code_coverage branch 2 times, most recently from ca50fa3 to b9af15aCompareMay 28, 2024 21:06
@codecov

codecovBot commented May 28, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@54c88cf). Learn more about missing BASE report.

Additional details and impacted files
@@ Coverage Diff @@## main #589 +/- ##
=======================================
Coverage ? 74.95% =======================================
Files ? 10 Lines ? 547 Branches ? 78 =======================================
Hits ? 410 Misses ? 110 Partials ? 27 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

DEBUG: downloaded files
remove debug
undo debug
@Tranquility2
Tranquility2force-pushed the export_code_coverage branch from a8d7875 to f8d744dCompareMay 28, 2024 21:29
@Tranquility2

Tranquility2 commented May 28, 2024

Copy link
Copy Markdown
ContributorAuthor

https://github.com/testcontainers/testcontainers-python/actions/runs/9276601581/job/25524084272

error - 2024-05-28 21:31:54,280 -- Upload failed: {"detail":"Tokenless has reached GitHub rate limit. Please upload using a token: https://docs.codecov.com/docs/adding-the-codecov-token. Expected available in 221 seconds."}

Looks like CODECOV_TOKEN is needed in secrets

@alexanderankin
alexanderankin merged commit 54822de into testcontainers:mainJun 5, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Tranquility2@kiview@alexanderankin