Skip to content

docs: Documentation fix for ServerContainer - #671

Merged
alexanderankin merged 1 commit into
testcontainers:mainfrom
sasa-buklijas:patch-2
Nov 11, 2024
Merged

docs: Documentation fix for ServerContainer#671
alexanderankin merged 1 commit into
testcontainers:mainfrom
sasa-buklijas:patch-2

Conversation

@sasa-buklijas

Copy link
Copy Markdown
Contributor

Used same wording as for modules/aws/testcontainers/aws/aws_lambda.py

@alexanderankin
alexanderankin marked this pull request as draft August 9, 2024 16:01
@alexanderankin
alexanderankin marked this pull request as ready for review August 13, 2024 12:56
@alexanderankinalexanderankin changed the title Documentation fix for ServerContainerdocs: Documentation fix for ServerContainerAug 13, 2024
@codecov

codecovBot commented Aug 13, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@5216b02). Learn more about missing BASE report.

Additional details and impacted files
@@ Coverage Diff @@## main #671 +/- ##
=======================================
Coverage ? 77.40% =======================================
Files ? 12 Lines ? 602 Branches ? 89 =======================================
Hits ? 466 Misses ? 110 Partials ? 26 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexanderankin

Copy link
Copy Markdown
Member

are we going to fix generic module here or later?

Used same wording as for modules/aws/testcontainers/aws/aws_lambda.py
@alexanderankin
alexanderankin merged commit 0303d47 into testcontainers:mainNov 11, 2024
alexanderankin pushed a commit that referenced this pull request Dec 10, 2024
🤖 I have created a release *beep* *boop*
---
##
[4.9.0](testcontainers-v4.8.2...testcontainers-v4.9.0)
(2024-11-26)
### Features
* **compose:** support for setting profiles
([#738](#738))
([3e00e71](3e00e71))
* **core:** Support working with env files
([#737](#737))
([932ee30](932ee30))
### Bug Fixes
* allow running all tests
([#721](#721))
([f958cf9](f958cf9))
* **core:** Avoid hanging upon bad docker host connection
([#742](#742))
([4ced198](4ced198))
* **core:** running testcontainer inside container
([#714](#714))
([85a6666](85a6666))
* **generic:** Also catch URLError waiting for ServerContainer
([#743](#743))
([24e354f](24e354f))
* update wait_for_logs to not throw on 'created', and an optimization
([#719](#719))
([271ca9a](271ca9a))
* Vault health check
([#734](#734))
([79434d6](79434d6))
### Documentation
* Documentation fix for ServerContainer
([#671](#671))
([0303d47](0303d47))
---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@sasa-buklijas@alexanderankin@Tranquility2