Uh oh!
There was an error while loading. Please reload this page.
fix: Change env var disabling OpenSearch security plugin - #773
Merged
Conversation
alexanderankin
commented
Feb 15, 2025
Member
Can you set both vars for back compat? |
oelhammouchi
commented
Feb 16, 2025
ContributorAuthor
Unfortunately not, I tested it already and it gives an error: ERROR: setting [plugins.security.disabled] already set, saw [true] and [true]However, the change seems backwards compatible by itself, as the tests still pass. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #773 +/- ##
=======================================
Coverage ? 84.73% =======================================
Files ? 12 Lines ? 668 Branches ? 105 =======================================
Hits ? 566 Misses ? 79 Partials ? 23 ☔ View full report in Codecov by Sentry. |
oelhammouchi
commented
Feb 22, 2025
ContributorAuthor
@alexanderankin everything seems to check out, can we kindly move forward with this 😊 |
alexanderankin
approved these changes
Feb 22, 2025
alexanderankin pushed a commit
that referenced
this pull request
Mar 5, 2025
🤖 I have created a release *beep* *boop* --- ## [4.9.2](testcontainers-v4.9.1...testcontainers-v4.9.2) (2025-02-26) ### Bug Fixes * Change env var disabling OpenSearch security plugin ([#773](#773)) ([2620d7f](2620d7f)) * **core:** create_label test ([#771](#771)) ([7517297](7517297)) * **core:** multiple container start invocations with custom labels ([#769](#769)) ([3e783a8](3e783a8)) * **keycloak:** Fixed Keycloak testcontainer for latest version v26.1.0 ([#766](#766)) ([b1642e9](b1642e9)) * **scylla:** scylla get cluster method ([#778](#778)) ([46913c1](46913c1)) ### Documentation * Fixed typo in CONTRIBUTING.md ([#767](#767)) ([f0bb0f5](f0bb0f5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes#772