Uh oh!
There was an error while loading. Please reload this page.
fix(modules): Fix postgres deprecation warning. - #883
Conversation
Remove the `wait_container_is_ready` decorator as per deprecation warning into the new `container.waiting_for`
surister
commented
Sep 30, 2025
The string |
I was testing this thoroughly and sometimes, maybe 1/10 runs this fails, the log successfully emits 'database system is ready...' and the waiting strategy picks it up but still the database is not ready. Adding a |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #883 +/- ##
=======================================
Coverage 79.78% 79.78% =======================================
Files 14 14 Lines 1182 1182 Branches 184 184 =======================================
Hits 943 943 Misses 197 197 Partials 42 42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pipeline failing due to missing import (bad cherrypicking on my part 🥲) Anyway, will close this and properly migrate the module once #892 is finished. |
jankatins
commented
Oct 18, 2025
I guess this could be done with a healthcheck waiting strategy or by adding a new waiting strategy which runs a function or runs a command with sh in the container |
alexanderankin
commented
Oct 18, 2025
via email
for postgres we disagree with at least java but several people have come to
adjust specifically postgres wait logic so im inclined to preserve behavior
if possible …On Sat, Oct 18, 2025 at 8:48 AM Jan Katins ***@***.***> wrote:
*jankatins* left a comment (testcontainers/testcontainers-python#883)
<#883 (comment)>
I guess this could be done with a healthcheck waiting strategy or by
adding a new waiting strategy which runs a function or runs a command with
sh in the container
—
Reply to this email directly, view it on GitHub
<#883 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACECGJAGKPITJQJPGZZVGWD3YIZK5AVCNFSM6AAAAACH4C4MW6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIMJYGQYDQMZYGE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Removed the
wait_container_is_readydecorator as per deprecation warning into the newcontainer.waiting_for