Skip to content

fix(cassandra,mysql,kafka): Use wait strategy instead of deprecated wait_for_logs - #945

Merged
alexanderankin merged 6 commits into
testcontainers:mainfrom
CarliJoy:use_wait_strategies
Jan 7, 2026
Merged

fix(cassandra,mysql,kafka): Use wait strategy instead of deprecated wait_for_logs#945
alexanderankin merged 6 commits into
testcontainers:mainfrom
CarliJoy:use_wait_strategies

Conversation

@CarliJoy

Copy link
Copy Markdown
Contributor

Use new wait strategies instead of deprecated wait_for_logs.

Important for project having pytest configured to fail on warnings.

Just adopted the containers I am personally using while keeping as much of the logic as before.

@CarliJoyCarliJoy changed the title fix(cassandra,mysqk,kafka) Use wait strategy instead of deprecated wait_for_logsfix(cassandra,mysqk,kafka): Use wait strategy instead of deprecated wait_for_logsJan 4, 2026
@codecov

codecovBot commented Jan 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.30%. Comparing base (9a97385) to head (bd618cc).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #945 +/- ##
=======================================
Coverage 78.30% 78.30% =======================================
Files 14 14 Lines 1212 1212 Branches 141 141 =======================================
Hits 949 949 Misses 222 222 Partials 41 41 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@CarliJoy

Copy link
Copy Markdown
ContributorAuthor

The failures in the CI are related to the not updated poetry lock file. See #845

I wasn't able to update the lock file.

@CarliJoy
CarliJoyforce-pushed the use_wait_strategies branch 2 times, most recently from bc48f76 to 1569d6eCompareJanuary 4, 2026 16:28
@alexanderankin

Copy link
Copy Markdown
Member

i can merge this for now and we can fix cassandra in a followup

@CarliJoy

Copy link
Copy Markdown
ContributorAuthor

@alexanderankin I finally fixed it, no need for later fix ;-)
Merge would be nice.

Sorry was busy with family therefore I was not consequentially working on this.l

@CarliJoy

Copy link
Copy Markdown
ContributorAuthor

(last force push with corrected commits)

@alexanderankin
alexanderankin merged commit b7791b9 into testcontainers:mainJan 7, 2026
18 checks passed
@alexanderankin

Copy link
Copy Markdown
Member

while this is not conflicted....

@CarliJoy
CarliJoy deleted the use_wait_strategies branch January 7, 2026 22:00
@CarliJoyCarliJoy changed the title fix(cassandra,mysqk,kafka): Use wait strategy instead of deprecated wait_for_logsfix(cassandra,mysql,kafka): Use wait strategy instead of deprecated wait_for_logsJan 7, 2026
alexanderankin pushed a commit that referenced this pull request Jan 7, 2026
🤖 I have created a release *beep* *boop*
---
##
[4.14.0](testcontainers-v4.13.3...testcontainers-v4.14.0)
(2026-01-07)
### Features
* Add ExecWaitStrategy and migrate Postgres from deprecated decorator
([#935](#935))
([2d9eee3](2d9eee3))
### Bug Fixes
* add ruff to deps
([#919](#919))
([5853d32](5853d32))
* **cassandra,mysqk,kafka:** Use wait strategy instead of deprecated
wait_for_logs
([#945](#945))
([b7791b9](b7791b9))
* **core:** recreate poetry lockfile with latest versions of libraries
([#946](#946))
([9a97385](9a97385))
* **elasticsearch:** Use wait strategy instead of deprecated decorator
([#915](#915))
([c785ecd](c785ecd))
* **minio:** minio client requires kwargs now
([#933](#933))
([37f5902](37f5902))
* **minio:** Use wait strategy instead of deprecated decorator
([#899](#899))
([febccb7](febccb7))
---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@CarliJoy@alexanderankin